From: Christoph Hellwig <hch@infradead.org>
To: Cathy Avery <cavery@redhat.com>
Cc: kys@microsoft.com, hch@infradead.org, haiyangz@microsoft.com,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
dan.carpenter@oracle.com, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun
Date: Thu, 19 Oct 2017 08:35:10 -0700 [thread overview]
Message-ID: <20171019153510.GA7633@infradead.org> (raw)
In-Reply-To: <1508261721-24144-1-git-send-email-cavery@redhat.com>
On Tue, Oct 17, 2017 at 01:35:21PM -0400, Cathy Avery wrote:
> + /*
> + * Set the error handler work queue.
> + */
> + snprintf(host_dev->work_q_name, sizeof(host_dev->work_q_name),
> + "storvsc_error_wq_%d", host->host_no);
> + host_dev->handle_error_wq =
> + create_singlethread_workqueue(host_dev->work_q_name);
If you use alloc_ordered_workqueue directly instead of
create_singlethread_workqueue you can pass a format string and don't
need the separate allocation.
But I'm not sure if Tejun is fine with using __WQ_LEGACY directly..
Except for this nit this looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-10-19 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 17:35 [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun Cathy Avery
2017-10-19 15:35 ` Christoph Hellwig [this message]
2017-10-19 22:06 ` Long Li
2017-10-21 15:44 ` Tejun Heo
2017-10-31 12:24 ` Martin K. Petersen
2017-10-31 12:24 ` Martin K. Petersen
2017-10-31 12:31 ` Cathy Avery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019153510.GA7633@infradead.org \
--to=hch@infradead.org \
--cc=cavery@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.