From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Cathy Avery <cavery@redhat.com>
Cc: jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, haiyangz@microsoft.com,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>, Tejun Heo <tj@kernel.org>,
devel@linuxdriverproject.org, dan.carpenter@oracle.com
Subject: Re: [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun
Date: Tue, 31 Oct 2017 08:24:44 -0400 [thread overview]
Message-ID: <yq1shdzcxo3.fsf@oracle.com> (raw)
In-Reply-To: <20171021154444.GK1302522@devbig577.frc2.facebook.com> (Tejun Heo's message of "Sat, 21 Oct 2017 08:44:44 -0700")
>> If you use alloc_ordered_workqueue directly instead of
>> create_singlethread_workqueue you can pass a format string and don't
>> need the separate allocation.
>>
>> But I'm not sure if Tejun is fine with using __WQ_LEGACY directly..
>
> The only thing that flag does is exempting the workqueue from possible
> flush deadlock check as we don't know whether WQ_MEM_RECLAIM on a
> legacy workqueue is intentional. There's no reason to add it when
> converting to alloc_ordered_workqueue(). Just decide whether it needs
> forward progress guarantee and use WQ_MEM_RECLAIM if so.
Cathy?
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Cathy Avery <cavery@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, Tejun Heo <tj@kernel.org>,
kys@microsoft.com, haiyangz@microsoft.com,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
dan.carpenter@oracle.com, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun
Date: Tue, 31 Oct 2017 08:24:44 -0400 [thread overview]
Message-ID: <yq1shdzcxo3.fsf@oracle.com> (raw)
In-Reply-To: <20171021154444.GK1302522@devbig577.frc2.facebook.com> (Tejun Heo's message of "Sat, 21 Oct 2017 08:44:44 -0700")
>> If you use alloc_ordered_workqueue directly instead of
>> create_singlethread_workqueue you can pass a format string and don't
>> need the separate allocation.
>>
>> But I'm not sure if Tejun is fine with using __WQ_LEGACY directly..
>
> The only thing that flag does is exempting the workqueue from possible
> flush deadlock check as we don't know whether WQ_MEM_RECLAIM on a
> legacy workqueue is intentional. There's no reason to add it when
> converting to alloc_ordered_workqueue(). Just decide whether it needs
> forward progress guarantee and use WQ_MEM_RECLAIM if so.
Cathy?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-10-31 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 17:35 [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun Cathy Avery
2017-10-19 15:35 ` Christoph Hellwig
2017-10-19 22:06 ` Long Li
2017-10-21 15:44 ` Tejun Heo
2017-10-31 12:24 ` Martin K. Petersen [this message]
2017-10-31 12:24 ` Martin K. Petersen
2017-10-31 12:31 ` Cathy Avery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1shdzcxo3.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=cavery@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.