* [PATCH] drm/amd/display:: Fix NULL pointer in Raven hotplug
@ 2017-10-20 20:45 Jerry (Fangzhi) Zuo
[not found] ` <20171020204553.1831-1-Jerry.Zuo-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Jerry (Fangzhi) Zuo @ 2017-10-20 20:45 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
harry.wentland-5C7GfCeVMHo
Cc: Jerry (Fangzhi) Zuo
Programming sequence to frontend and backend has been switched.
In such case, program_scaler() is getting called when programming
frontend, and should be removed from backend programming routine.
Signed-off-by: Jerry (Fangzhi) Zuo <Jerry.Zuo@amd.com>
---
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
index 6c220a213ff2..9a93228718f4 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
@@ -1369,13 +1369,6 @@ static enum dc_status apply_single_controller_ctx_to_hw(
}
pipe_ctx->plane_res.scl_data.lb_params.alpha_en = pipe_ctx->bottom_pipe != 0;
- /* program_scaler and allocate_mem_input are not new asic */
- if ((!pipe_ctx_old ||
- memcmp(&pipe_ctx_old->plane_res.scl_data, &pipe_ctx->plane_res.scl_data,
- sizeof(struct scaler_data)) != 0) &&
- pipe_ctx->plane_state) {
- program_scaler(dc, pipe_ctx);
- }
pipe_ctx->stream->sink->link->psr_enabled = false;
--
2.11.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display:: Fix NULL pointer in Raven hotplug
[not found] ` <20171020204553.1831-1-Jerry.Zuo-5C7GfCeVMHo@public.gmane.org>
@ 2017-10-20 20:48 ` Harry Wentland
0 siblings, 0 replies; 2+ messages in thread
From: Harry Wentland @ 2017-10-20 20:48 UTC (permalink / raw)
To: Jerry (Fangzhi) Zuo, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 2017-10-20 04:45 PM, Jerry (Fangzhi) Zuo wrote:
> Programming sequence to frontend and backend has been switched.
> In such case, program_scaler() is getting called when programming
> frontend, and should be removed from backend programming routine.
>
> Signed-off-by: Jerry (Fangzhi) Zuo <Jerry.Zuo@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> index 6c220a213ff2..9a93228718f4 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> @@ -1369,13 +1369,6 @@ static enum dc_status apply_single_controller_ctx_to_hw(
> }
>
> pipe_ctx->plane_res.scl_data.lb_params.alpha_en = pipe_ctx->bottom_pipe != 0;
> - /* program_scaler and allocate_mem_input are not new asic */
> - if ((!pipe_ctx_old ||
> - memcmp(&pipe_ctx_old->plane_res.scl_data, &pipe_ctx->plane_res.scl_data,
> - sizeof(struct scaler_data)) != 0) &&
> - pipe_ctx->plane_state) {
> - program_scaler(dc, pipe_ctx);
> - }
>
> pipe_ctx->stream->sink->link->psr_enabled = false;
>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-20 20:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-20 20:45 [PATCH] drm/amd/display:: Fix NULL pointer in Raven hotplug Jerry (Fangzhi) Zuo
[not found] ` <20171020204553.1831-1-Jerry.Zuo-5C7GfCeVMHo@public.gmane.org>
2017-10-20 20:48 ` Harry Wentland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.