From: Johan Hovold <johan@kernel.org>
To: "Frank A. Cancio Bello" <frank@generalsoftwareinc.com>
Cc: pablo@netfilter.org, Julia.Lawall@lip6.fr,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 0/6] staging: greybus: Correct code style issues
Date: Sat, 21 Oct 2017 12:07:25 +0200 [thread overview]
Message-ID: <20171021100725.GB1226@localhost> (raw)
In-Reply-To: <cover.1508457306.git.frank@generalsoftwareinc.com>
On Thu, Oct 19, 2017 at 08:06:22PM -0400, Frank A. Cancio Bello wrote:
> This patchset address code style issues with blank lines, aligment,
> spacing. Beside it change 'var_name == NULL' by '!var_name' and use
> kernel type instead of C99 types.
Thanks for the clean ups. Some of these are good, some fall in category
of style choices that are really up to the author of the code to decide
on (e.g. using double newlines as a separator in a source file).
Either way, you need to send these also to the public lists.
scripts/get_maintainer.pl will tell you which (you don't need to CC lkml
unless you prefer).
Thanks,
Johan
> Frank A. Cancio Bello (6):
> staging: greybus: Remove unnecessary blank lines
> staging: greybus: Fix alignment issues
> staging: greybus: Use u32 instead of uint32_t
> staging: greybus: Add space around ternary operator
> staging: greybus: Move logical operator in previous line
> staging: greybus: Rewrite NULL comparisons
>
> drivers/staging/greybus/arche-apb-ctrl.c | 37 +++++++++++----------
> drivers/staging/greybus/arche-platform.c | 10 +++---
> drivers/staging/greybus/audio_codec.c | 23 ++++++-------
> drivers/staging/greybus/audio_codec.h | 2 +-
> drivers/staging/greybus/audio_module.c | 4 +--
> drivers/staging/greybus/audio_topology.c | 55 ++++++++++++++++----------------
> drivers/staging/greybus/authentication.c | 2 +-
> drivers/staging/greybus/bootrom.c | 20 ++++++------
> drivers/staging/greybus/bundle.c | 2 +-
> drivers/staging/greybus/camera.c | 16 +++++-----
> drivers/staging/greybus/connection.c | 4 ---
> drivers/staging/greybus/control.c | 1 -
> drivers/staging/greybus/core.c | 2 +-
> 13 files changed, 84 insertions(+), 94 deletions(-)
prev parent reply other threads:[~2017-10-21 10:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 0:06 [PATCH 0/6] staging: greybus: Correct code style issues Frank A. Cancio Bello
2017-10-20 0:06 ` [PATCH 1/6] staging: greybus: Remove unnecessary blank lines Frank A. Cancio Bello
2017-10-21 10:09 ` Johan Hovold
2017-10-20 0:22 ` [PATCH 2/6] staging: greybus: Fix alignment issues Frank A. Cancio Bello
2017-10-20 0:22 ` [PATCH 3/6] staging: greybus: Use u32 instead of uint32_t Frank A. Cancio Bello
2017-10-20 0:23 ` [PATCH 4/6] staging: greybus: Add space around ternary operator Frank A. Cancio Bello
2017-10-20 0:24 ` [PATCH 5/6] staging: greybus: Move logical operator in previous line Frank A. Cancio Bello
2017-10-20 0:26 ` [PATCH 6/6] staging: greybus: Rewrite NULL comparisons Frank A. Cancio Bello
2017-10-21 10:07 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171021100725.GB1226@localhost \
--to=johan@kernel.org \
--cc=Julia.Lawall@lip6.fr \
--cc=elder@kernel.org \
--cc=frank@generalsoftwareinc.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.