Re: [PATCH 1/6] staging: greybus: Remove unnecessary blank lines

[Johan Hovold <johan@kernel.org>]

On Thu, Oct 19, 2017 at 08:06:48PM -0400, Frank A. Cancio Bello wrote:
> Remove unnecessary blank lines to reduce file length and address
> checkpatch messages:
> CHECK: Please don't use multiple blank lines
> CHECK: Blank lines aren't necessary before a close brace '}'
> 
> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> ---

> diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
> index 2cf6464..cb96877 100644
> --- a/drivers/staging/greybus/connection.c
> +++ b/drivers/staging/greybus/connection.c
> @@ -12,17 +12,13 @@
>  #include "greybus.h"
>  #include "greybus_trace.h"
>  
> -
>  #define GB_CONNECTION_CPORT_QUIESCE_TIMEOUT	1000
>  
> -
>  static void gb_connection_kref_release(struct kref *kref);
>  
> -
>  static DEFINE_SPINLOCK(gb_connections_lock);
>  static DEFINE_MUTEX(gb_connection_mutex);
>  
> -

Here double newlines are used to separate and group defines, function
prototypes, and static variables, which is perfectly fine.

Johan