Re: [PATCH 10/14] soundwire: Add sysfs for SoundWire DisCo properties

[Vinod Koul <vinod.koul@intel.com>]

On Sat, Oct 21, 2017 at 10:42:53AM +0100, Mark Brown wrote:
> On Thu, Oct 19, 2017 at 08:33:26AM +0530, Vinod Koul wrote:
> 
> > +static ssize_t clock_frequencies_show(struct sdw_bus *bus,
> > +			struct sdw_prop_attribute *attr, char *buf)
> > +{
> > +	ssize_t size = 0;
> > +	int i;
> > +
> > +	for (i = 0; i < bus->prop.num_freq; i++)
> > +		size += sprintf(buf + size, "%8d\n", bus->prop.freq[i]);
> > +
> > +	return size;
> > +}
> 
> sysfs is supposed to be one value per file...

I though it needs to be human readable like:

$ cat /sys/bus/cpu/devices/cpu0/cpufreq/scaling_available_governors
performance powersave

In this case, if this is allowed it does help to have a single file with all
supported frequencies for a device

> 
> > +int sdw_sysfs_slave_init(struct sdw_slave *slave)
> > +{
> > +	/* TODO: Initialize dp0 and dpn kobject and attribute */
> > +	return 0;
> > +}
> > +
> > +void sdw_sysfs_slave_exit(struct sdw_slave *slave)
> > +{
> > +}
> 
> Seems like an important TODO?

Yes. For now I will remove the dummy code and add the patches for this after
this series is done.

Thanks
-- 
~Vinod