From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Richard Henderson
<richard.henderson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: John Arbuckle
<programmingkidx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
qemu-ppc-qX2TKyscuCcdnm+yROfE0A@public.gmane.org,
qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org
Subject: Re: [Qemu-devel] [libfdt][PATCH v2] implement strnlen for systems that need it
Date: Sun, 22 Oct 2017 16:33:15 +1100 [thread overview]
Message-ID: <20171022053315.GA15297@umbus> (raw)
In-Reply-To: <f9bd98f1-d45c-6d3a-c35c-c67da67c881f-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Fri, Oct 20, 2017 at 04:44:58PM -0700, Richard Henderson wrote:
> On 10/20/2017 10:55 AM, John Arbuckle wrote:
> > +static inline size_t strnlen(const char *string, size_t max_count)
> > +{
> > + size_t count;
> > + for (count = 0; count < max_count; count++) {
> > + if (string[count] == '\0') {
> > + break;
> > + }
> > + }
> > + return count;
>
> Not to nitpick, but
>
> const char *p = memchr(string, 0, max_count);
> return p ? max_count : p - string;
Richard's right, that's definitely a better implementation.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: John Arbuckle <programmingkidx@gmail.com>,
devicetree-compiler@vger.kernel.org, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [libfdt][PATCH v2] implement strnlen for systems that need it
Date: Sun, 22 Oct 2017 16:33:15 +1100 [thread overview]
Message-ID: <20171022053315.GA15297@umbus> (raw)
In-Reply-To: <f9bd98f1-d45c-6d3a-c35c-c67da67c881f@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Fri, Oct 20, 2017 at 04:44:58PM -0700, Richard Henderson wrote:
> On 10/20/2017 10:55 AM, John Arbuckle wrote:
> > +static inline size_t strnlen(const char *string, size_t max_count)
> > +{
> > + size_t count;
> > + for (count = 0; count < max_count; count++) {
> > + if (string[count] == '\0') {
> > + break;
> > + }
> > + }
> > + return count;
>
> Not to nitpick, but
>
> const char *p = memchr(string, 0, max_count);
> return p ? max_count : p - string;
Richard's right, that's definitely a better implementation.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-22 5:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 17:55 [libfdt][PATCH v2] implement strnlen for systems that need it John Arbuckle
2017-10-20 17:55 ` [Qemu-devel] " John Arbuckle
[not found] ` <20171020175548.2566-1-programmingkidx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-20 23:44 ` Richard Henderson
2017-10-20 23:44 ` Richard Henderson
[not found] ` <f9bd98f1-d45c-6d3a-c35c-c67da67c881f-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-10-22 5:33 ` David Gibson [this message]
2017-10-22 5:33 ` David Gibson
2017-10-22 14:41 ` Programmingkid
2017-10-22 14:41 ` Programmingkid
2017-10-22 15:05 ` John Reiser
[not found] ` <82BA0070-FFBB-4868-AE48-D7A3671621C5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-22 19:06 ` Ian Lepore
2017-10-22 19:06 ` Ian Lepore
[not found] ` <1508699172.7314.12.camel-h+KGxgPPiopAfugRpC6u6w@public.gmane.org>
2017-10-22 19:52 ` Programmingkid
2017-10-22 19:52 ` Programmingkid
2017-10-24 4:16 ` Programmingkid
2017-10-24 4:16 ` Programmingkid
[not found] ` <4CE427C5-BD1A-4911-9B10-CC1C0F80FD12-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-24 16:31 ` David Gibson
2017-10-24 16:31 ` David Gibson
2017-10-22 13:37 ` Peter Maydell
2017-10-22 13:37 ` Peter Maydell
[not found] ` <CAFEAcA8WnzZpdTWjJafLDjTCOpT_=azr6T+8UAnMNyDiD2ZxAQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-22 14:29 ` Programmingkid
2017-10-22 14:29 ` Programmingkid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171022053315.GA15297@umbus \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=programmingkidx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
--cc=qemu-ppc-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
--cc=richard.henderson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.