All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Christoffer Dall <christoffer.dall@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v3 3/9] arm64: KVM: Add invalidate_icache_range helper
Date: Mon, 23 Oct 2017 17:19:14 +0100	[thread overview]
Message-ID: <20171023161914.GA6222@arm.com> (raw)
In-Reply-To: <20171023161122.15291-4-marc.zyngier@arm.com>

On Mon, Oct 23, 2017 at 05:11:16PM +0100, Marc Zyngier wrote:
> We currently tightly couple dcache clean with icache invalidation,
> but KVM could do without the initial flush to PoU, as we've
> already flushed things to PoC.
> 
> Let's introduce invalidate_icache_range which is limited to
> invalidating the icache from the linear mapping (and thus
> has none of the userspace fault handling complexity), and
> wire it in KVM instead of flush_icache_range.
> 
> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
>  arch/arm64/include/asm/assembler.h  | 21 +++++++++++++++++++++
>  arch/arm64/include/asm/cacheflush.h |  7 +++++++
>  arch/arm64/include/asm/kvm_mmu.h    |  4 ++--
>  arch/arm64/mm/cache.S               | 32 ++++++++++++++++++++++----------
>  4 files changed, 52 insertions(+), 12 deletions(-)

Acked-by: Will Deacon <will.deacon@arm.com>

Thanks for respinning this.

Will

WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/9] arm64: KVM: Add invalidate_icache_range helper
Date: Mon, 23 Oct 2017 17:19:14 +0100	[thread overview]
Message-ID: <20171023161914.GA6222@arm.com> (raw)
In-Reply-To: <20171023161122.15291-4-marc.zyngier@arm.com>

On Mon, Oct 23, 2017 at 05:11:16PM +0100, Marc Zyngier wrote:
> We currently tightly couple dcache clean with icache invalidation,
> but KVM could do without the initial flush to PoU, as we've
> already flushed things to PoC.
> 
> Let's introduce invalidate_icache_range which is limited to
> invalidating the icache from the linear mapping (and thus
> has none of the userspace fault handling complexity), and
> wire it in KVM instead of flush_icache_range.
> 
> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
>  arch/arm64/include/asm/assembler.h  | 21 +++++++++++++++++++++
>  arch/arm64/include/asm/cacheflush.h |  7 +++++++
>  arch/arm64/include/asm/kvm_mmu.h    |  4 ++--
>  arch/arm64/mm/cache.S               | 32 ++++++++++++++++++++++----------
>  4 files changed, 52 insertions(+), 12 deletions(-)

Acked-by: Will Deacon <will.deacon@arm.com>

Thanks for respinning this.

Will

  reply	other threads:[~2017-10-23 16:19 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 16:11 [PATCH v3 0/9] arm/arm64: KVM: limit icache invalidation to prefetch aborts Marc Zyngier
2017-10-23 16:11 ` Marc Zyngier
2017-10-23 16:11 ` [PATCH v3 1/9] KVM: arm/arm64: Detangle kvm_mmu.h from kvm_hyp.h Marc Zyngier
2017-10-23 16:11   ` Marc Zyngier
2017-10-23 16:11 ` [PATCH v3 2/9] KVM: arm/arm64: Split dcache/icache flushing Marc Zyngier
2017-10-23 16:11   ` Marc Zyngier
2017-10-23 16:11 ` [PATCH v3 3/9] arm64: KVM: Add invalidate_icache_range helper Marc Zyngier
2017-10-23 16:11   ` Marc Zyngier
2017-10-23 16:19   ` Will Deacon [this message]
2017-10-23 16:19     ` Will Deacon
2017-10-23 16:11 ` [PATCH v3 4/9] arm: KVM: Add optimized PIPT icache flushing Marc Zyngier
2017-10-23 16:11   ` Marc Zyngier
2017-10-23 16:11 ` [PATCH v3 5/9] arm64: KVM: PTE/PMD S2 XN bit definition Marc Zyngier
2017-10-23 16:11   ` Marc Zyngier
2017-10-23 16:11 ` [PATCH v3 6/9] KVM: arm/arm64: Limit icache invalidation to prefetch aborts Marc Zyngier
2017-10-23 16:11   ` Marc Zyngier
2017-11-01 10:17   ` Andrew Jones
2017-11-01 10:17     ` Andrew Jones
2017-11-02 10:36     ` Marc Zyngier
2017-11-02 10:36       ` Marc Zyngier
2017-11-02 13:13       ` Andrew Jones
2017-11-02 13:13         ` Andrew Jones
2017-10-23 16:11 ` [PATCH v3 7/9] KVM: arm/arm64: Only clean the dcache on translation fault Marc Zyngier
2017-10-23 16:11   ` Marc Zyngier
2018-08-21 13:35   ` Alexander Graf
2018-08-21 13:35     ` Alexander Graf
2018-08-21 13:42     ` Alexander Graf
2018-08-21 13:42       ` Alexander Graf
2018-08-21 13:57     ` Marc Zyngier
2018-08-21 13:57       ` Marc Zyngier
2018-08-21 14:08       ` Alexander Graf
2018-08-21 14:08         ` Alexander Graf
2018-08-21 15:08         ` Marc Zyngier
2018-08-21 15:08           ` Marc Zyngier
2018-08-21 16:54           ` Alexander Graf
2018-08-21 16:54             ` Alexander Graf
2018-08-23 11:16             ` Marc Zyngier
2018-08-23 11:16               ` Marc Zyngier
2018-08-23 12:24               ` Alexander Graf
2018-08-23 12:24                 ` Alexander Graf
2018-08-23 12:43                 ` Marc Zyngier
2018-08-23 12:43                   ` Marc Zyngier
2018-09-01 10:03                   ` Alexander Graf
2018-09-01 10:03                     ` Alexander Graf
2018-08-21 16:45         ` Alexander Graf
2018-08-21 16:45           ` Alexander Graf
2017-10-23 16:11 ` [PATCH v3 8/9] KVM: arm/arm64: Preserve Exec permission across R/W permission faults Marc Zyngier
2017-10-23 16:11   ` Marc Zyngier
2017-10-23 16:11 ` [PATCH v3 9/9] KVM: arm/arm64: Drop vcpu parameter from guest cache maintenance operartions Marc Zyngier
2017-10-23 16:11   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171023161914.GA6222@arm.com \
    --to=will.deacon@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.