From: "Bruno E. O. Meneguele" <brdeoliv@redhat.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org, serge@hallyn.com,
james.l.morris@oracle.com, dmitry.kasatkin@gmail.com,
rusty@rustcorp.com.au, jeyu@kernel.org
Subject: Re: [PATCH 1/2] module: export module signature enforcement status
Date: Mon, 23 Oct 2017 14:24:36 -0200 [thread overview]
Message-ID: <20171023162436.GB2454@glitch> (raw)
In-Reply-To: <1508763415.3639.91.camel@linux.vnet.ibm.com>
[-- Attachment #1: Type: multipart/signed, Size: 2565 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Bruno E. O. Meneguele" <brdeoliv@redhat.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org, serge@hallyn.com,
james.l.morris@oracle.com, dmitry.kasatkin@gmail.com,
rusty@rustcorp.com.au, jeyu@kernel.org
Subject: Re: [PATCH 1/2] module: export module signature enforcement status
Date: Mon, 23 Oct 2017 14:24:36 -0200 [thread overview]
Message-ID: <20171023162436.GB2454@glitch> (raw)
In-Reply-To: <1508763415.3639.91.camel@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 2526 bytes --]
On 23-10, Mimi Zohar wrote:
> On Fri, 2017-10-20 at 17:19 -0200, Bruno E. O. Meneguele wrote:
> > A static variable sig_enforce is used as status var to indicate the real
> > value of CONFIG_MODULE_SIG_FORCE, once this one is set the var will hold
> > true, but if the CONFIG is not set the status var will hold whatever
> > value is present in the module.sig_enforce kernel cmdline param: true
> > when =1 and false when =0 or not present.
> >
> > Considering this cmdline param take place over the CONFIG value when
> > it's not set, other places in the kernel could missbehave since they
>
> ^misbehave
>
right.
> > would have only the CONFIG_MODULE_SIG_FORCE value to rely on. Exporting
> > this status var allows the kernel to rely in the effective value of
> > module signature enforcement, being it from CONFIG value or cmdline
> > param.
>
> Thanks! There's a minor checkpatch warning below.
>
> > Signed-off-by: Bruno E. O. Meneguele <brdeoliv@redhat.com>
> > ---
> > include/linux/module.h | 2 ++
> > kernel/module.c | 8 ++++++++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/include/linux/module.h b/include/linux/module.h
> > index fe5aa3736707..ddfe17e3a85c 100644
> > --- a/include/linux/module.h
> > +++ b/include/linux/module.h
> > @@ -806,4 +806,6 @@ static inline bool module_sig_ok(struct module *module)
> > }
> > #endif /* CONFIG_MODULE_SIG */
> >
> > +bool is_module_sig_enforced(void);
> > +
> > #endif /* _LINUX_MODULE_H */
> > diff --git a/kernel/module.c b/kernel/module.c
> > index de66ec825992..b93c7ff44066 100644
> > --- a/kernel/module.c
> > +++ b/kernel/module.c
> > @@ -278,6 +278,14 @@ static bool sig_enforce = IS_ENABLED(CONFIG_MODULE_SIG_FORCE);
> > module_param(sig_enforce, bool_enable_only, 0644);
> > #endif /* !CONFIG_MODULE_SIG_FORCE */
> >
> > +/* Export sig_enforce kernel cmdline parameter to allow other subsystems rely
> > + * on that instead of directly to CONFIG_MODULE_SIG_FORCE config. */
>
> Checkpatch complains. Please use the normal format:
> /*
> *
> */
>
Oh, sure, sorry for that! I'll resend a v2 of the patchset in a minute.
Thanks.
> > +bool is_module_sig_enforced(void)
> > +{
> > + return sig_enforce;
> > +}
> > +EXPORT_SYMBOL(is_module_sig_enforced);
> > +
> > /* Block module loading/unloading? */
> > int modules_disabled = 0;
> > core_param(nomodule, modules_disabled, bint, 0);
>
--
bmeneg
PGP Key: http://bmeneg.com/pubkey.txt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-10-23 16:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 19:19 [PATCH 0/2] ima: change how MODULE_SIG_FORCE is checked on modules checking policy Bruno E. O. Meneguele
2017-10-20 19:19 ` Bruno E. O. Meneguele
2017-10-20 19:19 ` [PATCH 1/2] module: export module signature enforcement status Bruno E. O. Meneguele
2017-10-20 19:19 ` Bruno E. O. Meneguele
2017-10-23 12:56 ` Mimi Zohar
2017-10-23 12:56 ` Mimi Zohar
2017-10-23 12:56 ` Mimi Zohar
2017-10-23 16:24 ` Bruno E. O. Meneguele [this message]
2017-10-23 16:24 ` Bruno E. O. Meneguele
2017-10-20 19:19 ` [PATCH 2/2] ima: check signature enforcement against cmdline param instead of CONFIG Bruno E. O. Meneguele
2017-10-20 19:19 ` Bruno E. O. Meneguele
2017-10-23 12:57 ` Mimi Zohar
2017-10-23 12:57 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023162436.GB2454@glitch \
--to=brdeoliv@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=james.l.morris@oracle.com \
--cc=jeyu@kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=serge@hallyn.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.