From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Rex Zhu" <Rex.Zhu@amd.com>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Huang Rui" <ray.huang@amd.com>,
amd-gfx@lists.freedesktop.org,
"Eric Huang" <JinHuiEric.Huang@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/powerplay: fix amd_powerplay_reset()
Date: Tue, 24 Oct 2017 13:31:58 +0300 [thread overview]
Message-ID: <20171024103158.2kbtldetdoudtvfo@mwanda> (raw)
In-Reply-To: <87k1zkj1ok.fsf@intel.com>
On Tue, Oct 24, 2017 at 01:11:07PM +0300, Jani Nikula wrote:
> On Tue, 24 Oct 2017, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > We accidentally inverted an if statement and turned amd_powerplay_reset()
> > into a no-op.
> >
> > Fixes: ae97988fc89e ("drm/amd/powerplay: tidy up ret checks in amd_powerplay.c (v3)")
>
> For some reason I looked up that commit, and it has *two* cases where
> "ret != 0" gets changed to "!ret".
>
The other bug was secretly fixed in commit 3811f8f00c5f ("drm/amd/powerplay:
move set_clockgating_by_smu to pp func table").
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Rex Zhu" <Rex.Zhu@amd.com>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Huang Rui" <ray.huang@amd.com>,
amd-gfx@lists.freedesktop.org,
"Eric Huang" <JinHuiEric.Huang@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/powerplay: fix amd_powerplay_reset()
Date: Tue, 24 Oct 2017 10:31:58 +0000 [thread overview]
Message-ID: <20171024103158.2kbtldetdoudtvfo@mwanda> (raw)
In-Reply-To: <87k1zkj1ok.fsf@intel.com>
On Tue, Oct 24, 2017 at 01:11:07PM +0300, Jani Nikula wrote:
> On Tue, 24 Oct 2017, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > We accidentally inverted an if statement and turned amd_powerplay_reset()
> > into a no-op.
> >
> > Fixes: ae97988fc89e ("drm/amd/powerplay: tidy up ret checks in amd_powerplay.c (v3)")
>
> For some reason I looked up that commit, and it has *two* cases where
> "ret != 0" gets changed to "!ret".
>
The other bug was secretly fixed in commit 3811f8f00c5f ("drm/amd/powerplay:
move set_clockgating_by_smu to pp func table").
regards,
dan carpenter
next prev parent reply other threads:[~2017-10-24 10:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 9:44 [PATCH] drm/amd/powerplay: fix amd_powerplay_reset() Dan Carpenter
2017-10-24 9:44 ` Dan Carpenter
2017-10-24 10:11 ` Jani Nikula
2017-10-24 10:11 ` Jani Nikula
2017-10-24 10:31 ` Dan Carpenter [this message]
2017-10-24 10:31 ` Dan Carpenter
2017-10-25 22:28 ` Alex Deucher
2017-10-25 22:28 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024103158.2kbtldetdoudtvfo@mwanda \
--to=dan.carpenter@oracle.com \
--cc=JinHuiEric.Huang@amd.com \
--cc=Rex.Zhu@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=ray.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.