From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-integrity@vger.kernel.org,
"Jason Gunthorpe" <jgunthorpe@obsidianresearch.com>,
"Peter Hüwe" <PeterHuewe@gmx.de>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] tpm_tis_core: Use common error handling code in tpm_tis_send_data()
Date: Tue, 24 Oct 2017 13:55:11 +0000 [thread overview]
Message-ID: <20171024135511.773njwnmodnewtwo@linux.intel.com> (raw)
In-Reply-To: <455e93f6-c419-8318-6129-80e99fc8552f@users.sourceforge.net>
On Mon, Oct 23, 2017 at 03:51:09PM +0200, SF Markus Elfring wrote:
> >> @@ -315,6 +311,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const u8 *buf, size_t len)
> >>
> >> return 0;
> >>
> >> +report_timeout:
> >> + rc = -ETIME;
> >> out_err:
> >> tpm_tis_ready(chip);
> >> return rc;
> >> --
> >> 2.14.2
> >>
> >
> > NAK. wait_for_tpm_stat() should give that error code.
>
> This is a pity that you reject another bit of code reduction.
>
> Regards,
> Markus
It is a pity that you continue doing this constant patch trolling.
That is what it is.
/Jarkko.
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-integrity@vger.kernel.org,
"Jason Gunthorpe" <jgunthorpe@obsidianresearch.com>,
"Peter Hüwe" <PeterHuewe@gmx.de>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] tpm_tis_core: Use common error handling code in tpm_tis_send_data()
Date: Tue, 24 Oct 2017 15:55:11 +0200 [thread overview]
Message-ID: <20171024135511.773njwnmodnewtwo@linux.intel.com> (raw)
In-Reply-To: <455e93f6-c419-8318-6129-80e99fc8552f@users.sourceforge.net>
On Mon, Oct 23, 2017 at 03:51:09PM +0200, SF Markus Elfring wrote:
> >> @@ -315,6 +311,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const u8 *buf, size_t len)
> >>
> >> return 0;
> >>
> >> +report_timeout:
> >> + rc = -ETIME;
> >> out_err:
> >> tpm_tis_ready(chip);
> >> return rc;
> >> --
> >> 2.14.2
> >>
> >
> > NAK. wait_for_tpm_stat() should give that error code.
>
> This is a pity that you reject another bit of code reduction.
>
> Regards,
> Markus
It is a pity that you continue doing this constant patch trolling.
That is what it is.
/Jarkko.
next prev parent reply other threads:[~2017-10-24 13:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-22 10:16 [PATCH] tpm_tis_core: Use common error handling code in tpm_tis_send_data() SF Markus Elfring
2017-10-22 10:16 ` SF Markus Elfring
2017-10-23 7:34 ` Dan Carpenter
2017-10-23 7:34 ` Dan Carpenter
2017-10-23 13:42 ` Jarkko Sakkinen
2017-10-23 13:42 ` Jarkko Sakkinen
2017-10-23 13:51 ` SF Markus Elfring
2017-10-23 13:51 ` SF Markus Elfring
2017-10-24 13:55 ` Jarkko Sakkinen [this message]
2017-10-24 13:55 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024135511.773njwnmodnewtwo@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=PeterHuewe@gmx.de \
--cc=elfring@users.sourceforge.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.