From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-integrity@vger.kernel.org,
"Jason Gunthorpe" <jgunthorpe@obsidianresearch.com>,
"Peter Hüwe" <PeterHuewe@gmx.de>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] xen-tpmfront: Use common error handling code in vtpm_send()
Date: Tue, 24 Oct 2017 13:56:22 +0000 [thread overview]
Message-ID: <20171024135622.uswu3apuj23njbna@linux.intel.com> (raw)
In-Reply-To: <f68ee5b6-2da1-e3c8-4d0d-f13a0563385e@users.sourceforge.net>
On Mon, Oct 23, 2017 at 03:57:30PM +0200, SF Markus Elfring wrote:
> >> @@ -108,11 +106,14 @@ static int vtpm_send(struct tpm_chip *chip, u8 *buf, size_t count)
> >> if (wait_for_tpm_stat(chip, VTPM_STATUS_IDLE, duration,
> >> &priv->read_queue, true) < 0) {
> >> /* got a signal or timeout, try to cancel */
> >> - vtpm_cancel(chip);
> >> - return -ETIME;
> >> + goto cancel_vtpm;
> >> }
> >>
> >> return count;
> >> +
> >> +cancel_vtpm:
> >> + vtpm_cancel(chip);
> >> + return -ETIME;
> >> }
> >>
> >> static int vtpm_recv(struct tpm_chip *chip, u8 *buf, size_t count)
> >> --
> >> 2.14.2
> >>
> >
> > NAK
>
> Do you need any more facts to show the influence of the proposed small code reduction?
>
> Regards,
> Markus
Already explained when I reviewed another patch dealing with
-ETIME.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-integrity@vger.kernel.org,
"Jason Gunthorpe" <jgunthorpe@obsidianresearch.com>,
"Peter Hüwe" <PeterHuewe@gmx.de>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] xen-tpmfront: Use common error handling code in vtpm_send()
Date: Tue, 24 Oct 2017 15:56:22 +0200 [thread overview]
Message-ID: <20171024135622.uswu3apuj23njbna@linux.intel.com> (raw)
In-Reply-To: <f68ee5b6-2da1-e3c8-4d0d-f13a0563385e@users.sourceforge.net>
On Mon, Oct 23, 2017 at 03:57:30PM +0200, SF Markus Elfring wrote:
> >> @@ -108,11 +106,14 @@ static int vtpm_send(struct tpm_chip *chip, u8 *buf, size_t count)
> >> if (wait_for_tpm_stat(chip, VTPM_STATUS_IDLE, duration,
> >> &priv->read_queue, true) < 0) {
> >> /* got a signal or timeout, try to cancel */
> >> - vtpm_cancel(chip);
> >> - return -ETIME;
> >> + goto cancel_vtpm;
> >> }
> >>
> >> return count;
> >> +
> >> +cancel_vtpm:
> >> + vtpm_cancel(chip);
> >> + return -ETIME;
> >> }
> >>
> >> static int vtpm_recv(struct tpm_chip *chip, u8 *buf, size_t count)
> >> --
> >> 2.14.2
> >>
> >
> > NAK
>
> Do you need any more facts to show the influence of the proposed small code reduction?
>
> Regards,
> Markus
Already explained when I reviewed another patch dealing with
-ETIME.
/Jarkko
next prev parent reply other threads:[~2017-10-24 13:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-22 11:28 [PATCH 0/2] Xen vTPM frontend: Fine-tuning for vtpm_send() SF Markus Elfring
2017-10-22 11:28 ` SF Markus Elfring
2017-10-22 11:29 ` [PATCH 1/2] xen-tpmfront: Use common error handling code in vtpm_send() SF Markus Elfring
2017-10-22 11:29 ` SF Markus Elfring
2017-10-23 13:42 ` Jarkko Sakkinen
2017-10-23 13:42 ` Jarkko Sakkinen
2017-10-23 13:57 ` SF Markus Elfring
2017-10-23 13:57 ` SF Markus Elfring
2017-10-24 13:56 ` Jarkko Sakkinen [this message]
2017-10-24 13:56 ` Jarkko Sakkinen
2017-10-22 11:30 ` [PATCH 2/2] xen-tpmfront: Combine two condition checks into one statement " SF Markus Elfring
2017-10-22 11:30 ` SF Markus Elfring
2017-10-23 7:31 ` Dan Carpenter
2017-10-23 7:31 ` Dan Carpenter
2017-10-23 13:44 ` Jarkko Sakkinen
2017-10-23 13:44 ` Jarkko Sakkinen
2017-10-24 13:52 ` Jarkko Sakkinen
2017-10-24 13:52 ` Jarkko Sakkinen
2017-10-23 13:42 ` [PATCH 0/2] Xen vTPM frontend: Fine-tuning for vtpm_send() Jarkko Sakkinen
2017-10-23 13:42 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024135622.uswu3apuj23njbna@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=PeterHuewe@gmx.de \
--cc=elfring@users.sourceforge.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.