From: "Tobin C. Harding" <me@tobin.cc>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: kernel-hardening@lists.openwall.com,
Theodore Ts'o <tytso@mit.edu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Tycho Andersen <tycho@docker.com>,
"Roberts, William C" <william.c.roberts@intel.com>,
Tejun Heo <tj@kernel.org>,
Jordan Glover <Golden_Miller83@protonmail.ch>,
Greg KH <gregkh@linuxfoundation.org>,
Petr Mladek <pmladek@suse.com>, Joe Perches <joe@perches.com>,
Ian Campbell <ijc@hellion.org.uk>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <wilal.deacon@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Chris Fries <cfries@google.com>,
Dave Weinstein <olorin@google.com>,
Daniel Micay <danielmicay@gmail.com>,
Djalal Harouni <tixxdz@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [kernel-hardening] Re: [PATCH v7] printk: hash addresses printed with %p
Date: Wed, 25 Oct 2017 07:45:52 +1100 [thread overview]
Message-ID: <20171024204552.GI1429@eros> (raw)
In-Reply-To: <CAHmME9ry-=Ve29eRfdMHLa0PgPqGtB=P2YuctgnVSoQN+DvN8w@mail.gmail.com>
On Tue, Oct 24, 2017 at 01:25:52PM +0200, Jason A. Donenfeld wrote:
> On Tue, Oct 24, 2017 at 2:31 AM, Tobin C. Harding <me@tobin.cc> wrote:
> > On Tue, Oct 24, 2017 at 01:00:03AM +0200, Jason A. Donenfeld wrote:
> >> Provided you've tested this and the static_key guard stuff actually
> >> works as intended,
> >
> > I tested by inserting a simple module that calls printf() with a bunch of
> > different specifiers. So it's tested but not stress tested. Some stress testing
> > might be nice, no ideas how to go about that though.
>
> By the way, it occurred to me one thing you might want to verify
> closely is whether or not that callback block executes from process
> context and whether or not the static_key stuff sleeps. If both,
> there's a problem.
Ok, will do.
thanks,
Tobin.
WARNING: multiple messages have this Message-ID (diff)
From: "Tobin C. Harding" <me@tobin.cc>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: kernel-hardening@lists.openwall.com,
"Theodore Ts'o" <tytso@mit.edu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Tycho Andersen <tycho@docker.com>,
"Roberts, William C" <william.c.roberts@intel.com>,
Tejun Heo <tj@kernel.org>,
Jordan Glover <Golden_Miller83@protonmail.ch>,
Greg KH <gregkh@linuxfoundation.org>,
Petr Mladek <pmladek@suse.com>, Joe Perches <joe@perches.com>,
Ian Campbell <ijc@hellion.org.uk>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <wilal.deacon@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Chris Fries <cfries@google.com>,
Dave Weinstein <olorin@google.com>,
Daniel Micay <danielmicay@gmail.com>,
Djalal Harouni <tixxdz@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7] printk: hash addresses printed with %p
Date: Wed, 25 Oct 2017 07:45:52 +1100 [thread overview]
Message-ID: <20171024204552.GI1429@eros> (raw)
In-Reply-To: <CAHmME9ry-=Ve29eRfdMHLa0PgPqGtB=P2YuctgnVSoQN+DvN8w@mail.gmail.com>
On Tue, Oct 24, 2017 at 01:25:52PM +0200, Jason A. Donenfeld wrote:
> On Tue, Oct 24, 2017 at 2:31 AM, Tobin C. Harding <me@tobin.cc> wrote:
> > On Tue, Oct 24, 2017 at 01:00:03AM +0200, Jason A. Donenfeld wrote:
> >> Provided you've tested this and the static_key guard stuff actually
> >> works as intended,
> >
> > I tested by inserting a simple module that calls printf() with a bunch of
> > different specifiers. So it's tested but not stress tested. Some stress testing
> > might be nice, no ideas how to go about that though.
>
> By the way, it occurred to me one thing you might want to verify
> closely is whether or not that callback block executes from process
> context and whether or not the static_key stuff sleeps. If both,
> there's a problem.
Ok, will do.
thanks,
Tobin.
next prev parent reply other threads:[~2017-10-24 20:45 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 22:33 [kernel-hardening] [PATCH v7] printk: hash addresses printed with %p Tobin C. Harding
2017-10-23 22:33 ` Tobin C. Harding
2017-10-23 23:00 ` [kernel-hardening] " Jason A. Donenfeld
2017-10-23 23:00 ` Jason A. Donenfeld
2017-10-24 0:31 ` [kernel-hardening] " Tobin C. Harding
2017-10-24 0:31 ` Tobin C. Harding
2017-10-24 11:25 ` [kernel-hardening] " Jason A. Donenfeld
2017-10-24 11:25 ` Jason A. Donenfeld
2017-10-24 20:45 ` Tobin C. Harding [this message]
2017-10-24 20:45 ` Tobin C. Harding
2017-10-25 3:49 ` [kernel-hardening] " Tobin C. Harding
2017-10-25 3:49 ` Tobin C. Harding
2017-10-30 20:22 ` [kernel-hardening] " Steven Rostedt
2017-10-30 20:22 ` Steven Rostedt
2017-10-30 21:24 ` [kernel-hardening] " Tobin C. Harding
2017-10-30 21:24 ` Tobin C. Harding
2017-10-31 14:22 ` [kernel-hardening] " Jason A. Donenfeld
2017-10-31 14:22 ` Jason A. Donenfeld
2017-10-24 19:25 ` [kernel-hardening] " Rasmus Villemoes
2017-10-24 21:52 ` Tobin C. Harding
2017-10-24 23:57 ` Tobin C. Harding
2017-10-25 19:02 ` Rasmus Villemoes
2017-10-25 19:02 ` Rasmus Villemoes
2017-10-25 22:14 ` [kernel-hardening] " Tobin C. Harding
2017-10-25 22:14 ` Tobin C. Harding
2017-10-25 16:22 ` [kernel-hardening] [lkp-robot] [printk] 7f7c60e066: BUG:KASAN:slab-out-of-bounds kernel test robot
2017-10-25 16:22 ` kernel test robot
2017-10-25 16:22 ` kernel test robot
2017-10-31 0:14 ` [kernel-hardening] " Kees Cook
2017-10-31 0:14 ` Kees Cook
2017-10-31 0:14 ` Kees Cook
2017-10-30 9:57 ` [kernel-hardening] " Ye Xiaolong
2017-10-30 9:57 ` Ye Xiaolong
2017-10-30 9:57 ` Ye Xiaolong
2017-10-31 2:39 ` [kernel-hardening] " Tobin C. Harding
2017-10-31 2:39 ` Tobin C. Harding
2017-10-31 2:47 ` [kernel-hardening] " Kees Cook
2017-10-31 2:47 ` Kees Cook
2017-10-31 2:47 ` Kees Cook
-- strict thread matches above, loose matches on Subject: below --
2017-10-25 4:00 [kernel-hardening] Re: [PATCH v7] printk: hash addresses printed with %p Jason A. Donenfeld
2017-10-25 10:05 ` Tobin C. Harding
2017-10-25 22:27 ` Tobin C. Harding
2017-10-25 22:59 ` Jason A. Donenfeld
2017-10-25 23:11 ` Tobin C. Harding
2017-10-26 7:00 ` Greg KH
2017-10-26 9:10 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024204552.GI1429@eros \
--to=me@tobin.cc \
--cc=Golden_Miller83@protonmail.ch \
--cc=Jason@zx2c4.com \
--cc=catalin.marinas@arm.com \
--cc=cfries@google.com \
--cc=danielmicay@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ijc@hellion.org.uk \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olorin@google.com \
--cc=pbonzini@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tixxdz@gmail.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tycho@docker.com \
--cc=tytso@mit.edu \
--cc=wilal.deacon@arm.com \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.