From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] phy: add combo phy driver for HiSilicon STB SoCs
Date: Thu, 26 Oct 2017 22:31:14 +0800 [thread overview]
Message-ID: <20171026143112.GA13744@dragon> (raw)
In-Reply-To: <1508921049-16208-3-git-send-email-shawnguo@kernel.org>
On Wed, Oct 25, 2017 at 04:44:09PM +0800, Shawn Guo wrote:
> +static int histb_combphy_init(struct phy *phy)
> +{
> + struct histb_combphy_priv *priv = phy_get_drvdata(phy);
> + u32 val;
> + int ret;
> +
> + /* PHY0 doesn't support mode setting */
> + if (priv->phy_id != 0) {
With a bit more think on this, I admit it might not scale for future
SoCs which could reasonably support mode select for combphy0. So
instead of hard checking device id, I will repost with a new property
added for this.
Shawn
> + ret = histb_combphy_set_mode(priv);
> + if (ret)
> + return ret;
> + }
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jiancheng Xue
<xuejiancheng-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jianguo Sun <sunjianguo1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 2/2] phy: add combo phy driver for HiSilicon STB SoCs
Date: Thu, 26 Oct 2017 22:31:14 +0800 [thread overview]
Message-ID: <20171026143112.GA13744@dragon> (raw)
In-Reply-To: <1508921049-16208-3-git-send-email-shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Wed, Oct 25, 2017 at 04:44:09PM +0800, Shawn Guo wrote:
> +static int histb_combphy_init(struct phy *phy)
> +{
> + struct histb_combphy_priv *priv = phy_get_drvdata(phy);
> + u32 val;
> + int ret;
> +
> + /* PHY0 doesn't support mode setting */
> + if (priv->phy_id != 0) {
With a bit more think on this, I admit it might not scale for future
SoCs which could reasonably support mode select for combphy0. So
instead of hard checking device id, I will repost with a new property
added for this.
Shawn
> + ret = histb_combphy_set_mode(priv);
> + if (ret)
> + return ret;
> + }
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-26 14:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 8:44 [PATCH v3 0/2] Add Combo PHY driver for HiSilicon STB SoCs Shawn Guo
2017-10-25 8:44 ` Shawn Guo
2017-10-25 8:44 ` [PATCH v3 1/2] dt-bindings: add bindings doc for hi3798cv200 combphy Shawn Guo
2017-10-25 8:44 ` Shawn Guo
2017-10-25 8:44 ` [PATCH v3 2/2] phy: add combo phy driver for HiSilicon STB SoCs Shawn Guo
2017-10-25 8:44 ` Shawn Guo
2017-10-26 14:31 ` Shawn Guo [this message]
2017-10-26 14:31 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026143112.GA13744@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.