From: Jonathan Cameron <jic23@kernel.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-iio@vger.kernel.org,
Crestez Dan Leonard <leonard.crestez@intel.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: iio/pressure/hp206c: Use common error handling code in hp206c_conv_and_read()
Date: Thu, 26 Oct 2017 16:44:23 +0000 [thread overview]
Message-ID: <20171026174423.210579a6@archlinux> (raw)
In-Reply-To: <93642327-2a41-95ca-dd15-3d040fafe845@users.sourceforge.net>
On Thu, 26 Oct 2017 18:38:14 +0200
SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> > The advantages of this are very limited.
>
> Would anybody like to check corresponding effects in more detail?
No readabilty is reduced. It is a very rare patch that is accepted
where that is the case and the reasons have to be extremely clear
and justified.
>
>
> > Hence I am not going to apply it.
>
> This is a pity that you like such a kind of source code adjustment
> not so much so far.
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-iio@vger.kernel.org,
Crestez Dan Leonard <leonard.crestez@intel.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: iio/pressure/hp206c: Use common error handling code in hp206c_conv_and_read()
Date: Thu, 26 Oct 2017 17:44:23 +0100 [thread overview]
Message-ID: <20171026174423.210579a6@archlinux> (raw)
In-Reply-To: <93642327-2a41-95ca-dd15-3d040fafe845@users.sourceforge.net>
On Thu, 26 Oct 2017 18:38:14 +0200
SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> > The advantages of this are very limited.
>
> Would anybody like to check corresponding effects in more detail?
No readabilty is reduced. It is a very rare patch that is accepted
where that is the case and the reasons have to be extremely clear
and justified.
>
>
> > Hence I am not going to apply it.
>
> This is a pity that you like such a kind of source code adjustment
> not so much so far.
>
next prev parent reply other threads:[~2017-10-26 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 13:45 [PATCH] iio/pressure/hp206c: Use common error handling code in hp206c_conv_and_read() SF Markus Elfring
2017-10-26 13:45 ` SF Markus Elfring
2017-10-26 16:23 ` Jonathan Cameron
2017-10-26 16:23 ` Jonathan Cameron
2017-10-26 16:38 ` SF Markus Elfring
2017-10-26 16:38 ` SF Markus Elfring
2017-10-26 16:44 ` Jonathan Cameron [this message]
2017-10-26 16:44 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026174423.210579a6@archlinux \
--to=jic23@kernel.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=leonard.crestez@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.