All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Li Bin <huawei.libin@huawei.com>,
	LKML <linux-kernel@vger.kernel.org>,
	tanxiaofei@huawei.com, guohanjun@huawei.com
Subject: Re: [PATCH] workqueue: Fix NULL pointer dereference
Date: Thu, 26 Oct 2017 10:55:58 -0700	[thread overview]
Message-ID: <20171026175558.GF59538@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <CAJhGHyBT0xF8Exn21Mb37e_e1f+DqvuZC94qY8SY=ScsvPHG+w@mail.gmail.com>

Hello,

On Thu, Oct 26, 2017 at 11:55:00PM +0800, Lai Jiangshan wrote:
> I remember that softirq can be invoked when irq_eixt(),
> and in this case the current->current_pwq is also NULL
> if __queue_work() is called in the soft irq.
> 
> So in_task() might be better than !in_irq() for the fix?

Reverted the patch for now.  Li, what do you think?

Thanks.

-- 
tejun

  reply	other threads:[~2017-10-26 17:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24  1:18 [PATCH] workqueue: Fix NULL pointer dereference Li Bin
2017-10-24 14:45 ` Tejun Heo
2017-10-26 15:55 ` Lai Jiangshan
2017-10-26 17:55   ` Tejun Heo [this message]
2017-10-27  5:24   ` Li Bin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171026175558.GF59538@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=guohanjun@huawei.com \
    --cc=huawei.libin@huawei.com \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tanxiaofei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.