From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Jose Abreu <Jose.Abreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Cc: Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Joao Pinto <Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
Giuseppe Cavallaro <peppe.cavallaro-qxv4g6HH51o@public.gmane.org>,
Alexandre Torgue <alexandre.torgue-qxv4g6HH51o@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters
Date: Thu, 26 Oct 2017 23:56:29 +0200 [thread overview]
Message-ID: <20171026215629.GB8489@lunn.ch> (raw)
In-Reply-To: <867d6d43-9df7-4097-db5a-f2049236394f-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
> About my patches, what I think would be better now would be to
> drop the configuration by DT and integrate the remaining
> configuration, letting the EST parameters be populated by SoC
> specific wrappers.
Hi Jose
The problem with SoC specific wrappers is that you are going to have
to remove them once the real interface is defined. Anybody who uses
your SoC specific wrappers is going to have to re-write their code,
when it all gets ripped out.
You generally don't add device SoC specific wrappers. Imagine if
everybody did that. Lots of different ways of doing the same thing.
My suggesting is to keep your patches out for the moment, waiting for
generic support to be added.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters
Date: Thu, 26 Oct 2017 23:56:29 +0200 [thread overview]
Message-ID: <20171026215629.GB8489@lunn.ch> (raw)
In-Reply-To: <867d6d43-9df7-4097-db5a-f2049236394f@synopsys.com>
> About my patches, what I think would be better now would be to
> drop the configuration by DT and integrate the remaining
> configuration, letting the EST parameters be populated by SoC
> specific wrappers.
Hi Jose
The problem with SoC specific wrappers is that you are going to have
to remove them once the real interface is defined. Anybody who uses
your SoC specific wrappers is going to have to re-write their code,
when it all gets ripped out.
You generally don't add device SoC specific wrappers. Imagine if
everybody did that. Lots of different ways of doing the same thing.
My suggesting is to keep your patches out for the moment, waiting for
generic support to be added.
Andrew
next prev parent reply other threads:[~2017-10-26 21:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 14:02 [PATCH net-next 0/2] net: stmmac: Support DWMAC5 and TSN Jose Abreu
[not found] ` <cover.1508938927.git.joabreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-10-25 14:04 ` [PATCH net-next 1/2] net: stmmac: Add support for DWMAC5 with TSN features Jose Abreu
2017-10-25 14:04 ` Jose Abreu
2017-10-25 14:04 ` [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters Jose Abreu
[not found] ` <ef1d220cf792c74ae278e0200ca4763f9ab62d3e.1508938927.git.joabreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-10-25 19:34 ` Florian Fainelli
2017-10-25 19:34 ` Florian Fainelli
[not found] ` <c2a4a435-0b0b-4fa3-a69a-280f6d0c6427-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-26 7:54 ` Jose Abreu
2017-10-26 7:54 ` Jose Abreu
2017-10-26 7:54 ` Jose Abreu
2017-10-26 9:03 ` Andrew Lunn
[not found] ` <20171026090308.GD20299-g2DYL2Zd6BY@public.gmane.org>
2017-10-26 9:19 ` Jose Abreu
2017-10-26 9:19 ` Jose Abreu
2017-10-26 9:19 ` Jose Abreu
2017-10-26 10:08 ` Jose Abreu
2017-10-26 10:08 ` Jose Abreu
2017-10-26 16:23 ` Jesus Sanchez-Palencia
2017-10-27 8:53 ` Jose Abreu
2017-10-27 8:53 ` Jose Abreu
[not found] ` <867d6d43-9df7-4097-db5a-f2049236394f-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-10-26 21:56 ` Andrew Lunn [this message]
2017-10-26 21:56 ` Andrew Lunn
2017-10-27 9:05 ` Jose Abreu
2017-10-27 9:05 ` Jose Abreu
2017-10-27 12:29 ` Giuseppe CAVALLARO
2017-10-27 12:29 ` Giuseppe CAVALLARO
[not found] ` <de8781f7-39b1-8ba9-d0d0-ba89834697d3-qxv4g6HH51o@public.gmane.org>
2017-10-27 13:50 ` Jose Abreu
2017-10-27 13:50 ` Jose Abreu
2017-10-27 13:50 ` Jose Abreu
[not found] ` <b4c76843-761c-4a51-f8c5-0e058cfd9929-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-10-27 15:45 ` Richard Cochran
2017-10-27 15:45 ` Richard Cochran
2017-10-26 16:28 ` [PATCH net-next 0/2] net: stmmac: Support DWMAC5 and TSN Jesus Sanchez-Palencia
2017-10-27 8:46 ` Jose Abreu
2017-10-27 8:46 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026215629.GB8489@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=Jose.Abreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=alexandre.torgue-qxv4g6HH51o@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=peppe.cavallaro-qxv4g6HH51o@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.