From: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Xiaolei Li <xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
rogercc.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v1 1/2] mtd: nand: mtk: do not disable ECC IRQ in the function mtk_ecc_disable
Date: Fri, 27 Oct 2017 14:45:38 +0200 [thread overview]
Message-ID: <20171027144538.4875953f@bbrezillon> (raw)
In-Reply-To: <1508746897-62291-2-git-send-email-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On Mon, 23 Oct 2017 16:21:36 +0800
Xiaolei Li <xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
> There will disable ECC IRQ in ECC IRQ handle function, so no need to
> disable it again in the function mtk_ecc_disable.
>
> Signed-off-by: Xiaolei Li <xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
> drivers/mtd/nand/mtk_ecc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/mtk_ecc.c b/drivers/mtd/nand/mtk_ecc.c
> index 7f3b065..82aa6f2 100644
> --- a/drivers/mtd/nand/mtk_ecc.c
> +++ b/drivers/mtd/nand/mtk_ecc.c
> @@ -307,7 +307,6 @@ void mtk_ecc_disable(struct mtk_ecc *ecc)
>
> /* disable it */
> mtk_ecc_wait_idle(ecc, op);
> - writew(0, ecc->regs + ECC_IRQ_REG(op));
As explained in my review of patch 2, I would do it the other way
around: remove this write from the irq handler and keep it here.
> writew(ECC_OP_DISABLE, ecc->regs + ECC_CTL_REG(op));
>
> mutex_unlock(&ecc->lock);
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Xiaolei Li <xiaolei.li@mediatek.com>
Cc: <computersforpeace@gmail.com>,
srv_heupstream@mediatek.com, linux-mtd@lists.infradead.org,
linux-mediatek@lists.infradead.org, dwmw2@infradead.org,
rogercc.lin@mediatek.com
Subject: Re: [PATCH v1 1/2] mtd: nand: mtk: do not disable ECC IRQ in the function mtk_ecc_disable
Date: Fri, 27 Oct 2017 14:45:38 +0200 [thread overview]
Message-ID: <20171027144538.4875953f@bbrezillon> (raw)
In-Reply-To: <1508746897-62291-2-git-send-email-xiaolei.li@mediatek.com>
On Mon, 23 Oct 2017 16:21:36 +0800
Xiaolei Li <xiaolei.li@mediatek.com> wrote:
> There will disable ECC IRQ in ECC IRQ handle function, so no need to
> disable it again in the function mtk_ecc_disable.
>
> Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com>
> ---
> drivers/mtd/nand/mtk_ecc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/mtk_ecc.c b/drivers/mtd/nand/mtk_ecc.c
> index 7f3b065..82aa6f2 100644
> --- a/drivers/mtd/nand/mtk_ecc.c
> +++ b/drivers/mtd/nand/mtk_ecc.c
> @@ -307,7 +307,6 @@ void mtk_ecc_disable(struct mtk_ecc *ecc)
>
> /* disable it */
> mtk_ecc_wait_idle(ecc, op);
> - writew(0, ecc->regs + ECC_IRQ_REG(op));
As explained in my review of patch 2, I would do it the other way
around: remove this write from the irq handler and keep it here.
> writew(ECC_OP_DISABLE, ecc->regs + ECC_CTL_REG(op));
>
> mutex_unlock(&ecc->lock);
next prev parent reply other threads:[~2017-10-27 12:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 8:21 [PATCH v1 0/2] Improve MTK ECC Engine driver Xiaolei Li
2017-10-23 8:21 ` Xiaolei Li
[not found] ` <1508746897-62291-1-git-send-email-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-10-23 8:21 ` [PATCH v1 1/2] mtd: nand: mtk: do not disable ECC IRQ in the function mtk_ecc_disable Xiaolei Li
2017-10-23 8:21 ` Xiaolei Li
[not found] ` <1508746897-62291-2-git-send-email-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-10-27 12:45 ` Boris Brezillon [this message]
2017-10-27 12:45 ` Boris Brezillon
2017-10-23 8:21 ` [PATCH v1 2/2] mtd: nand: mtk: fix infinite ECC decode IRQ issue Xiaolei Li
2017-10-23 8:21 ` Xiaolei Li
[not found] ` <1508746897-62291-3-git-send-email-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-10-27 12:44 ` Boris Brezillon
2017-10-27 12:44 ` Boris Brezillon
2017-10-28 4:05 ` xiaolei li
2017-10-28 4:05 ` xiaolei li
2017-10-29 19:47 ` Boris Brezillon
2017-10-29 19:47 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027144538.4875953f@bbrezillon \
--to=boris.brezillon-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=rogercc.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.