* [PATCH] usb: typec: tps6598x: mark expected switch fall-through
@ 2017-10-27 21:01 Gustavo A. R. Silva
2017-10-31 8:17 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-10-27 21:01 UTC (permalink / raw)
To: Heikki Krogerus, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/usb/typec/tps6598x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c
index 8893f79..b728d9e 100644
--- a/drivers/usb/typec/tps6598x.c
+++ b/drivers/usb/typec/tps6598x.c
@@ -403,6 +403,7 @@ static int tps6598x_probe(struct i2c_client *client)
case TPS_PORTINFO_DRP_UFP_DRD:
case TPS_PORTINFO_DRP_DFP_DRD:
tps->typec_cap.dr_set = tps6598x_dr_set;
+ /* fall through */
case TPS_PORTINFO_DRP_UFP:
case TPS_PORTINFO_DRP_DFP:
tps->typec_cap.pr_set = tps6598x_pr_set;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: tps6598x: mark expected switch fall-through
2017-10-27 21:01 [PATCH] usb: typec: tps6598x: mark expected switch fall-through Gustavo A. R. Silva
@ 2017-10-31 8:17 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2017-10-31 8:17 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
On Fri, Oct 27, 2017 at 04:01:13PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Thanks,
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-31 8:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-27 21:01 [PATCH] usb: typec: tps6598x: mark expected switch fall-through Gustavo A. R. Silva
2017-10-31 8:17 ` Heikki Krogerus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.