* [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller
@ 2017-10-29 9:57 sathyanarayanan.kuppuswamy
2017-10-29 10:09 ` Marek Vasut
0 siblings, 1 reply; 13+ messages in thread
From: sathyanarayanan.kuppuswamy @ 2017-10-29 9:57 UTC (permalink / raw)
To: boris.brezillon, richard, marek.vasut, cyrille.pitchen,
computersforpeace, dwmw2
Cc: linux-mtd, linux-kernel, sathyaosid, Kuppuswamy Sathyanarayanan
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
This patch adds PCI IDs for Intel Lewisburg PCH SPI serial flash controller.
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
drivers/mtd/spi-nor/intel-spi-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
index e826523..048c007 100644
--- a/drivers/mtd/spi-nor/intel-spi-pci.c
+++ b/drivers/mtd/spi-nor/intel-spi-pci.c
@@ -64,6 +64,8 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
static const struct pci_device_id intel_spi_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
+ { PCI_VDEVICE(INTEL, 0xa1a4), (unsigned long)&bxt_info },
+ { PCI_VDEVICE(INTEL, 0xa224), (unsigned long)&bxt_info },
{ },
};
MODULE_DEVICE_TABLE(pci, intel_spi_pci_ids);
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller
2017-10-29 9:57 [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller sathyanarayanan.kuppuswamy
@ 2017-10-29 10:09 ` Marek Vasut
2017-10-29 10:16 ` Mika Westerberg
0 siblings, 1 reply; 13+ messages in thread
From: Marek Vasut @ 2017-10-29 10:09 UTC (permalink / raw)
To: sathyanarayanan.kuppuswamy
Cc: cyrille.pitchen, linux-mtd, linux-kernel, sathyaosid,
Mika Westerberg
On 10/29/2017 10:57 AM, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> This patch adds PCI IDs for Intel Lewisburg PCH SPI serial flash controller.
>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Culling the CC list and adding relevant people.
Patch looks IMO OK, but I'd like RB from Mika.
> ---
> drivers/mtd/spi-nor/intel-spi-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
> index e826523..048c007 100644
> --- a/drivers/mtd/spi-nor/intel-spi-pci.c
> +++ b/drivers/mtd/spi-nor/intel-spi-pci.c
> @@ -64,6 +64,8 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
>
> static const struct pci_device_id intel_spi_pci_ids[] = {
> { PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
> + { PCI_VDEVICE(INTEL, 0xa1a4), (unsigned long)&bxt_info },
> + { PCI_VDEVICE(INTEL, 0xa224), (unsigned long)&bxt_info },
> { },
> };
> MODULE_DEVICE_TABLE(pci, intel_spi_pci_ids);
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller
2017-10-29 10:09 ` Marek Vasut
@ 2017-10-29 10:16 ` Mika Westerberg
2017-10-29 10:34 ` Marek Vasut
2017-10-29 19:14 ` [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller Kuppuswamy, Sathyanarayanan
0 siblings, 2 replies; 13+ messages in thread
From: Mika Westerberg @ 2017-10-29 10:16 UTC (permalink / raw)
To: Marek Vasut
Cc: sathyanarayanan.kuppuswamy, cyrille.pitchen, linux-mtd,
linux-kernel, sathyaosid
On Sun, Oct 29, 2017 at 11:09:50AM +0100, Marek Vasut wrote:
> On 10/29/2017 10:57 AM, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> >
> > This patch adds PCI IDs for Intel Lewisburg PCH SPI serial flash controller.
> >
> > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> Culling the CC list and adding relevant people.
> Patch looks IMO OK, but I'd like RB from Mika.
There is already a patch for Lewisburg queued for v4.15 here:
http://git.infradead.org/l2-mtd.git/commitdiff/d92b0f18a2039ff736b4296ad3cf3d505512051e
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller
2017-10-29 10:16 ` Mika Westerberg
@ 2017-10-29 10:34 ` Marek Vasut
2017-10-29 19:18 ` Kuppuswamy, Sathyanarayanan
2017-10-29 19:14 ` [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller Kuppuswamy, Sathyanarayanan
1 sibling, 1 reply; 13+ messages in thread
From: Marek Vasut @ 2017-10-29 10:34 UTC (permalink / raw)
To: Mika Westerberg
Cc: sathyanarayanan.kuppuswamy, cyrille.pitchen, linux-mtd,
linux-kernel, sathyaosid
On 10/29/2017 11:16 AM, Mika Westerberg wrote:
> On Sun, Oct 29, 2017 at 11:09:50AM +0100, Marek Vasut wrote:
>> On 10/29/2017 10:57 AM, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
>>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>>
>>> This patch adds PCI IDs for Intel Lewisburg PCH SPI serial flash controller.
>>>
>>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>
>> Culling the CC list and adding relevant people.
>> Patch looks IMO OK, but I'd like RB from Mika.
>
> There is already a patch for Lewisburg queued for v4.15 here:
>
> http://git.infradead.org/l2-mtd.git/commitdiff/d92b0f18a2039ff736b4296ad3cf3d505512051e
Heh, even better. Why does this patch add another ID ?
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller
2017-10-29 10:34 ` Marek Vasut
@ 2017-10-29 19:18 ` Kuppuswamy, Sathyanarayanan
2017-10-29 19:58 ` Mika Westerberg
0 siblings, 1 reply; 13+ messages in thread
From: Kuppuswamy, Sathyanarayanan @ 2017-10-29 19:18 UTC (permalink / raw)
To: Marek Vasut, Mika Westerberg
Cc: sathyanarayanan.kuppuswamy, cyrille.pitchen, linux-mtd,
linux-kernel
Hi,
On 10/29/2017 3:34 AM, Marek Vasut wrote:
> On 10/29/2017 11:16 AM, Mika Westerberg wrote:
>> On Sun, Oct 29, 2017 at 11:09:50AM +0100, Marek Vasut wrote:
>>> On 10/29/2017 10:57 AM, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
>>>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>>>
>>>> This patch adds PCI IDs for Intel Lewisburg PCH SPI serial flash controller.
>>>>
>>>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>> Culling the CC list and adding relevant people.
>>> Patch looks IMO OK, but I'd like RB from Mika.
>> There is already a patch for Lewisburg queued for v4.15 here:
>>
>> http://git.infradead.org/l2-mtd.git/commitdiff/d92b0f18a2039ff736b4296ad3cf3d505512051e
> Heh, even better. Why does this patch add another ID ?
0xA1A4 - its for production SKUs.
0xA224 - Its for super SKUs
Mika, Shall I re-base this patch to add super SKU ID?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller
2017-10-29 19:18 ` Kuppuswamy, Sathyanarayanan
@ 2017-10-29 19:58 ` Mika Westerberg
2017-10-29 22:17 ` [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID sathyanarayanan.kuppuswamy
0 siblings, 1 reply; 13+ messages in thread
From: Mika Westerberg @ 2017-10-29 19:58 UTC (permalink / raw)
To: Kuppuswamy, Sathyanarayanan
Cc: Marek Vasut, sathyanarayanan.kuppuswamy, cyrille.pitchen,
linux-mtd, linux-kernel
On Sun, Oct 29, 2017 at 12:18:28PM -0700, Kuppuswamy, Sathyanarayanan wrote:
> Mika, Shall I re-base this patch to add super SKU ID?
Yes, please.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID
2017-10-29 19:58 ` Mika Westerberg
@ 2017-10-29 22:17 ` sathyanarayanan.kuppuswamy
2017-10-30 7:32 ` Mika Westerberg
0 siblings, 1 reply; 13+ messages in thread
From: sathyanarayanan.kuppuswamy @ 2017-10-29 22:17 UTC (permalink / raw)
To: marek.vasut, cyrille.pitchen, mika.westerberg
Cc: linux-mtd, linux-kernel, sathyaosid, Kuppuswamy Sathyanarayanan
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
This patch adds Intel Lewisburg PCH SPI serial flash controller super
SKU PCI ID.
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
1 file changed, 1 insertion(+)
Changes since v1:
* Rebased on top of Mika's SPI support patch.
* Fixed the commit header to reflect the changes made.
diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
index 7fa5b81..048c007 100644
--- a/drivers/mtd/spi-nor/intel-spi-pci.c
+++ b/drivers/mtd/spi-nor/intel-spi-pci.c
@@ -65,6 +65,7 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
static const struct pci_device_id intel_spi_pci_ids[] = {
{ PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
{ PCI_VDEVICE(INTEL, 0xa1a4), (unsigned long)&bxt_info },
+ { PCI_VDEVICE(INTEL, 0xa224), (unsigned long)&bxt_info },
{ },
};
MODULE_DEVICE_TABLE(pci, intel_spi_pci_ids);
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID
2017-10-29 22:17 ` [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID sathyanarayanan.kuppuswamy
@ 2017-10-30 7:32 ` Mika Westerberg
2017-10-30 10:58 ` Cyrille Pitchen
0 siblings, 1 reply; 13+ messages in thread
From: Mika Westerberg @ 2017-10-30 7:32 UTC (permalink / raw)
To: sathyanarayanan.kuppuswamy
Cc: marek.vasut, cyrille.pitchen, linux-mtd, linux-kernel, sathyaosid
On Sun, Oct 29, 2017 at 03:17:35PM -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> This patch adds Intel Lewisburg PCH SPI serial flash controller super
> SKU PCI ID.
>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID
2017-10-30 7:32 ` Mika Westerberg
@ 2017-10-30 10:58 ` Cyrille Pitchen
2017-10-30 14:16 ` Andy Shevchenko
2017-10-30 22:28 ` sathyanarayanan kuppuswamy
0 siblings, 2 replies; 13+ messages in thread
From: Cyrille Pitchen @ 2017-10-30 10:58 UTC (permalink / raw)
To: Mika Westerberg, sathyanarayanan.kuppuswamy
Cc: marek.vasut, linux-mtd, linux-kernel, sathyaosid
Le 30/10/2017 à 08:32, Mika Westerberg a écrit :
> On Sun, Oct 29, 2017 at 03:17:35PM -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>
>> This patch adds Intel Lewisburg PCH SPI serial flash controller super
>> SKU PCI ID.
>>
>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
Applied to the spi-nor/next branch of l2-mtd
Just for info, this patch didn't apply directly, it misses a line in the list of
PCI IDS:
{ PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
Best regards,
Cyrille
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID
2017-10-30 10:58 ` Cyrille Pitchen
@ 2017-10-30 14:16 ` Andy Shevchenko
2017-10-30 22:28 ` sathyanarayanan kuppuswamy
1 sibling, 0 replies; 13+ messages in thread
From: Andy Shevchenko @ 2017-10-30 14:16 UTC (permalink / raw)
To: Cyrille Pitchen
Cc: Mika Westerberg, Kuppuswamy Sathyanarayanan, Marek Vasut,
open list:MEMORY TECHNOLOGY..., linux-kernel@vger.kernel.org,
Sathyanarayanan Kuppuswamy Natarajan
On Mon, Oct 30, 2017 at 12:58 PM, Cyrille Pitchen
<cyrille.pitchen@wedev4u.fr> wrote:
> Le 30/10/2017 à 08:32, Mika Westerberg a écrit :
>> On Sun, Oct 29, 2017 at 03:17:35PM -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> Just for info, this patch didn't apply directly, it misses a line in the list of
> PCI IDS:
>
> { PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
Just in case, you might use
git am -C1 which will ignore such context mistake.
Though it requires to look at the result to be sure it's correct.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID
2017-10-30 10:58 ` Cyrille Pitchen
2017-10-30 14:16 ` Andy Shevchenko
@ 2017-10-30 22:28 ` sathyanarayanan kuppuswamy
2017-10-31 7:48 ` Mika Westerberg
1 sibling, 1 reply; 13+ messages in thread
From: sathyanarayanan kuppuswamy @ 2017-10-30 22:28 UTC (permalink / raw)
To: Cyrille Pitchen, Mika Westerberg
Cc: marek.vasut, linux-mtd, linux-kernel, sathyaosid
Hi,
On 10/30/2017 03:58 AM, Cyrille Pitchen wrote:
> Applied to the spi-nor/next branch of l2-mtd
>
> Just for info, this patch didn't apply directly, it misses a line in the list of
> PCI IDS:
>
> { PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
I re-based my patch on top of Mika's SPI support patch. And it applied
cleanly on top of 4.14-rc6 kernel. Not sure where the problem was?
http://git.infradead.org/l2-mtd.git/commitdiff/d92b0f18a2039ff736b4296ad3cf3d505512051e
--
Sathyanarayanan Kuppuswamy
Linux kernel developer
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID
2017-10-30 22:28 ` sathyanarayanan kuppuswamy
@ 2017-10-31 7:48 ` Mika Westerberg
0 siblings, 0 replies; 13+ messages in thread
From: Mika Westerberg @ 2017-10-31 7:48 UTC (permalink / raw)
To: sathyanarayanan kuppuswamy
Cc: Cyrille Pitchen, marek.vasut, linux-mtd, linux-kernel, sathyaosid
On Mon, Oct 30, 2017 at 03:28:46PM -0700, sathyanarayanan kuppuswamy wrote:
> Hi,
>
>
> On 10/30/2017 03:58 AM, Cyrille Pitchen wrote:
> > Applied to the spi-nor/next branch of l2-mtd
> >
> > Just for info, this patch didn't apply directly, it misses a line in the list of
> > PCI IDS:
> >
> > { PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
> I re-based my patch on top of Mika's SPI support patch. And it applied
> cleanly on top of 4.14-rc6 kernel. Not sure where the problem was?
>
> http://git.infradead.org/l2-mtd.git/commitdiff/d92b0f18a2039ff736b4296ad3cf3d505512051e
There is another patch adding Cedar Fork PCI ID in the l2-mtd tree. You
rebased only on top of Lewisburg patch so you missed that. Anyway,
Cyrille applied this patch already so everything should be fine :-)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller
2017-10-29 10:16 ` Mika Westerberg
2017-10-29 10:34 ` Marek Vasut
@ 2017-10-29 19:14 ` Kuppuswamy, Sathyanarayanan
1 sibling, 0 replies; 13+ messages in thread
From: Kuppuswamy, Sathyanarayanan @ 2017-10-29 19:14 UTC (permalink / raw)
To: Mika Westerberg, Marek Vasut
Cc: sathyanarayanan.kuppuswamy, cyrille.pitchen, linux-mtd,
linux-kernel
Hi Mika,
On 10/29/2017 3:16 AM, Mika Westerberg wrote:
> On Sun, Oct 29, 2017 at 11:09:50AM +0100, Marek Vasut wrote:
>> On 10/29/2017 10:57 AM, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
>>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>>
>>> This patch adds PCI IDs for Intel Lewisburg PCH SPI serial flash controller.
>>>
>>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>> Culling the CC list and adding relevant people.
>> Patch looks IMO OK, but I'd like RB from Mika.
> There is already a patch for Lewisburg queued for v4.15 here:
>
> http://git.infradead.org/l2-mtd.git/commitdiff/d92b0f18a2039ff736b4296ad3cf3d505512051e
Sorry, I did not know that we already have patch submitted for spi-nor
support. So please ignore this patch.
-
Sathyanarayanan KN
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2017-10-31 7:50 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-29 9:57 [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller sathyanarayanan.kuppuswamy
2017-10-29 10:09 ` Marek Vasut
2017-10-29 10:16 ` Mika Westerberg
2017-10-29 10:34 ` Marek Vasut
2017-10-29 19:18 ` Kuppuswamy, Sathyanarayanan
2017-10-29 19:58 ` Mika Westerberg
2017-10-29 22:17 ` [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID sathyanarayanan.kuppuswamy
2017-10-30 7:32 ` Mika Westerberg
2017-10-30 10:58 ` Cyrille Pitchen
2017-10-30 14:16 ` Andy Shevchenko
2017-10-30 22:28 ` sathyanarayanan kuppuswamy
2017-10-31 7:48 ` Mika Westerberg
2017-10-29 19:14 ` [PATCH v1 1/1] mtd: intel-spi: Add support for Intel Lewisburg SPI serial flash controller Kuppuswamy, Sathyanarayanan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.