All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: add a private asm/unaligned.h
Date: Mon, 30 Oct 2017 16:12:08 +0000	[thread overview]
Message-ID: <20171030161207.GS20805@n2100.armlinux.org.uk> (raw)
In-Reply-To: <87bmko1v6f.fsf@free-electrons.com>

On Mon, Oct 30, 2017 at 05:01:44PM +0100, Gregory CLEMENT wrote:
> Hi Russell King,
>  
>  On lun., oct. 30 2017, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
> 
> > On Mon, Oct 30, 2017 at 02:48:02PM +0100, Gregory CLEMENT wrote:
> >> Hi Russell,
> >> 
> >> So I tested the branch fixes in your git tree.
> >> 
> >> After doing a "make multi_v7_defconfig; make zImage", I got the message
> >> "arm-linux-gnueabi-ld: error: zImage file size is incorrect" you added
> >> in the commit "ARM: verify size of zImage".
> >> 
> >> It is the same with mvebu_v7_defconfig, so I wonder wich with
> >> configuration this patch was tested ?
> >
> > I heard a similar report from Olof when his autobuilder produced 100%
> > failure.  I tried one of the same defconfig's that Olof tried here,
> > and didn't see the failure.  It passes my build tests here, and it
> > also passes kernelci's build tests too.
> >
> > So, I _think_ it's got something to do with the toolchain versions
> > being used, but at the moment I'm just guessing.  I've no real idea,
> > because I've no idea what's causing the failure at the moment.
> >
> > Olof said that he'd send me one of the build trees, but I'm still
> > waiting.
> >
> > What I need is a tarball of the objects from arch/arm/boot/compressed
> > to work out what's going on - when grabbing that, it may be a good
> 
> I've just attached this tarball to this email. It might be rejected by
> the mailing list, but as you are also in the "To" field you should
> receive it.
> 
> Actually the archive is the full content of arch/arm/boot/compressed
> from my build directory and I removed vmlinux and all the piggy files to
> have a small archive.
> 
> If they are also needed then I can provide an url for it.

Thanks.

Unfortunately, I can't reproduce the issue using your objects and my
linker.

If I modify your vmlinux.lds to add the assert in, and then link using:

$ arm-linux-ld -o vmlinux -T vmlinux.lds *.o --defsym _kernel_bss_size=0 \
  --defsym input_data_end=0 --defsym input_data=0

Then it links successfully.  If I objcopy that:

$ arm-linux-objcopy -O binary -R .comment -S vmlinux zImage
$ vdir zImage
-rwxrwxr-x 1 rmk rmk 27784 Oct 30 16:10 zImage
$ arm-linux-nm vmlinux |grep _edata
00006c88 D _edata
$ echo $((0x6c88))
27784

So it all looks sane here.  So my hunch is that whatever's going wrong,
it's going wrong at the final link, which means I need the vmlinux as
generated by your toolchain.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Romain Izard <romain.izard.pro@gmail.com>,
	Sven Schmidt <4sschmid@informatik.uni-hamburg.de>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Petr Cvek <petrcvekcz@gmail.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Andrea Adami <andrea.adami@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>
Subject: Re: [PATCH] ARM: add a private asm/unaligned.h
Date: Mon, 30 Oct 2017 16:12:08 +0000	[thread overview]
Message-ID: <20171030161207.GS20805@n2100.armlinux.org.uk> (raw)
In-Reply-To: <87bmko1v6f.fsf@free-electrons.com>

On Mon, Oct 30, 2017 at 05:01:44PM +0100, Gregory CLEMENT wrote:
> Hi Russell King,
>  
>  On lun., oct. 30 2017, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
> 
> > On Mon, Oct 30, 2017 at 02:48:02PM +0100, Gregory CLEMENT wrote:
> >> Hi Russell,
> >> 
> >> So I tested the branch fixes in your git tree.
> >> 
> >> After doing a "make multi_v7_defconfig; make zImage", I got the message
> >> "arm-linux-gnueabi-ld: error: zImage file size is incorrect" you added
> >> in the commit "ARM: verify size of zImage".
> >> 
> >> It is the same with mvebu_v7_defconfig, so I wonder wich with
> >> configuration this patch was tested ?
> >
> > I heard a similar report from Olof when his autobuilder produced 100%
> > failure.  I tried one of the same defconfig's that Olof tried here,
> > and didn't see the failure.  It passes my build tests here, and it
> > also passes kernelci's build tests too.
> >
> > So, I _think_ it's got something to do with the toolchain versions
> > being used, but at the moment I'm just guessing.  I've no real idea,
> > because I've no idea what's causing the failure at the moment.
> >
> > Olof said that he'd send me one of the build trees, but I'm still
> > waiting.
> >
> > What I need is a tarball of the objects from arch/arm/boot/compressed
> > to work out what's going on - when grabbing that, it may be a good
> 
> I've just attached this tarball to this email. It might be rejected by
> the mailing list, but as you are also in the "To" field you should
> receive it.
> 
> Actually the archive is the full content of arch/arm/boot/compressed
> from my build directory and I removed vmlinux and all the piggy files to
> have a small archive.
> 
> If they are also needed then I can provide an url for it.

Thanks.

Unfortunately, I can't reproduce the issue using your objects and my
linker.

If I modify your vmlinux.lds to add the assert in, and then link using:

$ arm-linux-ld -o vmlinux -T vmlinux.lds *.o --defsym _kernel_bss_size=0 \
  --defsym input_data_end=0 --defsym input_data=0

Then it links successfully.  If I objcopy that:

$ arm-linux-objcopy -O binary -R .comment -S vmlinux zImage
$ vdir zImage
-rwxrwxr-x 1 rmk rmk 27784 Oct 30 16:10 zImage
$ arm-linux-nm vmlinux |grep _edata
00006c88 D _edata
$ echo $((0x6c88))
27784

So it all looks sane here.  So my hunch is that whatever's going wrong,
it's going wrong at the final link, which means I need the vmlinux as
generated by your toolchain.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

  reply	other threads:[~2017-10-30 16:12 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-20 20:01 [PATCH] ARM: add a private asm/unaligned.h Arnd Bergmann
2017-10-20 20:01 ` Arnd Bergmann
2017-10-20 20:22 ` Ard Biesheuvel
2017-10-20 20:22   ` Ard Biesheuvel
2017-10-23 15:04 ` Romain Izard
2017-10-23 15:04   ` Romain Izard
2017-10-27 15:19 ` Gregory CLEMENT
2017-10-27 15:19   ` Gregory CLEMENT
2017-10-27 15:27   ` Russell King - ARM Linux
2017-10-27 15:27     ` Russell King - ARM Linux
2017-10-30 13:48     ` Gregory CLEMENT
2017-10-30 13:48       ` Gregory CLEMENT
2017-10-30 14:55       ` Ard Biesheuvel
2017-10-30 14:55         ` Ard Biesheuvel
2017-10-30 15:05         ` Gregory CLEMENT
2017-10-30 15:05           ` Gregory CLEMENT
2017-10-30 15:07           ` Ard Biesheuvel
2017-10-30 15:07             ` Ard Biesheuvel
2017-10-30 15:09             ` Gregory CLEMENT
2017-10-30 15:09               ` Gregory CLEMENT
2017-10-30 15:20               ` Ard Biesheuvel
2017-10-30 15:20                 ` Ard Biesheuvel
2017-10-30 15:33                 ` Gregory CLEMENT
2017-10-30 15:33                   ` Gregory CLEMENT
2017-10-30 15:35                   ` Ard Biesheuvel
2017-10-30 15:35                     ` Ard Biesheuvel
2017-10-30 15:40                     ` Gregory CLEMENT
2017-10-30 15:40                       ` Gregory CLEMENT
2017-10-30 16:59                     ` Russell King - ARM Linux
2017-10-30 16:59                       ` Russell King - ARM Linux
2017-10-30 15:55                   ` Russell King - ARM Linux
2017-10-30 15:55                     ` Russell King - ARM Linux
2017-10-30 16:04                     ` Gregory CLEMENT
2017-10-30 16:04                       ` Gregory CLEMENT
2017-10-30 15:48       ` Russell King - ARM Linux
2017-10-30 15:48         ` Russell King - ARM Linux
2017-10-30 16:01         ` Gregory CLEMENT
2017-10-30 16:12           ` Russell King - ARM Linux [this message]
2017-10-30 16:12             ` Russell King - ARM Linux
2017-10-30 16:24             ` Gregory CLEMENT
2017-10-30 16:24               ` Gregory CLEMENT
2017-10-30 16:38               ` Russell King - ARM Linux
2017-10-30 16:38                 ` Russell King - ARM Linux
2017-10-31 12:47                 ` Russell King - ARM Linux
2017-10-31 12:47                   ` Russell King - ARM Linux
2017-10-31 12:57                   ` Ard Biesheuvel
2017-10-31 12:57                     ` Ard Biesheuvel
2017-10-31 13:22                     ` Gregory CLEMENT
2017-10-31 13:22                       ` Gregory CLEMENT
2017-11-01 15:57                       ` Ard Biesheuvel
2017-11-01 15:57                         ` Ard Biesheuvel
2017-11-01 18:00                         ` Russell King - ARM Linux
2017-11-01 18:00                           ` Russell King - ARM Linux
2017-11-01 18:02                           ` Ard Biesheuvel
2017-11-01 18:02                             ` Ard Biesheuvel
2017-11-01 18:11                             ` Russell King - ARM Linux
2017-11-01 18:11                               ` Russell King - ARM Linux
2017-11-01 18:20                               ` Ard Biesheuvel
2017-11-01 18:20                                 ` Ard Biesheuvel
2017-11-01 19:10                                 ` Russell King - ARM Linux
2017-11-01 19:10                                   ` Russell King - ARM Linux
2017-10-30 15:09     ` Arnd Bergmann
2017-10-30 15:09       ` Arnd Bergmann
2017-10-30 15:50       ` Russell King - ARM Linux
2017-10-30 15:50         ` Russell King - ARM Linux
2017-10-30 17:01         ` Arnd Bergmann
2017-10-30 17:01           ` Arnd Bergmann
2017-10-30 17:13           ` Russell King - ARM Linux
2017-10-30 17:13             ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171030161207.GS20805@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.