diff for duplicates of <20171031171614.GE3675@localhost.localdomain> diff --git a/a/1.txt b/N1/1.txt index 66082a6..e80de00 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,21 +14,17 @@ On Tue, Oct 17, 2017 at 02:59:53PM +0100, Richard Haines wrote: > unsigned short snum; > u32 sid, perm; > -> - if (sk->sk_family == PF_INET) { +> - if (sk->sk_family = PF_INET) { > + /* sctp_connectx(3) calls via > + *selinux_sctp_bind_connect() that validates multiple > + * connect addresses. Because of this need to check > + * address->sa_family as it is possible to have > + * sk->sk_family = PF_INET6 with addr->sa_family = AF_INET. > + */ -> + if (sk->sk_family == PF_INET || -> + address->sa_family == AF_INET) { +> + if (sk->sk_family = PF_INET || +> + address->sa_family = AF_INET) { Not sure which code style applies on this file but the if () above looks odd. At least, checkpatch.pl complained about it. Marcelo --- -To unsubscribe from this list: send the line "unsubscribe linux-security-module" in -the body of a message to majordomo at vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 0611ad7..0f05caa 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020171017135953.4419-1-richard_c_haines@btinternet.com\0" - "From\0marcelo.leitner@gmail.com (Marcelo Ricardo Leitner)\0" - "Subject\0[RFC PATCH 5/5] selinux: Add SCTP support\0" - "Date\0Tue, 31 Oct 2017 15:16:15 -0200\0" + "From\0Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>\0" + "Subject\0Re: [RFC PATCH 5/5] selinux: Add SCTP support\0" + "Date\0Tue, 31 Oct 2017 17:16:15 +0000\0" "To\0linux-security-module@vger.kernel.org\0" "\00:1\0" "b\0" @@ -21,23 +21,19 @@ "> \t\tunsigned short snum;\n" "> \t\tu32 sid, perm;\n" "> \n" - "> -\t\tif (sk->sk_family == PF_INET) {\n" + "> -\t\tif (sk->sk_family = PF_INET) {\n" "> +\t\t/* sctp_connectx(3) calls via\n" "> +\t\t *selinux_sctp_bind_connect() that validates multiple\n" "> +\t\t * connect addresses. Because of this need to check\n" "> +\t\t * address->sa_family as it is possible to have\n" "> +\t\t * sk->sk_family = PF_INET6 with addr->sa_family = AF_INET.\n" "> +\t\t */\n" - "> +\t\tif (sk->sk_family == PF_INET ||\n" - "> +\t\t\t\t\taddress->sa_family == AF_INET) {\n" + "> +\t\tif (sk->sk_family = PF_INET ||\n" + "> +\t\t\t\t\taddress->sa_family = AF_INET) {\n" "\n" "Not sure which code style applies on this file but the if () above\n" "looks odd. At least, checkpatch.pl complained about it.\n" "\n" - " Marcelo\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-security-module\" in\n" - "the body of a message to majordomo at vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Marcelo -73f347ba28ab2423ec7207b4fccbcd889906e471935ca232d1a21b2a82f321db +50fe4c8844614b43fc32281d41e740f83bf9c0f4c2f861b1bd72340eae41c630
diff --git a/a/1.txt b/N2/1.txt index 66082a6..5484268 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -28,7 +28,3 @@ Not sure which code style applies on this file but the if () above looks odd. At least, checkpatch.pl complained about it. Marcelo --- -To unsubscribe from this list: send the line "unsubscribe linux-security-module" in -the body of a message to majordomo at vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 0611ad7..2f0c4fc 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,8 +1,17 @@ "ref\020171017135953.4419-1-richard_c_haines@btinternet.com\0" - "From\0marcelo.leitner@gmail.com (Marcelo Ricardo Leitner)\0" - "Subject\0[RFC PATCH 5/5] selinux: Add SCTP support\0" + "From\0Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>\0" + "Subject\0Re: [RFC PATCH 5/5] selinux: Add SCTP support\0" "Date\0Tue, 31 Oct 2017 15:16:15 -0200\0" - "To\0linux-security-module@vger.kernel.org\0" + "To\0Richard Haines <richard_c_haines@btinternet.com>\0" + "Cc\0selinux@tycho.nsa.gov" + netdev@vger.kernel.org + linux-sctp@vger.kernel.org + linux-security-module@vger.kernel.org + paul@paul-moore.com + vyasevich@gmail.com + nhorman@tuxdriver.com + sds@tycho.nsa.gov + " eparis@parisplace.org\0" "\00:1\0" "b\0" "On Tue, Oct 17, 2017 at 02:59:53PM +0100, Richard Haines wrote:\n" @@ -34,10 +43,6 @@ "Not sure which code style applies on this file but the if () above\n" "looks odd. At least, checkpatch.pl complained about it.\n" "\n" - " Marcelo\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-security-module\" in\n" - "the body of a message to majordomo at vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Marcelo -73f347ba28ab2423ec7207b4fccbcd889906e471935ca232d1a21b2a82f321db +179251389b0b8935ec2169966adb618e4b30b703d7abe35cb7cdaa888f51ecfe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.