From: James Hogan <james.hogan@mips.com>
To: Paul Burton <paul.burton@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Nathan Sullivan <nathan.sullivan@ni.com>,
<linux-mips@linux-mips.org>
Subject: Re: [PATCH for-4.14] MIPS: generic: Fix NI 169445 its build
Date: Tue, 31 Oct 2017 21:52:42 +0000 [thread overview]
Message-ID: <20171031215241.GG15235@jhogan-linux> (raw)
In-Reply-To: <20171031214538.zyr2bnyanjm2gf7i@pburton-laptop>
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
On Tue, Oct 31, 2017 at 02:45:39PM -0700, Paul Burton wrote:
> On Tue, Oct 31, 2017 at 09:41:07PM +0000, James Hogan wrote:
> > From: James Hogan <jhogan@kernel.org>
> >
> > Since commit 04a85e087ad6 ("MIPS: generic: Move NI 169445 FIT image
> > source to its own file"), a generic 32r2el_defconfig kernel fails to
> > build with the following build error:
> >
> > ITB arch/mips/boot/vmlinux.gz.itb
> > Error: arch/mips/boot/vmlinux.gz.its:111.1-2 syntax error
> > FATAL ERROR: Unable to parse input tree
> > mkimage Can't read arch/mips/boot/vmlinux.gz.itb.tmp: Invalid argument
>
> Hmm - I fixed this up already here:
>
> https://patchwork.linux-mips.org/patch/16941/
>
> and Ralf said he was going to fix up the original commit. I guess it got lost
> somewhere..?
Ah yes. It looks like Ralf did fix the original commit, i.e. commit
7aacf86b75bc ("MIPS: NI 169445 board support"), but the change wasn't
transferred to the separate file when the conflict in commit
04a85e087ad6 ("MIPS: generic: Move NI 169445 FIT image source to its own
file") was resolved.
I think my patch has a more correct commit message / Fixes tag now, so I
think this patch is still applicable.
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@mips.com>
To: Paul Burton <paul.burton@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Nathan Sullivan <nathan.sullivan@ni.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH for-4.14] MIPS: generic: Fix NI 169445 its build
Date: Tue, 31 Oct 2017 21:52:42 +0000 [thread overview]
Message-ID: <20171031215241.GG15235@jhogan-linux> (raw)
Message-ID: <20171031215242.TsK_kqAyI_NVLllPswBCEO1DvxpjiTY3kHVTQ84a0Rk@z> (raw)
In-Reply-To: <20171031214538.zyr2bnyanjm2gf7i@pburton-laptop>
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
On Tue, Oct 31, 2017 at 02:45:39PM -0700, Paul Burton wrote:
> On Tue, Oct 31, 2017 at 09:41:07PM +0000, James Hogan wrote:
> > From: James Hogan <jhogan@kernel.org>
> >
> > Since commit 04a85e087ad6 ("MIPS: generic: Move NI 169445 FIT image
> > source to its own file"), a generic 32r2el_defconfig kernel fails to
> > build with the following build error:
> >
> > ITB arch/mips/boot/vmlinux.gz.itb
> > Error: arch/mips/boot/vmlinux.gz.its:111.1-2 syntax error
> > FATAL ERROR: Unable to parse input tree
> > mkimage Can't read arch/mips/boot/vmlinux.gz.itb.tmp: Invalid argument
>
> Hmm - I fixed this up already here:
>
> https://patchwork.linux-mips.org/patch/16941/
>
> and Ralf said he was going to fix up the original commit. I guess it got lost
> somewhere..?
Ah yes. It looks like Ralf did fix the original commit, i.e. commit
7aacf86b75bc ("MIPS: NI 169445 board support"), but the change wasn't
transferred to the separate file when the conflict in commit
04a85e087ad6 ("MIPS: generic: Move NI 169445 FIT image source to its own
file") was resolved.
I think my patch has a more correct commit message / Fixes tag now, so I
think this patch is still applicable.
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-31 21:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 21:41 [PATCH for-4.14] MIPS: generic: Fix NI 169445 its build James Hogan
2017-10-31 21:41 ` James Hogan
2017-10-31 21:45 ` Paul Burton
2017-10-31 21:45 ` Paul Burton
2017-10-31 21:52 ` James Hogan [this message]
2017-10-31 21:52 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031215241.GG15235@jhogan-linux \
--to=james.hogan@mips.com \
--cc=linux-mips@linux-mips.org \
--cc=nathan.sullivan@ni.com \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.