[meta-oe][PATCH v2] whetstone_1.2.bb: Add whetstone benchmark

[meta-oe][PATCH v2] whetstone_1.2.bb: Add whetstone benchmark

[Manjukumar Matha]

The Whetstone benchmark is a synthetic benchmark for evaluating the
performance of computers.

https://en.wikipedia.org/wiki/Whetstone_(benchmark)

Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
---
 meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb

diff --git a/meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb b/meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb
new file mode 100644
index 0000000..e9318eb
--- /dev/null
+++ b/meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb
@@ -0,0 +1,18 @@
+DESCRIPTION = "CPU benchmark to measure floating point performance"
+LICENSE = "PD"
+LIC_FILES_CHKSUM ="file://${COMMON_LICENSE_DIR}/PD;md5=b3597d12946881e13cb3b548d1173851"
+
+SRC_URI = "http://www.netlib.org/benchmark/whetstone.c"
+SRC_URI[md5sum] = "d8eb2cd7104bb5a12d614ac6d3f1f9fb"
+SRC_URI[sha256sum] = "333e4ceca042c146f63eec605573d16ae8b07166cbc44a17bec1ea97c6f1efbf"
+
+S = "${WORKDIR}"
+
+do_compile () {
+	${CC} ${CFLAGS} ${LDFLAGS} -Ofast -o whetstone whetstone.c -lm
+}
+
+do_install () {
+	install -Dm 0755 whetstone ${D}${bindir}/whetstone
+}
+
-- 
2.7.4

Re: [meta-oe][PATCH v2] whetstone_1.2.bb: Add whetstone benchmark

[Martin Jansa]

Why don't you reference the license from the whetstone.c header?

Using COMMON_LICENSE_DIR won't really work for LIC_FILES_CHKSUM to catch
different license if this recipe is ever upgraded to different version.

The same does apply to your 2nd review.

On Wed, Oct 25, 2017 at 8:49 PM, Manjukumar Matha <
manjukumar.harthikote-matha@xilinx.com> wrote:

> The Whetstone benchmark is a synthetic benchmark for evaluating the
> performance of computers.
>
> https://en.wikipedia.org/wiki/Whetstone_(benchmark)
>
> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
> ---
>  meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb | 18
> ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb
>
> diff --git a/meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb
> b/meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb
> new file mode 100644
> index 0000000..e9318eb
> --- /dev/null
> +++ b/meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb
> @@ -0,0 +1,18 @@
> +DESCRIPTION = "CPU benchmark to measure floating point performance"
> +LICENSE = "PD"
> +LIC_FILES_CHKSUM ="file://${COMMON_LICENSE_DIR}/PD;md5=
> b3597d12946881e13cb3b548d1173851"
> +
> +SRC_URI = "http://www.netlib.org/benchmark/whetstone.c"
> +SRC_URI[md5sum] = "d8eb2cd7104bb5a12d614ac6d3f1f9fb"
> +SRC_URI[sha256sum] = "333e4ceca042c146f63eec605573d1
> 6ae8b07166cbc44a17bec1ea97c6f1efbf"
> +
> +S = "${WORKDIR}"
> +
> +do_compile () {
> +       ${CC} ${CFLAGS} ${LDFLAGS} -Ofast -o whetstone whetstone.c -lm
> +}
> +
> +do_install () {
> +       install -Dm 0755 whetstone ${D}${bindir}/whetstone
> +}
> +
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [meta-oe][PATCH v2] whetstone_1.2.bb: Add whetstone benchmark

[Manjukumar Harthikote Matha]

Hi Martin,

Will send a v3 with header for license checksum.
However, I don’t think these recipes will be upgraded in near future.

Thanks,
Manju

From: Martin Jansa [mailto:martin.jansa@gmail.com]
Sent: Wednesday, October 25, 2017 12:10 PM
To: Manjukumar Harthikote Matha <MANJUKUM@xilinx.com>
Cc: openembedded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [oe] [meta-oe][PATCH v2] whetstone_1.2.bb: Add whetstone benchmark

Why don't you reference the license from the whetstone.c header?

Using COMMON_LICENSE_DIR won't really work for LIC_FILES_CHKSUM to catch different license if this recipe is ever upgraded to different version.

The same does apply to your 2nd review.

On Wed, Oct 25, 2017 at 8:49 PM, Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com<mailto:manjukumar.harthikote-matha@xilinx.com>> wrote:
The Whetstone benchmark is a synthetic benchmark for evaluating the
performance of computers.

https://en.wikipedia.org/wiki/Whetstone_(benchmark)

Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com<mailto:manjukumar.harthikote-matha@xilinx.com>>
---
 meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb<http://whetstone_1.2.bb> | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb<http://whetstone_1.2.bb>

diff --git a/meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb<http://whetstone_1.2.bb> b/meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb<http://whetstone_1.2.bb>
new file mode 100644
index 0000000..e9318eb
--- /dev/null
+++ b/meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb<http://whetstone_1.2.bb>
@@ -0,0 +1,18 @@
+DESCRIPTION = "CPU benchmark to measure floating point performance"
+LICENSE = "PD"
+LIC_FILES_CHKSUM ="file://${COMMON_LICENSE_DIR}/PD;md5=b3597d12946881e13cb3b548d1173851<file:///\\$%7bCOMMON_LICENSE_DIR%7d\PD;md5=b3597d12946881e13cb3b548d1173851>"
+
+SRC_URI = "http://www.netlib.org/benchmark/whetstone.c"
+SRC_URI[md5sum] = "d8eb2cd7104bb5a12d614ac6d3f1f9fb"
+SRC_URI[sha256sum] = "333e4ceca042c146f63eec605573d16ae8b07166cbc44a17bec1ea97c6f1efbf"
+
+S = "${WORKDIR}"
+
+do_compile () {
+       ${CC} ${CFLAGS} ${LDFLAGS} -Ofast -o whetstone whetstone.c -lm
+}
+
+do_install () {
+       install -Dm 0755 whetstone ${D}${bindir}/whetstone
+}
+
--
2.7.4

--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org<mailto:Openembedded-devel@lists.openembedded.org>
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-oe][PATCH v2] whetstone_1.2.bb: Add whetstone benchmark

[Denys Dmytriyenko]

On Wed, Oct 25, 2017 at 11:49:06AM -0700, Manjukumar Matha wrote:
> The Whetstone benchmark is a synthetic benchmark for evaluating the
> performance of computers.
> 
> https://en.wikipedia.org/wiki/Whetstone_(benchmark)
> 
> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
> ---
>  meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb
> 
> diff --git a/meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb b/meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb
> new file mode 100644
> index 0000000..e9318eb
> --- /dev/null
> +++ b/meta-oe/recipes-benchmark/whetstone/whetstone_1.2.bb
> @@ -0,0 +1,18 @@
> +DESCRIPTION = "CPU benchmark to measure floating point performance"

SUMMARY ^^^


> +LICENSE = "PD"
> +LIC_FILES_CHKSUM ="file://${COMMON_LICENSE_DIR}/PD;md5=b3597d12946881e13cb3b548d1173851"
> +
> +SRC_URI = "http://www.netlib.org/benchmark/whetstone.c"
> +SRC_URI[md5sum] = "d8eb2cd7104bb5a12d614ac6d3f1f9fb"
> +SRC_URI[sha256sum] = "333e4ceca042c146f63eec605573d16ae8b07166cbc44a17bec1ea97c6f1efbf"
> +
> +S = "${WORKDIR}"
> +
> +do_compile () {
> +	${CC} ${CFLAGS} ${LDFLAGS} -Ofast -o whetstone whetstone.c -lm
> +}
> +
> +do_install () {
> +	install -Dm 0755 whetstone ${D}${bindir}/whetstone
> +}
> +
> -- 
> 2.7.4
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel