From: Stephen Boyd <sboyd@codeaurora.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-clk <linux-clk@vger.kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-fbdev@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Shawn Guo <shawnguo@kernel.org>,
Dong Aisheng <aisheng.dong@nxp.com>
Subject: Re: [RFC PATCH] clk: move of_clk_get_parent_count() declaration to <linux/__clk.h>
Date: Wed, 1 Nov 2017 22:32:23 -0700 [thread overview]
Message-ID: <20171102053223.GH30645@codeaurora.org> (raw)
In-Reply-To: <CAK7LNATuSGfQwL1sP9Z9qtkWgnO5agfPbYjs5m6EkOvexTzzZA@mail.gmail.com>
On 10/29, Masahiro Yamada wrote:
> 2017-10-13 8:17 GMT+09:00 Stephen Boyd <sboyd@codeaurora.org>:
>
> > USB has a
> > similar case, which I think Shawn Guo/Dong Aisheng was trying to
> > add an OF based bulk clk_get() API called of_clk_bulk_get()
> > for[1]. If this get all clks API works there too then we should
> > use it. If it can be non-DT specific, even better.
> >
> > [1] http://lkml.kernel.org/r/1506415441-4435-1-git-send-email-aisheng.dong@nxp.com
>
> OK, we can implement it based on Shawn/Dong's work.
>
> My concern is clk-bulk.c still needs to include #<linux/clk-provider.h>,
> but it is a bit odd since clk-bulk.c is a helper for clk consumers.
>
>
Understood. I'm not concerned though, it's one place where this
happens, not in a bunch of random drivers. What exactly do you
need from clk-provider.h in clk-bulk.c though?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-clk <linux-clk@vger.kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-fbdev@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Shawn Guo <shawnguo@kernel.org>,
Dong Aisheng <aisheng.dong@nxp.com>
Subject: Re: [RFC PATCH] clk: move of_clk_get_parent_count() declaration to <linux/__clk.h>
Date: Thu, 02 Nov 2017 05:32:23 +0000 [thread overview]
Message-ID: <20171102053223.GH30645@codeaurora.org> (raw)
In-Reply-To: <CAK7LNATuSGfQwL1sP9Z9qtkWgnO5agfPbYjs5m6EkOvexTzzZA@mail.gmail.com>
On 10/29, Masahiro Yamada wrote:
> 2017-10-13 8:17 GMT+09:00 Stephen Boyd <sboyd@codeaurora.org>:
>
> > USB has a
> > similar case, which I think Shawn Guo/Dong Aisheng was trying to
> > add an OF based bulk clk_get() API called of_clk_bulk_get()
> > for[1]. If this get all clks API works there too then we should
> > use it. If it can be non-DT specific, even better.
> >
> > [1] http://lkml.kernel.org/r/1506415441-4435-1-git-send-email-aisheng.dong@nxp.com
>
> OK, we can implement it based on Shawn/Dong's work.
>
> My concern is clk-bulk.c still needs to include #<linux/clk-provider.h>,
> but it is a bit odd since clk-bulk.c is a helper for clk consumers.
>
>
Understood. I'm not concerned though, it's one place where this
happens, not in a bunch of random drivers. What exactly do you
need from clk-provider.h in clk-bulk.c though?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-11-02 5:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 1:25 [RFC PATCH] clk: move of_clk_get_parent_count() declaration to <linux/__clk.h> Masahiro Yamada
2017-10-05 1:25 ` Masahiro Yamada
2017-10-12 23:17 ` Stephen Boyd
2017-10-12 23:17 ` Stephen Boyd
2017-10-28 17:35 ` Masahiro Yamada
2017-10-28 17:35 ` Masahiro Yamada
2017-11-02 5:32 ` Stephen Boyd [this message]
2017-11-02 5:32 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102053223.GH30645@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=aisheng.dong@nxp.com \
--cc=b.zolnierkie@samsung.com \
--cc=hdegoede@redhat.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=shawnguo@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.