From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: David Daney <david.daney@cavium.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org,
James Hogan <james.hogan@mips.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org,
"Steven J. Hill" <steven.hill@cavium.com>,
devicetree@vger.kernel.org, Carlos Munoz <cmunoz@cavium.com>
Subject: Re: [PATCH 1/7] dt-bindings: Add Cavium Octeon Common Ethernet Interface.
Date: Thu, 2 Nov 2017 13:47:19 +0100 [thread overview]
Message-ID: <20171102124719.GG4772@lunn.ch> (raw)
In-Reply-To: <af0de889-a34b-8346-9eeb-171498cc61ca@gmail.com>
On Wed, Nov 01, 2017 at 06:09:17PM -0700, Florian Fainelli wrote:
> On 11/01/2017 05:36 PM, David Daney wrote:
> > From: Carlos Munoz <cmunoz@cavium.com>
> >
> > Add bindings for Common Ethernet Interface (BGX) block.
> >
> > Signed-off-by: Carlos Munoz <cmunoz@cavium.com>
> > Signed-off-by: Steven J. Hill <Steven.Hill@cavium.com>
> > Signed-off-by: David Daney <david.daney@cavium.com>
> > ---
> [snip]
> > +Properties:
> > +
> > +- compatible: "cavium,octeon-7360-xcv": Compatibility with cn73xx SOCs.
> > +
> > +- reg: The index of the interface within the BGX block.
> > +
> > +- local-mac-address: Mac address for the interface.
> > +
> > +- phy-handle: phandle to the phy node connected to the interface.
> > +
> > +- cavium,rx-clk-delay-bypass: Set to <1> to bypass the rx clock delay setting.
> > + Needed by the Micrel PHY.
>
> Is not that implied by an appropriate "phy-mode" property already?
Hi Florian
Looking at the driver patch, phy-mode is not used at
all. of_phy_connect() passes a hard coded SGMII value!
David, you need to fix this.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: David Daney <david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
James Hogan <james.hogan-8NJIiSa5LzA@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Steven J. Hill"
<steven.hill-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Carlos Munoz <cmunoz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/7] dt-bindings: Add Cavium Octeon Common Ethernet Interface.
Date: Thu, 2 Nov 2017 13:47:19 +0100 [thread overview]
Message-ID: <20171102124719.GG4772@lunn.ch> (raw)
In-Reply-To: <af0de889-a34b-8346-9eeb-171498cc61ca-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, Nov 01, 2017 at 06:09:17PM -0700, Florian Fainelli wrote:
> On 11/01/2017 05:36 PM, David Daney wrote:
> > From: Carlos Munoz <cmunoz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> >
> > Add bindings for Common Ethernet Interface (BGX) block.
> >
> > Signed-off-by: Carlos Munoz <cmunoz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> > Signed-off-by: Steven J. Hill <Steven.Hill-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> > Signed-off-by: David Daney <david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> > ---
> [snip]
> > +Properties:
> > +
> > +- compatible: "cavium,octeon-7360-xcv": Compatibility with cn73xx SOCs.
> > +
> > +- reg: The index of the interface within the BGX block.
> > +
> > +- local-mac-address: Mac address for the interface.
> > +
> > +- phy-handle: phandle to the phy node connected to the interface.
> > +
> > +- cavium,rx-clk-delay-bypass: Set to <1> to bypass the rx clock delay setting.
> > + Needed by the Micrel PHY.
>
> Is not that implied by an appropriate "phy-mode" property already?
Hi Florian
Looking at the driver patch, phy-mode is not used at
all. of_phy_connect() passes a hard coded SGMII value!
David, you need to fix this.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-02 12:47 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 0:35 [PATCH 0/7] Cavium OCTEON-III network driver David Daney
2017-11-02 0:36 ` [PATCH 1/7] dt-bindings: Add Cavium Octeon Common Ethernet Interface David Daney
2017-11-02 1:09 ` Florian Fainelli
2017-11-02 1:26 ` David Daney
2017-11-02 12:47 ` Andrew Lunn [this message]
2017-11-02 12:47 ` Andrew Lunn
2017-11-02 16:06 ` David Daney
2017-11-02 16:06 ` David Daney
2017-11-02 0:36 ` [PATCH 2/7] MIPS: Octeon: Enable LMTDMA/LMTST operations David Daney
2017-11-02 0:36 ` David Daney
2017-11-02 0:36 ` [PATCH 3/7] MIPS: Octeon: Add a global resource manager David Daney
2017-11-02 12:23 ` Andrew Lunn
2017-11-02 12:23 ` Andrew Lunn
2017-11-02 16:03 ` David Daney
2017-11-02 17:49 ` Florian Fainelli
2017-11-02 17:49 ` Florian Fainelli
2017-11-02 0:36 ` [PATCH 4/7] MIPS: Octeon: Add Free Pointer Unit (FPA) support David Daney
2017-11-02 0:36 ` David Daney
2017-11-02 0:36 ` David Daney
2017-11-02 0:36 ` David Daney
2017-11-02 3:29 ` Florian Fainelli
2017-11-02 16:27 ` David Daney
2017-11-02 18:04 ` Florian Fainelli
2017-11-02 18:04 ` Florian Fainelli
2017-11-02 19:12 ` David Daney
2017-11-02 13:14 ` James Hogan
2017-11-02 13:14 ` James Hogan
2017-11-02 0:36 ` [PATCH 5/7] MIPS: Octeon: Automatically provision CVMSEG space David Daney
2017-11-05 7:45 ` kbuild test robot
2017-11-05 7:45 ` kbuild test robot
2017-11-05 7:45 ` kbuild test robot
2017-11-02 0:36 ` [PATCH 6/7] netdev: octeon-ethernet: Add Cavium Octeon III support David Daney
2017-11-02 12:43 ` Andrew Lunn
2017-11-02 15:55 ` David Daney
2017-11-02 15:55 ` David Daney
2017-11-02 16:10 ` Andrew Lunn
2017-11-02 16:37 ` David Daney
2017-11-02 16:37 ` David Daney
2017-11-02 16:56 ` Andrew Lunn
2017-11-02 16:56 ` Andrew Lunn
2017-11-02 18:31 ` David Daney
2017-11-02 18:53 ` Florian Fainelli
2017-11-02 18:53 ` Florian Fainelli
2017-11-02 19:13 ` Florian Fainelli
2017-11-02 22:45 ` David Daney
2017-11-02 22:45 ` David Daney
2017-11-03 15:48 ` Andrew Lunn
2017-11-03 15:48 ` Andrew Lunn
2017-11-02 0:36 ` [PATCH 7/7] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-* David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102124719.GG4772@lunn.ch \
--to=andrew@lunn.ch \
--cc=cmunoz@cavium.com \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=james.hogan@mips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=steven.hill@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.