From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: ensure dump_instr() checks addr_limit
Date: Thu, 2 Nov 2017 17:47:06 +0100 [thread overview]
Message-ID: <20171102164706.GC5061@kroah.com> (raw)
In-Reply-To: <20171102163452.7652-1-mark.rutland@arm.com>
On Thu, Nov 02, 2017 at 04:34:52PM +0000, Mark Rutland wrote:
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Huh? What's that doing up here?
> When CONFIG_DEBUG_USER is enabled, it's possible for a user to
> deliberately trigger dump_instr() with a chosen kernel address.
>
> Let's avoid problems resulting from this by using get_user() rather than
> __get_user(), ensuring that we don't erroneously access kernel memory.
>
> So that we can use the same code to dump user instructions and kernel
> instructions, the common dumping code is factored out to __dump_instr(),
> with the fs manipulated appropriately in dump_instr() around calls to
> this.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Russell King <rmk+kernel@armlinux.org.uk>
> Cc: stable at vger.kernel.org
It's right here...
confused.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Russell King <rmk+kernel@armlinux.org.uk>,
stable@vger.kernel.org
Subject: Re: [PATCH] arm: ensure dump_instr() checks addr_limit
Date: Thu, 2 Nov 2017 17:47:06 +0100 [thread overview]
Message-ID: <20171102164706.GC5061@kroah.com> (raw)
In-Reply-To: <20171102163452.7652-1-mark.rutland@arm.com>
On Thu, Nov 02, 2017 at 04:34:52PM +0000, Mark Rutland wrote:
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Huh? What's that doing up here?
> When CONFIG_DEBUG_USER is enabled, it's possible for a user to
> deliberately trigger dump_instr() with a chosen kernel address.
>
> Let's avoid problems resulting from this by using get_user() rather than
> __get_user(), ensuring that we don't erroneously access kernel memory.
>
> So that we can use the same code to dump user instructions and kernel
> instructions, the common dumping code is factored out to __dump_instr(),
> with the fs manipulated appropriately in dump_instr() around calls to
> this.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Russell King <rmk+kernel@armlinux.org.uk>
> Cc: stable@vger.kernel.org
It's right here...
confused.
greg k-h
next prev parent reply other threads:[~2017-11-02 16:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 16:34 [PATCH] arm: ensure dump_instr() checks addr_limit Mark Rutland
2017-11-02 16:34 ` Mark Rutland
2017-11-02 16:47 ` Greg KH [this message]
2017-11-02 16:47 ` Greg KH
2017-11-02 17:30 ` Mark Rutland
2017-11-02 17:30 ` Mark Rutland
2017-11-02 17:46 ` Greg KH
2017-11-02 17:46 ` Greg KH
2017-11-02 17:50 ` Russell King - ARM Linux
2017-11-02 17:50 ` Russell King - ARM Linux
2017-11-02 16:57 ` Russell King - ARM Linux
2017-11-02 16:57 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102164706.GC5061@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.