* [PATCH] watchdog: f71808e_wdt: mark expected switch fall-throughs
@ 2017-11-02 19:28 Gustavo A. R. Silva
2017-11-03 13:34 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-02 19:28 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck
Cc: linux-watchdog, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case I replaced "Fall" with a proper
"fall through" comment, which is what GCC is expecting to find.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/watchdog/f71808e_wdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c
index 8658dba..e0678c1 100644
--- a/drivers/watchdog/f71808e_wdt.c
+++ b/drivers/watchdog/f71808e_wdt.c
@@ -627,7 +627,7 @@ static long watchdog_ioctl(struct file *file, unsigned int cmd,
if (new_options & WDIOS_ENABLECARD)
return watchdog_start();
-
+ /* fall through */
case WDIOC_KEEPALIVE:
watchdog_keepalive();
@@ -641,7 +641,7 @@ static long watchdog_ioctl(struct file *file, unsigned int cmd,
return -EINVAL;
watchdog_keepalive();
- /* Fall */
+ /* fall through */
case WDIOC_GETTIMEOUT:
return put_user(watchdog.timeout, uarg.i);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: watchdog: f71808e_wdt: mark expected switch fall-throughs
2017-11-02 19:28 [PATCH] watchdog: f71808e_wdt: mark expected switch fall-throughs Gustavo A. R. Silva
@ 2017-11-03 13:34 ` Guenter Roeck
2017-11-03 14:44 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2017-11-03 13:34 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Wim Van Sebroeck, linux-watchdog, linux-kernel
On Thu, Nov 02, 2017 at 02:28:17PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case I replaced "Fall" with a proper
> "fall through" comment, which is what GCC is expecting to find.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/f71808e_wdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c
> index 8658dba..e0678c1 100644
> --- a/drivers/watchdog/f71808e_wdt.c
> +++ b/drivers/watchdog/f71808e_wdt.c
> @@ -627,7 +627,7 @@ static long watchdog_ioctl(struct file *file, unsigned int cmd,
>
> if (new_options & WDIOS_ENABLECARD)
> return watchdog_start();
> -
> + /* fall through */
>
> case WDIOC_KEEPALIVE:
> watchdog_keepalive();
> @@ -641,7 +641,7 @@ static long watchdog_ioctl(struct file *file, unsigned int cmd,
> return -EINVAL;
>
> watchdog_keepalive();
> - /* Fall */
> + /* fall through */
>
> case WDIOC_GETTIMEOUT:
> return put_user(watchdog.timeout, uarg.i);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: watchdog: f71808e_wdt: mark expected switch fall-throughs
2017-11-03 13:34 ` Guenter Roeck
@ 2017-11-03 14:44 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-03 14:44 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Wim Van Sebroeck, linux-watchdog, linux-kernel
Quoting Guenter Roeck <linux@roeck-us.net>:
> On Thu, Nov 02, 2017 at 02:28:17PM -0500, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Notice that in this particular case I replaced "Fall" with a proper
>> "fall through" comment, which is what GCC is expecting to find.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
Thanks!
--
Gustavo A. R. Silva
>> ---
>> drivers/watchdog/f71808e_wdt.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c
>> index 8658dba..e0678c1 100644
>> --- a/drivers/watchdog/f71808e_wdt.c
>> +++ b/drivers/watchdog/f71808e_wdt.c
>> @@ -627,7 +627,7 @@ static long watchdog_ioctl(struct file *file,
>> unsigned int cmd,
>>
>> if (new_options & WDIOS_ENABLECARD)
>> return watchdog_start();
>> -
>> + /* fall through */
>>
>> case WDIOC_KEEPALIVE:
>> watchdog_keepalive();
>> @@ -641,7 +641,7 @@ static long watchdog_ioctl(struct file *file,
>> unsigned int cmd,
>> return -EINVAL;
>>
>> watchdog_keepalive();
>> - /* Fall */
>> + /* fall through */
>>
>> case WDIOC_GETTIMEOUT:
>> return put_user(watchdog.timeout, uarg.i);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-03 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-02 19:28 [PATCH] watchdog: f71808e_wdt: mark expected switch fall-throughs Gustavo A. R. Silva
2017-11-03 13:34 ` Guenter Roeck
2017-11-03 14:44 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.