All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: "Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, linux-mm <linux-mm@kvack.org>
Subject: Re: POWER: Unexpected fault when writing to brk-allocated memory
Date: Sun, 5 Nov 2017 23:54:43 +1100	[thread overview]
Message-ID: <20171105235443.045fb4b7@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <919a1cb5-c3b5-ddee-d6a6-0994c282ae84@redhat.com>

On Sun, 5 Nov 2017 13:35:40 +0100
Florian Weimer <fweimer@redhat.com> wrote:

> On 11/05/2017 01:18 PM, Nicholas Piggin wrote:
> 
> > There was a recent change to move to 128TB address space by default,
> > and option for 512TB addresses if explicitly requested.  
> 
> Do you have a commit hash for the introduction of 128TB by default?  Thanks.

I guess this one

f6eedbba7a26 ("powerpc/mm/hash: Increase VA range to 128TB")

> 
> > Your brk request asked for > 128TB which the kernel gave it, but the
> > address limit in the paca that the SLB miss tests against was not
> > updated to reflect the switch to 512TB address space.
> > 
> > Why is your brk starting so high? Are you trying to test the > 128TB
> > case, or maybe something is confused by the 64->128TB change? What's
> > the strace look like if you run on a distro or <= 4.10 kernel?  
> 
> I think it is a consequence of running with an explicit loader 
> invocation.  With that, the heap is placed above ld.so, which can be 
> quite high in the address space.
> 
> I'm attaching two runs of cat, one executing directly as /bin/cat, and 
> one with /lib64/ld64.so.1 /bin/cat.
> 
> Fortunately, this does *not* apply to PIE binaries (also attached). 
> However, explicit loader invocations are sometimes used in test suites 
> (not just for glibc), and these sporadic test failures are quite annoying.
> 
> Do you still need the strace log?  And if yes, of what exactly?

Thanks, that should be quite helpful. I'll spend a bit more time to
study it, I'll let you know if I need any other traces.

> 
> > Something like the following patch may help if you could test.  
> 
> Okay, this will take some time.

It's no rush, there will probably be a revision to come.

Thanks,
Nick

WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Piggin <npiggin@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: "Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, linux-mm <linux-mm@kvack.org>
Subject: Re: POWER: Unexpected fault when writing to brk-allocated memory
Date: Sun, 5 Nov 2017 23:54:43 +1100	[thread overview]
Message-ID: <20171105235443.045fb4b7@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <919a1cb5-c3b5-ddee-d6a6-0994c282ae84@redhat.com>

On Sun, 5 Nov 2017 13:35:40 +0100
Florian Weimer <fweimer@redhat.com> wrote:

> On 11/05/2017 01:18 PM, Nicholas Piggin wrote:
> 
> > There was a recent change to move to 128TB address space by default,
> > and option for 512TB addresses if explicitly requested.  
> 
> Do you have a commit hash for the introduction of 128TB by default?  Thanks.

I guess this one

f6eedbba7a26 ("powerpc/mm/hash: Increase VA range to 128TB")

> 
> > Your brk request asked for > 128TB which the kernel gave it, but the
> > address limit in the paca that the SLB miss tests against was not
> > updated to reflect the switch to 512TB address space.
> > 
> > Why is your brk starting so high? Are you trying to test the > 128TB
> > case, or maybe something is confused by the 64->128TB change? What's
> > the strace look like if you run on a distro or <= 4.10 kernel?  
> 
> I think it is a consequence of running with an explicit loader 
> invocation.  With that, the heap is placed above ld.so, which can be 
> quite high in the address space.
> 
> I'm attaching two runs of cat, one executing directly as /bin/cat, and 
> one with /lib64/ld64.so.1 /bin/cat.
> 
> Fortunately, this does *not* apply to PIE binaries (also attached). 
> However, explicit loader invocations are sometimes used in test suites 
> (not just for glibc), and these sporadic test failures are quite annoying.
> 
> Do you still need the strace log?  And if yes, of what exactly?

Thanks, that should be quite helpful. I'll spend a bit more time to
study it, I'll let you know if I need any other traces.

> 
> > Something like the following patch may help if you could test.  
> 
> Okay, this will take some time.

It's no rush, there will probably be a revision to come.

Thanks,
Nick

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-11-05 12:54 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 17:05 POWER: Unexpected fault when writing to brk-allocated memory Florian Weimer
2017-11-03 17:05 ` Florian Weimer
2017-11-05 12:18 ` Nicholas Piggin
2017-11-05 12:18   ` Nicholas Piggin
2017-11-05 12:35   ` Florian Weimer
2017-11-05 12:54     ` Nicholas Piggin [this message]
2017-11-05 12:54       ` Nicholas Piggin
2017-11-05 14:50   ` Florian Weimer
2017-11-05 14:50     ` Florian Weimer
2017-11-06  6:18   ` Aneesh Kumar K.V
2017-11-06  6:18     ` Aneesh Kumar K.V
2017-11-06  6:47     ` Nicholas Piggin
2017-11-06  6:47       ` Nicholas Piggin
2017-11-06  8:11       ` Florian Weimer
2017-11-06  8:11         ` Florian Weimer
2017-11-06  8:25         ` Nicholas Piggin
2017-11-06  8:25           ` Nicholas Piggin
2017-11-06  8:30           ` Aneesh Kumar K.V
2017-11-06  8:30             ` Aneesh Kumar K.V
2017-11-06  8:32             ` Florian Weimer
2017-11-06  8:32               ` Florian Weimer
2017-11-06 10:20               ` Nicholas Piggin
2017-11-06 10:20                 ` Nicholas Piggin
2017-11-07  5:07               ` Nicholas Piggin
2017-11-07  5:07                 ` Nicholas Piggin
2017-11-07  8:15                 ` Florian Weimer
2017-11-07  8:15                   ` Florian Weimer
2017-11-07  9:24                   ` Nicholas Piggin
2017-11-07  9:24                     ` Nicholas Piggin
2017-11-07 11:16                   ` Kirill A. Shutemov
2017-11-07 11:16                     ` Kirill A. Shutemov
2017-11-07 11:15                 ` Kirill A. Shutemov
2017-11-07 11:15                   ` Kirill A. Shutemov
2017-11-07 11:26                   ` Florian Weimer
2017-11-07 11:26                     ` Florian Weimer
2017-11-07 11:44                     ` Kirill A. Shutemov
2017-11-07 11:44                       ` Kirill A. Shutemov
2017-11-07 13:05                       ` Florian Weimer
2017-11-07 13:16                         ` Kirill A. Shutemov
2017-11-07 13:16                           ` Kirill A. Shutemov
2017-11-08  6:08                           ` Michael Ellerman
2017-11-08  6:08                             ` Michael Ellerman
2017-11-08  6:18                             ` Florian Weimer
2017-11-08  6:18                               ` Florian Weimer
2017-11-07 11:56                   ` Nicholas Piggin
2017-11-07 11:56                     ` Nicholas Piggin
2017-11-07 12:28                     ` Kirill A. Shutemov
2017-11-07 12:28                       ` Kirill A. Shutemov
2017-11-07 13:33                       ` Nicholas Piggin
2017-11-07 13:33                         ` Nicholas Piggin
2017-11-07 13:45                         ` Aneesh Kumar K.V
2017-11-07 13:45                           ` Aneesh Kumar K.V
2017-11-07 14:01                           ` Kirill A. Shutemov
2017-11-07 14:01                             ` Kirill A. Shutemov
2017-11-09 17:15                             ` Nicholas Piggin
2017-11-09 17:15                               ` Nicholas Piggin
2017-11-09 19:44                               ` Matthew Wilcox
2017-11-09 19:44                                 ` Matthew Wilcox
2017-11-10  1:26                                 ` Nicholas Piggin
2017-11-10  1:26                                   ` Nicholas Piggin
2017-11-10 12:08                                 ` David Laight
2017-11-10 12:08                                   ` David Laight
2017-11-11 10:30                                   ` Nicholas Piggin
2017-11-11 10:30                                     ` Nicholas Piggin
2017-11-08  4:56                           ` Michael Ellerman
2017-11-08  4:56                             ` Michael Ellerman
2017-11-08  8:30                             ` Kirill A. Shutemov
2017-11-08  8:30                               ` Kirill A. Shutemov
2017-11-06  8:10     ` Florian Weimer
2017-11-06  8:10       ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171105235443.045fb4b7@roar.ozlabs.ibm.com \
    --to=npiggin@gmail.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=fweimer@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.