From: Andrew Lunn <andrew@lunn.ch>
To: Miquel RAYNAL <miquel.raynal@free-electrons.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Antoine Tenart <antoine.tenart@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Nadav Haklai <nadavh@marvell.com>,
netdev@vger.kernel.org, Stefan Chulski <stefanc@marvell.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next v2] net: mvpp2: add ethtool GOP statistics
Date: Mon, 6 Nov 2017 15:25:34 +0100 [thread overview]
Message-ID: <20171106142534.GC24822@lunn.ch> (raw)
In-Reply-To: <20171106110653.034009ad@xps13>
> Here I do have a problem: I choose the IDA solution because it was
> quite straightforward but I agree it would be better to use an unique
> name. Unfortunately, on the Armada-8040-DB that instantiate this driver
> twice, the node name is not unique. There are two CP (master and
> slave) and both names are "ethernet@0". Otherwise, if I use the full
> path, I get something like
> "/cp110-master/config-space@f2000000/ethernet@0" and
> "/cp110-slave/config-space@f4000000/ethernet@0" but the problem is that
> workqueue names are truncated to 24 characters and only 15 appears in
> ps, so it would not solve the issue and choosing the "parent
> parent node name" would work here but does not scale very well. Do you
> have any idea to get this right?
Hi Miquel
You could move the starting of the thread into mvpp2_port_probe(). If
you do it after register_netdev(dev), you can use netdev_name(dev).
Andrew
next prev parent reply other threads:[~2017-11-06 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 11:04 [PATCH net-next v2] net: mvpp2: add ethtool GOP statistics Miquel Raynal
2017-11-03 11:26 ` Miquel RAYNAL
2017-11-03 15:19 ` Andrew Lunn
2017-11-06 10:06 ` Miquel RAYNAL
2017-11-06 14:25 ` Andrew Lunn [this message]
2017-11-06 21:02 ` Miquel RAYNAL
[not found] ` <09d456be927a46c0970bd677651a4098@IL-EXCH01.marvell.com>
2017-11-06 22:45 ` Miquel RAYNAL
2017-11-07 8:22 ` [EXT] " Stefan Chulski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106142534.GC24822@lunn.ch \
--to=andrew@lunn.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=miquel.raynal@free-electrons.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.