[Qemu-trivial] [PATCH 0/4] Some trivial fixes, mostly comment typos

[Qemu-trivial] [PATCH 0/4] Some trivial fixes, mostly comment typos

[Emilio G. Cota]

A few trivial fixes that I embedded in a previous (unrelated) patchset.
Better to submit them separately as a standalone "trivial" patchset.

Note that in patch 1 I went with space indentation instead of
a hard tab just to appease checkpatch. However, the surrounding
code uses hard tabs. Wasn't sure what's preferred in cases like
this.

Thanks,

		Emilio

[Qemu-devel] [PATCH 0/4] Some trivial fixes, mostly comment typos

[Emilio G. Cota]

A few trivial fixes that I embedded in a previous (unrelated) patchset.
Better to submit them separately as a standalone "trivial" patchset.

Note that in patch 1 I went with space indentation instead of
a hard tab just to appease checkpatch. However, the surrounding
code uses hard tabs. Wasn't sure what's preferred in cases like
this.

Thanks,

		Emilio

[Qemu-trivial] [PATCH 1/4] disas/arm: fix 'instuction' typo in comment

[Emilio G. Cota]

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 disas/arm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/disas/arm.c b/disas/arm.c
index 27396dd..6f2079d 100644
--- a/disas/arm.c
+++ b/disas/arm.c
@@ -1651,7 +1651,7 @@ print_insn_coprocessor (bfd_vma pc, struct disassemble_info *info, long given,
 	}
       else
 	{
-	  /* Only match unconditional instuctions against unconditional
+          /* Only match unconditional instructions against unconditional
 	     patterns.  */
 	  if ((given & 0xf0000000) == 0xf0000000)
 	    {
-- 
2.7.4

[Qemu-devel] [PATCH 1/4] disas/arm: fix 'instuction' typo in comment

[Emilio G. Cota]

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 disas/arm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/disas/arm.c b/disas/arm.c
index 27396dd..6f2079d 100644
--- a/disas/arm.c
+++ b/disas/arm.c
@@ -1651,7 +1651,7 @@ print_insn_coprocessor (bfd_vma pc, struct disassemble_info *info, long given,
 	}
       else
 	{
-	  /* Only match unconditional instuctions against unconditional
+          /* Only match unconditional instructions against unconditional
 	     patterns.  */
 	  if ((given & 0xf0000000) == 0xf0000000)
 	    {
-- 
2.7.4

[Qemu-trivial] [PATCH 2/4] linux-user: fix 'finshed' typo in comment

[Emilio G. Cota]

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 linux-user/syscall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 9d4cc4c..47b4a79 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -6231,7 +6231,7 @@ static void *clone_func(void *arg)
     pthread_mutex_lock(&info->mutex);
     pthread_cond_broadcast(&info->cond);
     pthread_mutex_unlock(&info->mutex);
-    /* Wait until the parent has finshed initializing the tls state.  */
+    /* Wait until the parent has finished initializing the tls state.  */
     pthread_mutex_lock(&clone_lock);
     pthread_mutex_unlock(&clone_lock);
     cpu_loop(env);
-- 
2.7.4

[Qemu-devel] [PATCH 2/4] linux-user: fix 'finshed' typo in comment

[Emilio G. Cota]

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 linux-user/syscall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 9d4cc4c..47b4a79 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -6231,7 +6231,7 @@ static void *clone_func(void *arg)
     pthread_mutex_lock(&info->mutex);
     pthread_cond_broadcast(&info->cond);
     pthread_mutex_unlock(&info->mutex);
-    /* Wait until the parent has finshed initializing the tls state.  */
+    /* Wait until the parent has finished initializing the tls state.  */
     pthread_mutex_lock(&clone_lock);
     pthread_mutex_unlock(&clone_lock);
     cpu_loop(env);
-- 
2.7.4

Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/4] linux-user: fix 'finshed' typo in comment

[Riku Voipio]

Applied to linux-user, thanks

Riku

On Wed, Oct 18, 2017 at 06:01:41PM -0400, Emilio G. Cota wrote:
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  linux-user/syscall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 9d4cc4c..47b4a79 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -6231,7 +6231,7 @@ static void *clone_func(void *arg)
>      pthread_mutex_lock(&info->mutex);
>      pthread_cond_broadcast(&info->cond);
>      pthread_mutex_unlock(&info->mutex);
> -    /* Wait until the parent has finshed initializing the tls state.  */
> +    /* Wait until the parent has finished initializing the tls state.  */
>      pthread_mutex_lock(&clone_lock);
>      pthread_mutex_unlock(&clone_lock);
>      cpu_loop(env);
> -- 
> 2.7.4
> 
> 

Re: [Qemu-devel] [PATCH 2/4] linux-user: fix 'finshed' typo in comment

[Riku Voipio]

Applied to linux-user, thanks

Riku

On Wed, Oct 18, 2017 at 06:01:41PM -0400, Emilio G. Cota wrote:
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  linux-user/syscall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 9d4cc4c..47b4a79 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -6231,7 +6231,7 @@ static void *clone_func(void *arg)
>      pthread_mutex_lock(&info->mutex);
>      pthread_cond_broadcast(&info->cond);
>      pthread_mutex_unlock(&info->mutex);
> -    /* Wait until the parent has finshed initializing the tls state.  */
> +    /* Wait until the parent has finished initializing the tls state.  */
>      pthread_mutex_lock(&clone_lock);
>      pthread_mutex_unlock(&clone_lock);
>      cpu_loop(env);
> -- 
> 2.7.4
> 
> 

[Qemu-trivial] [PATCH 3/4] translate-all: fix 'consisits' typo in comment

[Emilio G. Cota]

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 accel/tcg/translate-all.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index c5ce99d..70942be 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -255,7 +255,7 @@ static target_long decode_sleb128(uint8_t **pp)
 /* Encode the data collected about the instructions while compiling TB.
    Place the data at BLOCK, and return the number of bytes consumed.
 
-   The logical table consisits of TARGET_INSN_START_WORDS target_ulong's,
+   The logical table consists of TARGET_INSN_START_WORDS target_ulong's,
    which come from the target's insn_start data, followed by a uintptr_t
    which comes from the host pc of the end of the code implementing the insn.
 
-- 
2.7.4

[Qemu-devel] [PATCH 3/4] translate-all: fix 'consisits' typo in comment

[Emilio G. Cota]

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 accel/tcg/translate-all.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index c5ce99d..70942be 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -255,7 +255,7 @@ static target_long decode_sleb128(uint8_t **pp)
 /* Encode the data collected about the instructions while compiling TB.
    Place the data at BLOCK, and return the number of bytes consumed.
 
-   The logical table consisits of TARGET_INSN_START_WORDS target_ulong's,
+   The logical table consists of TARGET_INSN_START_WORDS target_ulong's,
    which come from the target's insn_start data, followed by a uintptr_t
    which comes from the host pc of the end of the code implementing the insn.
 
-- 
2.7.4

[Qemu-trivial] [PATCH 4/4] qht: fix kernel-doc markup in qht.h

[Emilio G. Cota]

While at it, s/stuct/struct/.

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 include/qemu/qht.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/qemu/qht.h b/include/qemu/qht.h
index 56c2c77..531aa95 100644
--- a/include/qemu/qht.h
+++ b/include/qemu/qht.h
@@ -166,7 +166,7 @@ void qht_iter(struct qht *ht, qht_iter_func_t func, void *userp);
 /**
  * qht_statistics_init - Gather statistics from a QHT
  * @ht: QHT to gather statistics from
- * @stats: pointer to a struct qht_stats to be filled in
+ * @stats: pointer to a &struct qht_stats to be filled in
  *
  * Does NOT need to be called under an RCU read-critical section,
  * since it does not dereference any pointers stored in the hash table.
@@ -177,8 +177,8 @@ void qht_iter(struct qht *ht, qht_iter_func_t func, void *userp);
 void qht_statistics_init(struct qht *ht, struct qht_stats *stats);
 
 /**
- * qht_statistics_destroy - Destroy a struct qht_stats
- * @stats: stuct qht_stats to be destroyed
+ * qht_statistics_destroy - Destroy a &struct qht_stats
+ * @stats: &struct qht_stats to be destroyed
  *
  * See also: qht_statistics_init().
  */
-- 
2.7.4

[Qemu-devel] [PATCH 4/4] qht: fix kernel-doc markup in qht.h

[Emilio G. Cota]

While at it, s/stuct/struct/.

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 include/qemu/qht.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/qemu/qht.h b/include/qemu/qht.h
index 56c2c77..531aa95 100644
--- a/include/qemu/qht.h
+++ b/include/qemu/qht.h
@@ -166,7 +166,7 @@ void qht_iter(struct qht *ht, qht_iter_func_t func, void *userp);
 /**
  * qht_statistics_init - Gather statistics from a QHT
  * @ht: QHT to gather statistics from
- * @stats: pointer to a struct qht_stats to be filled in
+ * @stats: pointer to a &struct qht_stats to be filled in
  *
  * Does NOT need to be called under an RCU read-critical section,
  * since it does not dereference any pointers stored in the hash table.
@@ -177,8 +177,8 @@ void qht_iter(struct qht *ht, qht_iter_func_t func, void *userp);
 void qht_statistics_init(struct qht *ht, struct qht_stats *stats);
 
 /**
- * qht_statistics_destroy - Destroy a struct qht_stats
- * @stats: stuct qht_stats to be destroyed
+ * qht_statistics_destroy - Destroy a &struct qht_stats
+ * @stats: &struct qht_stats to be destroyed
  *
  * See also: qht_statistics_init().
  */
-- 
2.7.4

Re: [Qemu-trivial] [PATCH 0/4] Some trivial fixes, mostly comment typos

[Emilio G. Cota]

On Wed, Oct 18, 2017 at 18:01:39 -0400, Emilio G. Cota wrote:
> A few trivial fixes that I embedded in a previous (unrelated) patchset.
> Better to submit them separately as a standalone "trivial" patchset.

*ping*

Can someone please pick up patches 1, 3 and 4?

Thanks,

		Emilio

Re: [Qemu-devel] [PATCH 0/4] Some trivial fixes, mostly comment typos

[Emilio G. Cota]

On Wed, Oct 18, 2017 at 18:01:39 -0400, Emilio G. Cota wrote:
> A few trivial fixes that I embedded in a previous (unrelated) patchset.
> Better to submit them separately as a standalone "trivial" patchset.

*ping*

Can someone please pick up patches 1, 3 and 4?

Thanks,

		Emilio