From: Peter Zijlstra <peterz@infradead.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
syzbot
<bot+f99f3a0db9007f4f4e32db54229a240c4fe57c15@syzkaller.appspotmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
jlayton@redhat.com, LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, npiggin@gmail.com, rgoldwyn@suse.com,
ross.zwisler@linux.intel.com, syzkaller-bugs@googlegroups.com,
Ingo Molnar <mingo@redhat.com>,
kernel-team@lge.com
Subject: Re: possible deadlock in generic_file_write_iter
Date: Tue, 7 Nov 2017 09:11:43 +0100 [thread overview]
Message-ID: <20171107081143.GD3326@worktop> (raw)
In-Reply-To: <20171107005442.GA1405@X58A-UD3R>
On Tue, Nov 07, 2017 at 09:54:42AM +0900, Byungchul Park wrote:
> > The best I could come up with is something like the below; its not
> > at all pretty and I could see people objecting; least of all myself for
> > the __complete() thing, but I ran out of creative naming juice.
>
> Patches assigning a lock_class per gendisk were already applied in tip.
> I believe that solves this.
>
> e319e1fbd9d42420ab6eec0bfd75eb9ad7ca63b1
> block, locking/lockdep: Assign a lock_class per gendisk used for
> wait_for_completion()
>
> I think the following proposal makes kernel too hacky.
Ah, I tough this was with those included...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
syzbot
<bot+f99f3a0db9007f4f4e32db54229a240c4fe57c15@syzkaller.appspotmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
jlayton@redhat.com, LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, npiggin@gmail.com, rgoldwyn@suse.com,
ross.zwisler@linux.intel.com, syzkaller-bugs@googlegroups.com,
Ingo Molnar <mingo@redhat.com>,
kernel-team@lge.com
Subject: Re: possible deadlock in generic_file_write_iter
Date: Tue, 7 Nov 2017 09:11:43 +0100 [thread overview]
Message-ID: <20171107081143.GD3326@worktop> (raw)
In-Reply-To: <20171107005442.GA1405@X58A-UD3R>
On Tue, Nov 07, 2017 at 09:54:42AM +0900, Byungchul Park wrote:
> > The best I could come up with is something like the below; its not
> > at all pretty and I could see people objecting; least of all myself for
> > the __complete() thing, but I ran out of creative naming juice.
>
> Patches assigning a lock_class per gendisk were already applied in tip.
> I believe that solves this.
>
> e319e1fbd9d42420ab6eec0bfd75eb9ad7ca63b1
> block, locking/lockdep: Assign a lock_class per gendisk used for
> wait_for_completion()
>
> I think the following proposal makes kernel too hacky.
Ah, I tough this was with those included...
next prev parent reply other threads:[~2017-11-07 8:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 10:25 possible deadlock in generic_file_write_iter syzbot
2017-11-05 10:39 ` Dmitry Vyukov
2017-11-05 10:39 ` Dmitry Vyukov
2017-11-06 3:29 ` Al Viro
2017-11-06 3:29 ` Al Viro
2017-11-06 6:32 ` Dmitry Vyukov
2017-11-06 6:32 ` Dmitry Vyukov
2017-11-06 13:15 ` Jan Kara
2017-11-06 13:15 ` Jan Kara
2017-11-06 13:33 ` Al Viro
2017-11-06 13:33 ` Al Viro
2017-11-06 13:35 ` Dmitry Vyukov
2017-11-06 13:35 ` Dmitry Vyukov
2017-11-06 16:01 ` Peter Zijlstra
2017-11-06 16:01 ` Peter Zijlstra
2017-11-06 17:36 ` Christoph Hellwig
2017-11-06 17:36 ` Christoph Hellwig
2017-11-06 23:45 ` Matthew Wilcox
2017-11-06 23:45 ` Matthew Wilcox
2017-11-07 0:54 ` Byungchul Park
2017-11-07 0:54 ` Byungchul Park
2017-11-07 8:11 ` Peter Zijlstra [this message]
2017-11-07 8:11 ` Peter Zijlstra
2017-11-07 8:18 ` Dmitry Vyukov
2017-11-07 8:18 ` Dmitry Vyukov
2017-11-07 8:30 ` Byungchul Park
2017-11-07 8:30 ` Byungchul Park
2017-11-07 8:31 ` Dmitry Vyukov
2017-11-07 8:31 ` Dmitry Vyukov
2017-11-07 8:42 ` Byungchul Park
2017-11-07 8:42 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107081143.GD3326@worktop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bot+f99f3a0db9007f4f4e32db54229a240c4fe57c15@syzkaller.appspotmail.com \
--cc=byungchul.park@lge.com \
--cc=dvyukov@google.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=jlayton@redhat.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=npiggin@gmail.com \
--cc=rgoldwyn@suse.com \
--cc=ross.zwisler@linux.intel.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.