From: James Hogan <james.hogan@mips.com>
To: "Steven J. Hill" <steven.hill@cavium.com>
Cc: <linux-mips@linux-mips.org>, <ralf@linux-mips.org>
Subject: Re: [PATCH v2 05/12] MIPS: Octeon: Header and file cleaning.
Date: Tue, 7 Nov 2017 16:11:57 +0000 [thread overview]
Message-ID: <20171107161157.GI15260@jhogan-linux> (raw)
In-Reply-To: <1506620053-2557-6-git-send-email-steven.hill@cavium.com>
[-- Attachment #1: Type: text/plain, Size: 6903 bytes --]
Hi Steven,
On Thu, Sep 28, 2017 at 12:34:06PM -0500, Steven J. Hill wrote:
> From: "Steven J. Hill" <Steven.Hill@cavium.com>
>
> In preparation for new hotplug CPU, some housekeeping:
>
> * Clean-up header file dependencies, specifically move inclusion
> of some headers to only the files that need them.
> * Remove usage of arch/mips/cavium-octeon/octeon_boot.h
> * Clean-ups from checkpatch in arch/mips/cavium-octeon/setup.c
> * Add defining of NR_IRQS_LEGACY for completeness.
> * Move CVMX_TMP_STR macros from top level to cvmx-asm.h
> * Update some copyright dates.
> * Add some missing register include files to top level.
>
> Signed-off-by: Steven J. Hill <steven.hill@cavium.com>
> Acked-by: David Daney <david.daney@cavium.com>
This causes a whole pile of build errors. First this, the include of
which is visible in the context of your patch:
arch/mips/cavium-octeon/smp.c:25:25: fatal error: octeon_boot.h: No such file or directory
#include "octeon_boot.h"
^
and removing that include, all these too:
arch/mips/cavium-octeon/smp.c: In function ‘octeon_smp_hotplug_setup’:
arch/mips/cavium-octeon/smp.c:121:85: error: ‘LABI_ADDR_IN_BOOTLOADER’ undeclared (first use in this function)
labi = (struct linux_app_boot_info *)PHYS_TO_XKSEG_CACHED(LABI_ADDR_IN_BOOTLOADER);
^
arch/mips/cavium-octeon/smp.c:121:85: note: each undeclared identifier is reported only once for each function it appears in
arch/mips/cavium-octeon/smp.c:122:10: error: dereferencing pointer to incomplete type
if (labi->labi_signature != LABI_SIGNATURE) {
^
arch/mips/cavium-octeon/smp.c:122:30: error: ‘LABI_SIGNATURE’ undeclared (first use in this function)
if (labi->labi_signature != LABI_SIGNATURE) {
^
arch/mips/cavium-octeon/smp.c:127:37: error: dereferencing pointer to incomplete type
octeon_bootloader_entry_addr = labi->InitTLBStart_addr;
^
arch/mips/cavium-octeon/smp.c: In function ‘octeon_smp_setup’:
arch/mips/cavium-octeon/smp.c:136:9: error: implicit declaration of function ‘cvmx_sysinfo_get’ [-Werror=implicit-function-declaration]
struct cvmx_sysinfo *sysinfo = cvmx_sysinfo_get();
^
arch/mips/cavium-octeon/smp.c:136:33: error: initialization makes pointer from integer without a cast [-Werror]
struct cvmx_sysinfo *sysinfo = cvmx_sysinfo_get();
^
arch/mips/cavium-octeon/smp.c:155:3: error: implicit declaration of function ‘cvmx_coremask_is_core_set’ [-Werror=implicit-function-declaration]
if ((id != coreid) && cvmx_coremask_is_core_set(&sysinfo->core_mask, id)) {
^
arch/mips/cavium-octeon/smp.c:155:59: error: dereferencing pointer to incomplete type
if ((id != coreid) && cvmx_coremask_is_core_set(&sysinfo->core_mask, id)) {
^
arch/mips/cavium-octeon/smp.c: In function ‘plat_post_relocation’:
arch/mips/cavium-octeon/smp.c:188:39: error: ‘kernel_entry’ undeclared (first use in this function)
unsigned long entry = (unsigned long)kernel_entry;
^
arch/mips/cavium-octeon/smp.c: In function ‘octeon_cpu_die’:
arch/mips/cavium-octeon/smp.c:317:45: error: ‘LINUX_APP_BOOT_BLOCK_NAME’ undeclared (first use in this function)
block_desc = cvmx_bootmem_find_named_block(LINUX_APP_BOOT_BLOCK_NAME);
^
arch/mips/cavium-octeon/smp.c:322:86: error: ‘LABI_ADDR_IN_BOOTLOADER’ undeclared (first use in this function)
labi = (struct linux_app_boot_info *)PHYS_TO_XKSEG_CACHED(LABI_ADDR_IN_BOOTLOADER);
^
arch/mips/cavium-octeon/smp.c:324:7: error: dereferencing pointer to incomplete type
labi->avail_coremask |= mask;
^
arch/mips/cavium-octeon/smp.c:325:18: error: dereferencing pointer to incomplete type
new_mask = labi->avail_coremask;
^
arch/mips/cavium-octeon/smp.c:327:99: error: ‘AVAIL_COREMASK_OFFSET_IN_LINUX_APP_BOOT_BLOCK’ undeclared (first use in this function)
uint32_t *p = (uint32_t *)PHYS_TO_XKSEG_CACHED(block_desc->base_addr +
^
arch/mips/cavium-octeon/smp.c: In function ‘start_after_reset’:
arch/mips/cavium-octeon/smp.c:355:2: error: implicit declaration of function ‘kernel_entry’ [-Werror=implicit-function-declaration]
kernel_entry(0, 0, 0); /* set a2 = 0 for secondary core */
^
arch/mips/cavium-octeon/smp.c: In function ‘octeon_update_boot_vector’:
arch/mips/cavium-octeon/smp.c:365:76: error: ‘BOOTLOADER_BOOT_VECTOR’ undeclared (first use in this function)
(struct boot_init_vector *)PHYS_TO_XKSEG_CACHED(BOOTLOADER_BOOT_VECTOR);
^
arch/mips/cavium-octeon/smp.c:367:45: error: ‘LINUX_APP_BOOT_BLOCK_NAME’ undeclared (first use in this function)
block_desc = cvmx_bootmem_find_named_block(LINUX_APP_BOOT_BLOCK_NAME);
^
arch/mips/cavium-octeon/smp.c:372:86: error: ‘LABI_ADDR_IN_BOOTLOADER’ undeclared (first use in this function)
labi = (struct linux_app_boot_info *)PHYS_TO_XKSEG_CACHED(LABI_ADDR_IN_BOOTLOADER);
^
arch/mips/cavium-octeon/smp.c:374:24: error: dereferencing pointer to incomplete type
avail_coremask = labi->avail_coremask;
^
arch/mips/cavium-octeon/smp.c:375:7: error: dereferencing pointer to incomplete type
labi->avail_coremask &= ~(1 << coreid);
^
arch/mips/cavium-octeon/smp.c:377:103: error: ‘AVAIL_COREMASK_OFFSET_IN_LINUX_APP_BOOT_BLOCK’ undeclared (first use in this function)
avail_coremask = *(uint32_t *)PHYS_TO_XKSEG_CACHED(
^
arch/mips/cavium-octeon/smp.c:387:2: error: invalid use of undefined type ‘struct boot_init_vector’
boot_vect[coreid].app_start_func_addr =
^
arch/mips/cavium-octeon/smp.c:387:11: error: dereferencing pointer to incomplete type
boot_vect[coreid].app_start_func_addr =
^
arch/mips/cavium-octeon/smp.c:389:2: error: invalid use of undefined type ‘struct boot_init_vector’
boot_vect[coreid].code_addr = octeon_bootloader_entry_addr;
^
arch/mips/cavium-octeon/smp.c:389:11: error: dereferencing pointer to incomplete type
boot_vect[coreid].code_addr = octeon_bootloader_entry_addr;
^
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@mips.com>
To: "Steven J. Hill" <steven.hill@cavium.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH v2 05/12] MIPS: Octeon: Header and file cleaning.
Date: Tue, 7 Nov 2017 16:11:57 +0000 [thread overview]
Message-ID: <20171107161157.GI15260@jhogan-linux> (raw)
Message-ID: <20171107161157.KXT-fPF10vJhbpuL3m9Yq-ay03B1QGu4iLtBFLSCYqM@z> (raw)
In-Reply-To: <1506620053-2557-6-git-send-email-steven.hill@cavium.com>
[-- Attachment #1: Type: text/plain, Size: 6903 bytes --]
Hi Steven,
On Thu, Sep 28, 2017 at 12:34:06PM -0500, Steven J. Hill wrote:
> From: "Steven J. Hill" <Steven.Hill@cavium.com>
>
> In preparation for new hotplug CPU, some housekeeping:
>
> * Clean-up header file dependencies, specifically move inclusion
> of some headers to only the files that need them.
> * Remove usage of arch/mips/cavium-octeon/octeon_boot.h
> * Clean-ups from checkpatch in arch/mips/cavium-octeon/setup.c
> * Add defining of NR_IRQS_LEGACY for completeness.
> * Move CVMX_TMP_STR macros from top level to cvmx-asm.h
> * Update some copyright dates.
> * Add some missing register include files to top level.
>
> Signed-off-by: Steven J. Hill <steven.hill@cavium.com>
> Acked-by: David Daney <david.daney@cavium.com>
This causes a whole pile of build errors. First this, the include of
which is visible in the context of your patch:
arch/mips/cavium-octeon/smp.c:25:25: fatal error: octeon_boot.h: No such file or directory
#include "octeon_boot.h"
^
and removing that include, all these too:
arch/mips/cavium-octeon/smp.c: In function ‘octeon_smp_hotplug_setup’:
arch/mips/cavium-octeon/smp.c:121:85: error: ‘LABI_ADDR_IN_BOOTLOADER’ undeclared (first use in this function)
labi = (struct linux_app_boot_info *)PHYS_TO_XKSEG_CACHED(LABI_ADDR_IN_BOOTLOADER);
^
arch/mips/cavium-octeon/smp.c:121:85: note: each undeclared identifier is reported only once for each function it appears in
arch/mips/cavium-octeon/smp.c:122:10: error: dereferencing pointer to incomplete type
if (labi->labi_signature != LABI_SIGNATURE) {
^
arch/mips/cavium-octeon/smp.c:122:30: error: ‘LABI_SIGNATURE’ undeclared (first use in this function)
if (labi->labi_signature != LABI_SIGNATURE) {
^
arch/mips/cavium-octeon/smp.c:127:37: error: dereferencing pointer to incomplete type
octeon_bootloader_entry_addr = labi->InitTLBStart_addr;
^
arch/mips/cavium-octeon/smp.c: In function ‘octeon_smp_setup’:
arch/mips/cavium-octeon/smp.c:136:9: error: implicit declaration of function ‘cvmx_sysinfo_get’ [-Werror=implicit-function-declaration]
struct cvmx_sysinfo *sysinfo = cvmx_sysinfo_get();
^
arch/mips/cavium-octeon/smp.c:136:33: error: initialization makes pointer from integer without a cast [-Werror]
struct cvmx_sysinfo *sysinfo = cvmx_sysinfo_get();
^
arch/mips/cavium-octeon/smp.c:155:3: error: implicit declaration of function ‘cvmx_coremask_is_core_set’ [-Werror=implicit-function-declaration]
if ((id != coreid) && cvmx_coremask_is_core_set(&sysinfo->core_mask, id)) {
^
arch/mips/cavium-octeon/smp.c:155:59: error: dereferencing pointer to incomplete type
if ((id != coreid) && cvmx_coremask_is_core_set(&sysinfo->core_mask, id)) {
^
arch/mips/cavium-octeon/smp.c: In function ‘plat_post_relocation’:
arch/mips/cavium-octeon/smp.c:188:39: error: ‘kernel_entry’ undeclared (first use in this function)
unsigned long entry = (unsigned long)kernel_entry;
^
arch/mips/cavium-octeon/smp.c: In function ‘octeon_cpu_die’:
arch/mips/cavium-octeon/smp.c:317:45: error: ‘LINUX_APP_BOOT_BLOCK_NAME’ undeclared (first use in this function)
block_desc = cvmx_bootmem_find_named_block(LINUX_APP_BOOT_BLOCK_NAME);
^
arch/mips/cavium-octeon/smp.c:322:86: error: ‘LABI_ADDR_IN_BOOTLOADER’ undeclared (first use in this function)
labi = (struct linux_app_boot_info *)PHYS_TO_XKSEG_CACHED(LABI_ADDR_IN_BOOTLOADER);
^
arch/mips/cavium-octeon/smp.c:324:7: error: dereferencing pointer to incomplete type
labi->avail_coremask |= mask;
^
arch/mips/cavium-octeon/smp.c:325:18: error: dereferencing pointer to incomplete type
new_mask = labi->avail_coremask;
^
arch/mips/cavium-octeon/smp.c:327:99: error: ‘AVAIL_COREMASK_OFFSET_IN_LINUX_APP_BOOT_BLOCK’ undeclared (first use in this function)
uint32_t *p = (uint32_t *)PHYS_TO_XKSEG_CACHED(block_desc->base_addr +
^
arch/mips/cavium-octeon/smp.c: In function ‘start_after_reset’:
arch/mips/cavium-octeon/smp.c:355:2: error: implicit declaration of function ‘kernel_entry’ [-Werror=implicit-function-declaration]
kernel_entry(0, 0, 0); /* set a2 = 0 for secondary core */
^
arch/mips/cavium-octeon/smp.c: In function ‘octeon_update_boot_vector’:
arch/mips/cavium-octeon/smp.c:365:76: error: ‘BOOTLOADER_BOOT_VECTOR’ undeclared (first use in this function)
(struct boot_init_vector *)PHYS_TO_XKSEG_CACHED(BOOTLOADER_BOOT_VECTOR);
^
arch/mips/cavium-octeon/smp.c:367:45: error: ‘LINUX_APP_BOOT_BLOCK_NAME’ undeclared (first use in this function)
block_desc = cvmx_bootmem_find_named_block(LINUX_APP_BOOT_BLOCK_NAME);
^
arch/mips/cavium-octeon/smp.c:372:86: error: ‘LABI_ADDR_IN_BOOTLOADER’ undeclared (first use in this function)
labi = (struct linux_app_boot_info *)PHYS_TO_XKSEG_CACHED(LABI_ADDR_IN_BOOTLOADER);
^
arch/mips/cavium-octeon/smp.c:374:24: error: dereferencing pointer to incomplete type
avail_coremask = labi->avail_coremask;
^
arch/mips/cavium-octeon/smp.c:375:7: error: dereferencing pointer to incomplete type
labi->avail_coremask &= ~(1 << coreid);
^
arch/mips/cavium-octeon/smp.c:377:103: error: ‘AVAIL_COREMASK_OFFSET_IN_LINUX_APP_BOOT_BLOCK’ undeclared (first use in this function)
avail_coremask = *(uint32_t *)PHYS_TO_XKSEG_CACHED(
^
arch/mips/cavium-octeon/smp.c:387:2: error: invalid use of undefined type ‘struct boot_init_vector’
boot_vect[coreid].app_start_func_addr =
^
arch/mips/cavium-octeon/smp.c:387:11: error: dereferencing pointer to incomplete type
boot_vect[coreid].app_start_func_addr =
^
arch/mips/cavium-octeon/smp.c:389:2: error: invalid use of undefined type ‘struct boot_init_vector’
boot_vect[coreid].code_addr = octeon_bootloader_entry_addr;
^
arch/mips/cavium-octeon/smp.c:389:11: error: dereferencing pointer to incomplete type
boot_vect[coreid].code_addr = octeon_bootloader_entry_addr;
^
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-07 16:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 17:34 [PATCH v2 00/12] Add Octeon Hotplug CPU Support Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 01/12] MIPS: Add nudges to writes for bit unlocks Steven J. Hill
2017-09-29 20:54 ` James Hogan
2017-09-29 20:54 ` James Hogan
2017-09-28 17:34 ` [PATCH v2 02/12] MIPS: Remove unused variable 'lastpfn' Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 03/12] MIPS: Allow __cpu_number_map to be larger than NR_CPUS Steven J. Hill
2017-11-07 18:29 ` James Hogan
2017-11-07 18:29 ` James Hogan
2017-09-28 17:34 ` [PATCH v2 04/12] MIPS: Octeon: Remove usage of cvmx_wait() everywhere Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 05/12] MIPS: Octeon: Header and file cleaning Steven J. Hill
2017-11-07 16:11 ` James Hogan [this message]
2017-11-07 16:11 ` James Hogan
2017-11-07 18:52 ` Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 06/12] MIPS: Octeon: Update CIU_FUSE registers Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 07/12] MIPS: Octeon: Add Octeon III platforms for console output Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 08/12] MIPS: Octeon: Remove crufty KEXEC and CRASH_DUMP code Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 09/12] MIPS: Octeon: Populate kernel memory from cvmx_bootmem named blocks Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 10/12] MIPS: Add the concept of BOOT_MEM_KERNEL to boot_mem_map Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 11/12] MIPS: Add define for number of bits in MMUSizeExt field Steven J. Hill
2017-09-28 17:34 ` [PATCH v2 12/12] MIPS: Octeon: Add working hotplug CPU support Steven J. Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107161157.GI15260@jhogan-linux \
--to=james.hogan@mips.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=steven.hill@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.