From: James Hogan <james.hogan@mips.com>
To: Mirko Parthey <mirko.parthey@web.de>
Cc: "Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: BCM47XX: Fix LED inversion for WRT54GSv1
Date: Tue, 7 Nov 2017 22:52:16 +0000 [thread overview]
Message-ID: <20171107225215.GN15260@jhogan-linux> (raw)
In-Reply-To: <20170518193002.GA8186@guitar.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
On Thu, May 18, 2017 at 09:30:03PM +0200, Mirko Parthey wrote:
> The WLAN LED on the Linksys WRT54GSv1 is active low, but the software
> treats it as active high. Fix the inverted logic.
>
> Signed-off-by: Mirko Parthey <mirko.parthey@web.de>
Thanks, applied for 4.15.
Cheers
James
> ---
> arch/mips/bcm47xx/leds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/bcm47xx/leds.c b/arch/mips/bcm47xx/leds.c
> index a35f1d5cde9f..08ad23c492e7 100644
> --- a/arch/mips/bcm47xx/leds.c
> +++ b/arch/mips/bcm47xx/leds.c
> @@ -330,7 +330,7 @@ bcm47xx_leds_linksys_wrt54g3gv2[] __initconst = {
> /* Verified on: WRT54GS V1.0 */
> static const struct gpio_led
> bcm47xx_leds_linksys_wrt54g_type_0101[] __initconst = {
> - BCM47XX_GPIO_LED(0, "green", "wlan", 0, LEDS_GPIO_DEFSTATE_OFF),
> + BCM47XX_GPIO_LED(0, "green", "wlan", 1, LEDS_GPIO_DEFSTATE_OFF),
> BCM47XX_GPIO_LED(1, "green", "power", 0, LEDS_GPIO_DEFSTATE_ON),
> BCM47XX_GPIO_LED(7, "green", "dmz", 1, LEDS_GPIO_DEFSTATE_OFF),
> };
> --
> 2.1.4
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-07 22:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 19:30 [PATCH] MIPS: BCM47XX: Fix LED inversion for WRT54GSv1 Mirko Parthey
2017-05-22 5:38 ` Rafał Miłecki
2017-11-07 22:52 ` James Hogan [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-05-17 22:14 Mirko Parthey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107225215.GN15260@jhogan-linux \
--to=james.hogan@mips.com \
--cc=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=mirko.parthey@web.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.