* [PATCH] MIPS: BCM47XX: Fix LED inversion for WRT54GSv1
@ 2017-05-18 19:30 Mirko Parthey
2017-05-22 5:38 ` Rafał Miłecki
2017-11-07 22:52 ` James Hogan
0 siblings, 2 replies; 4+ messages in thread
From: Mirko Parthey @ 2017-05-18 19:30 UTC (permalink / raw)
To: Hauke Mehrtens, Rafał Miłecki; +Cc: linux-mips
The WLAN LED on the Linksys WRT54GSv1 is active low, but the software
treats it as active high. Fix the inverted logic.
Signed-off-by: Mirko Parthey <mirko.parthey@web.de>
---
arch/mips/bcm47xx/leds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/bcm47xx/leds.c b/arch/mips/bcm47xx/leds.c
index a35f1d5cde9f..08ad23c492e7 100644
--- a/arch/mips/bcm47xx/leds.c
+++ b/arch/mips/bcm47xx/leds.c
@@ -330,7 +330,7 @@ bcm47xx_leds_linksys_wrt54g3gv2[] __initconst = {
/* Verified on: WRT54GS V1.0 */
static const struct gpio_led
bcm47xx_leds_linksys_wrt54g_type_0101[] __initconst = {
- BCM47XX_GPIO_LED(0, "green", "wlan", 0, LEDS_GPIO_DEFSTATE_OFF),
+ BCM47XX_GPIO_LED(0, "green", "wlan", 1, LEDS_GPIO_DEFSTATE_OFF),
BCM47XX_GPIO_LED(1, "green", "power", 0, LEDS_GPIO_DEFSTATE_ON),
BCM47XX_GPIO_LED(7, "green", "dmz", 1, LEDS_GPIO_DEFSTATE_OFF),
};
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: BCM47XX: Fix LED inversion for WRT54GSv1
2017-05-18 19:30 [PATCH] MIPS: BCM47XX: Fix LED inversion for WRT54GSv1 Mirko Parthey
@ 2017-05-22 5:38 ` Rafał Miłecki
2017-11-07 22:52 ` James Hogan
1 sibling, 0 replies; 4+ messages in thread
From: Rafał Miłecki @ 2017-05-22 5:38 UTC (permalink / raw)
To: Mirko Parthey; +Cc: Hauke Mehrtens, linux-mips@linux-mips.org
On 18 May 2017 at 21:30, Mirko Parthey <mirko.parthey@web.de> wrote:
> The WLAN LED on the Linksys WRT54GSv1 is active low, but the software
> treats it as active high. Fix the inverted logic.
>
> Signed-off-by: Mirko Parthey <mirko.parthey@web.de>
Looks OK, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: BCM47XX: Fix LED inversion for WRT54GSv1
2017-05-18 19:30 [PATCH] MIPS: BCM47XX: Fix LED inversion for WRT54GSv1 Mirko Parthey
2017-05-22 5:38 ` Rafał Miłecki
@ 2017-11-07 22:52 ` James Hogan
1 sibling, 0 replies; 4+ messages in thread
From: James Hogan @ 2017-11-07 22:52 UTC (permalink / raw)
To: Mirko Parthey; +Cc: Hauke Mehrtens, Rafał Miłecki, linux-mips
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
On Thu, May 18, 2017 at 09:30:03PM +0200, Mirko Parthey wrote:
> The WLAN LED on the Linksys WRT54GSv1 is active low, but the software
> treats it as active high. Fix the inverted logic.
>
> Signed-off-by: Mirko Parthey <mirko.parthey@web.de>
Thanks, applied for 4.15.
Cheers
James
> ---
> arch/mips/bcm47xx/leds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/bcm47xx/leds.c b/arch/mips/bcm47xx/leds.c
> index a35f1d5cde9f..08ad23c492e7 100644
> --- a/arch/mips/bcm47xx/leds.c
> +++ b/arch/mips/bcm47xx/leds.c
> @@ -330,7 +330,7 @@ bcm47xx_leds_linksys_wrt54g3gv2[] __initconst = {
> /* Verified on: WRT54GS V1.0 */
> static const struct gpio_led
> bcm47xx_leds_linksys_wrt54g_type_0101[] __initconst = {
> - BCM47XX_GPIO_LED(0, "green", "wlan", 0, LEDS_GPIO_DEFSTATE_OFF),
> + BCM47XX_GPIO_LED(0, "green", "wlan", 1, LEDS_GPIO_DEFSTATE_OFF),
> BCM47XX_GPIO_LED(1, "green", "power", 0, LEDS_GPIO_DEFSTATE_ON),
> BCM47XX_GPIO_LED(7, "green", "dmz", 1, LEDS_GPIO_DEFSTATE_OFF),
> };
> --
> 2.1.4
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] MIPS: BCM47XX: Fix LED inversion for WRT54GSv1
@ 2017-05-17 22:14 Mirko Parthey
0 siblings, 0 replies; 4+ messages in thread
From: Mirko Parthey @ 2017-05-17 22:14 UTC (permalink / raw)
To: Hauke Mehrtens, Rafał Miłecki; +Cc: linux-mips
The WLAN LED on the Linksys WRT54GSv1 is active low, but the software
treats it as active high. Fix the inverted logic.
---
arch/mips/bcm47xx/leds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/bcm47xx/leds.c b/arch/mips/bcm47xx/leds.c
index a35f1d5cde9f..08ad23c492e7 100644
--- a/arch/mips/bcm47xx/leds.c
+++ b/arch/mips/bcm47xx/leds.c
@@ -330,7 +330,7 @@ bcm47xx_leds_linksys_wrt54g3gv2[] __initconst = {
/* Verified on: WRT54GS V1.0 */
static const struct gpio_led
bcm47xx_leds_linksys_wrt54g_type_0101[] __initconst = {
- BCM47XX_GPIO_LED(0, "green", "wlan", 0, LEDS_GPIO_DEFSTATE_OFF),
+ BCM47XX_GPIO_LED(0, "green", "wlan", 1, LEDS_GPIO_DEFSTATE_OFF),
BCM47XX_GPIO_LED(1, "green", "power", 0, LEDS_GPIO_DEFSTATE_ON),
BCM47XX_GPIO_LED(7, "green", "dmz", 1, LEDS_GPIO_DEFSTATE_OFF),
};
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-07 22:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-18 19:30 [PATCH] MIPS: BCM47XX: Fix LED inversion for WRT54GSv1 Mirko Parthey
2017-05-22 5:38 ` Rafał Miłecki
2017-11-07 22:52 ` James Hogan
-- strict thread matches above, loose matches on Subject: below --
2017-05-17 22:14 Mirko Parthey
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.