From: Vinod Koul <vinod.koul@intel.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
dmaengine@vger.kernel.org, timur@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dmaengine: qcom_hidma: add support for the new revision
Date: Wed, 8 Nov 2017 11:17:59 +0530 [thread overview]
Message-ID: <20171108054759.GN3187@localhost> (raw)
In-Reply-To: <1733d997-6f3a-459a-b14f-b29823c3a8af@codeaurora.org>
On Mon, Nov 06, 2017 at 05:09:29PM -0500, Sinan Kaya wrote:
> On 11/6/2017 1:15 PM, Sinan Kaya wrote:
> > On 11/6/2017 1:03 PM, Robin Murphy wrote:
> >>> #ifdef CONFIG_ACPI
> >>> ret = strcmp(acpi_device_hid(adev), "QCOM8062");
> >>> + if (ret)
> >>> + ret = strcmp(acpi_device_hid(adev), "QCOM8063");
> >> This string-juggling looks to have already hit the point at which it
> >> doesn't scale well - it would be a lot nicer to make use of
> >> of_device_get_match_data() and the ACPI equivalent to abstract the
> >> version-specific data appropriately.
> >
> > Sure, let me do some research.
> >
>
> I just wanted to double check here.
>
> This is what I can do:
> 1. Maintain different match tables for different driver capabilities.
> 2. Instead of doing open-coded strcmp, I can do match against different tables
> using acpi_match_device/of_match_device.
>
> Hope this works for you.
Sounds better to me. You should have common match where capabilities are
same.
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] dmaengine: qcom_hidma: add support for the new revision
Date: Wed, 8 Nov 2017 11:17:59 +0530 [thread overview]
Message-ID: <20171108054759.GN3187@localhost> (raw)
In-Reply-To: <1733d997-6f3a-459a-b14f-b29823c3a8af@codeaurora.org>
On Mon, Nov 06, 2017 at 05:09:29PM -0500, Sinan Kaya wrote:
> On 11/6/2017 1:15 PM, Sinan Kaya wrote:
> > On 11/6/2017 1:03 PM, Robin Murphy wrote:
> >>> #ifdef CONFIG_ACPI
> >>> ret = strcmp(acpi_device_hid(adev), "QCOM8062");
> >>> + if (ret)
> >>> + ret = strcmp(acpi_device_hid(adev), "QCOM8063");
> >> This string-juggling looks to have already hit the point at which it
> >> doesn't scale well - it would be a lot nicer to make use of
> >> of_device_get_match_data() and the ACPI equivalent to abstract the
> >> version-specific data appropriately.
> >
> > Sure, let me do some research.
> >
>
> I just wanted to double check here.
>
> This is what I can do:
> 1. Maintain different match tables for different driver capabilities.
> 2. Instead of doing open-coded strcmp, I can do match against different tables
> using acpi_match_device/of_match_device.
>
> Hope this works for you.
Sounds better to me. You should have common match where capabilities are
same.
--
~Vinod
next prev parent reply other threads:[~2017-11-08 5:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 17:26 [PATCH 1/3] Documentation: DT: qcom_hidma: bump HW revision for the bugfixed HW Sinan Kaya
2017-11-06 17:26 ` Sinan Kaya
2017-11-06 17:26 ` [PATCH 2/3] dmaengine: qcom_hidma: add support for the new revision Sinan Kaya
2017-11-06 17:26 ` Sinan Kaya
2017-11-06 17:26 ` Sinan Kaya
2017-11-06 18:03 ` Robin Murphy
2017-11-06 18:03 ` Robin Murphy
2017-11-06 18:15 ` Sinan Kaya
2017-11-06 18:15 ` Sinan Kaya
2017-11-06 22:09 ` Sinan Kaya
2017-11-06 22:09 ` Sinan Kaya
2017-11-08 5:47 ` Vinod Koul [this message]
2017-11-08 5:47 ` Vinod Koul
2017-11-06 17:26 ` [PATCH 3/3] dmaengine: qcom_hidma: add identity register support Sinan Kaya
2017-11-06 17:26 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108054759.GN3187@localhost \
--to=vinod.koul@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.