* [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver @ 2017-11-07 20:13 ` Corentin Labbe 0 siblings, 0 replies; 15+ messages in thread From: Corentin Labbe @ 2017-11-07 20:13 UTC (permalink / raw) To: linux-arm-kernel The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree. Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> Reviewed-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 19acae1b4089..68e5135410ec 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -336,6 +336,14 @@ #interrupt-cells = <3>; #gpio-cells = <3>; + emac_rgmii_pins: emac-rgmii-pins { + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", + "PD11", "PD12", "PD13", "PD14", "PD18", + "PD19", "PD21", "PD22", "PD23"; + function = "gmac"; + drive-strength = <40>; + }; + mmc0_pins: mmc0-pins { pins = "PF0", "PF1", "PF2", "PF3", "PF4", "PF5"; @@ -440,6 +448,27 @@ status = "disabled"; }; + emac: ethernet at 1c30000 { + compatible = "allwinner,sun8i-a83t-emac"; + syscon = <&syscon>; + reg = <0x01c30000 0x104>; + interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "macirq"; + resets = <&ccu 13>; + reset-names = "stmmaceth"; + clocks = <&ccu 27>; + clock-names = "stmmaceth"; + #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + + mdio: mdio { + compatible = "snps,dwmac-mdio"; + #address-cells = <1>; + #size-cells = <0>; + }; + }; + gic: interrupt-controller at 1c81000 { compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic"; reg = <0x01c81000 0x1000>, -- 2.13.6 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver @ 2017-11-07 20:13 ` Corentin Labbe 0 siblings, 0 replies; 15+ messages in thread From: Corentin Labbe @ 2017-11-07 20:13 UTC (permalink / raw) To: robh+dt, mark.rutland, linux, maxime.ripard, wens Cc: devicetree, linux-arm-kernel, linux-kernel, Corentin Labbe The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree. Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> Reviewed-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 19acae1b4089..68e5135410ec 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -336,6 +336,14 @@ #interrupt-cells = <3>; #gpio-cells = <3>; + emac_rgmii_pins: emac-rgmii-pins { + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", + "PD11", "PD12", "PD13", "PD14", "PD18", + "PD19", "PD21", "PD22", "PD23"; + function = "gmac"; + drive-strength = <40>; + }; + mmc0_pins: mmc0-pins { pins = "PF0", "PF1", "PF2", "PF3", "PF4", "PF5"; @@ -440,6 +448,27 @@ status = "disabled"; }; + emac: ethernet@1c30000 { + compatible = "allwinner,sun8i-a83t-emac"; + syscon = <&syscon>; + reg = <0x01c30000 0x104>; + interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "macirq"; + resets = <&ccu 13>; + reset-names = "stmmaceth"; + clocks = <&ccu 27>; + clock-names = "stmmaceth"; + #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + + mdio: mdio { + compatible = "snps,dwmac-mdio"; + #address-cells = <1>; + #size-cells = <0>; + }; + }; + gic: interrupt-controller@1c81000 { compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic"; reg = <0x01c81000 0x1000>, -- 2.13.6 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: sun8i: bananapi-m3: Enable dwmac-sun8i 2017-11-07 20:13 ` Corentin Labbe (?) @ 2017-11-07 20:13 ` Corentin Labbe -1 siblings, 0 replies; 15+ messages in thread From: Corentin Labbe @ 2017-11-07 20:13 UTC (permalink / raw) To: linux-arm-kernel The dwmac-sun8i hardware is present on the bananapi m3 It uses an external PHY rtl8211e via RGMII. This patch create the needed emac and phy nodes. Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts index c606af3dbfed..45bdd5c17829 100644 --- a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts +++ b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts @@ -52,6 +52,7 @@ compatible = "sinovoip,bpi-m3", "allwinner,sun8i-a83t"; aliases { + ethernet0 = &emac; serial0 = &uart0; }; @@ -88,6 +89,23 @@ /* TODO GL830 USB-to-SATA bridge downstream w/ GPIO power controls */ }; +&emac { + pinctrl-names = "default"; + pinctrl-0 = <&emac_rgmii_pins>; + phy-handle = <&ext_rgmii_phy>; + phy-mode = "rgmii"; + allwinner,rx-delay-ps = <700>; + allwinner,tx-delay-ps = <700>; + + status = "okay"; +}; + +&mdio { + ext_rgmii_phy: ethernet-phy at 1 { + reg = <1>; + }; +}; + &mmc0 { pinctrl-names = "default"; pinctrl-0 = <&mmc0_pins>; -- 2.13.6 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: sun8i: bananapi-m3: Enable dwmac-sun8i @ 2017-11-07 20:13 ` Corentin Labbe 0 siblings, 0 replies; 15+ messages in thread From: Corentin Labbe @ 2017-11-07 20:13 UTC (permalink / raw) To: robh+dt, mark.rutland, linux, maxime.ripard, wens Cc: devicetree, linux-arm-kernel, linux-kernel, Corentin Labbe The dwmac-sun8i hardware is present on the bananapi m3 It uses an external PHY rtl8211e via RGMII. This patch create the needed emac and phy nodes. Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts index c606af3dbfed..45bdd5c17829 100644 --- a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts +++ b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts @@ -52,6 +52,7 @@ compatible = "sinovoip,bpi-m3", "allwinner,sun8i-a83t"; aliases { + ethernet0 = &emac; serial0 = &uart0; }; @@ -88,6 +89,23 @@ /* TODO GL830 USB-to-SATA bridge downstream w/ GPIO power controls */ }; +&emac { + pinctrl-names = "default"; + pinctrl-0 = <&emac_rgmii_pins>; + phy-handle = <&ext_rgmii_phy>; + phy-mode = "rgmii"; + allwinner,rx-delay-ps = <700>; + allwinner,tx-delay-ps = <700>; + + status = "okay"; +}; + +&mdio { + ext_rgmii_phy: ethernet-phy@1 { + reg = <1>; + }; +}; + &mmc0 { pinctrl-names = "default"; pinctrl-0 = <&mmc0_pins>; -- 2.13.6 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: sun8i: bananapi-m3: Enable dwmac-sun8i @ 2017-11-07 20:13 ` Corentin Labbe 0 siblings, 0 replies; 15+ messages in thread From: Corentin Labbe @ 2017-11-07 20:13 UTC (permalink / raw) To: robh+dt, mark.rutland, linux, maxime.ripard, wens Cc: devicetree, Corentin Labbe, linux-kernel, linux-arm-kernel The dwmac-sun8i hardware is present on the bananapi m3 It uses an external PHY rtl8211e via RGMII. This patch create the needed emac and phy nodes. Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts index c606af3dbfed..45bdd5c17829 100644 --- a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts +++ b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts @@ -52,6 +52,7 @@ compatible = "sinovoip,bpi-m3", "allwinner,sun8i-a83t"; aliases { + ethernet0 = &emac; serial0 = &uart0; }; @@ -88,6 +89,23 @@ /* TODO GL830 USB-to-SATA bridge downstream w/ GPIO power controls */ }; +&emac { + pinctrl-names = "default"; + pinctrl-0 = <&emac_rgmii_pins>; + phy-handle = <&ext_rgmii_phy>; + phy-mode = "rgmii"; + allwinner,rx-delay-ps = <700>; + allwinner,tx-delay-ps = <700>; + + status = "okay"; +}; + +&mdio { + ext_rgmii_phy: ethernet-phy@1 { + reg = <1>; + }; +}; + &mmc0 { pinctrl-names = "default"; pinctrl-0 = <&mmc0_pins>; -- 2.13.6 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver 2017-11-07 20:13 ` Corentin Labbe @ 2017-11-08 6:27 ` Chen-Yu Tsai -1 siblings, 0 replies; 15+ messages in thread From: Chen-Yu Tsai @ 2017-11-08 6:27 UTC (permalink / raw) To: linux-arm-kernel On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe <clabbe.montjoie@gmail.com> wrote: > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree. The subject should say "add .... device node", not driver. > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index 19acae1b4089..68e5135410ec 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -336,6 +336,14 @@ > #interrupt-cells = <3>; > #gpio-cells = <3>; > > + emac_rgmii_pins: emac-rgmii-pins { > + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", > + "PD11", "PD12", "PD13", "PD14", "PD18", > + "PD19", "PD21", "PD22", "PD23"; > + function = "gmac"; > + drive-strength = <40>; > + }; > + You should mention this change in your commit log. ChenYu > mmc0_pins: mmc0-pins { > pins = "PF0", "PF1", "PF2", > "PF3", "PF4", "PF5"; > @@ -440,6 +448,27 @@ > status = "disabled"; > }; > > + emac: ethernet at 1c30000 { > + compatible = "allwinner,sun8i-a83t-emac"; > + syscon = <&syscon>; > + reg = <0x01c30000 0x104>; > + interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "macirq"; > + resets = <&ccu 13>; > + reset-names = "stmmaceth"; > + clocks = <&ccu 27>; > + clock-names = "stmmaceth"; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + > + mdio: mdio { > + compatible = "snps,dwmac-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + > gic: interrupt-controller at 1c81000 { > compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic"; > reg = <0x01c81000 0x1000>, > -- > 2.13.6 > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver @ 2017-11-08 6:27 ` Chen-Yu Tsai 0 siblings, 0 replies; 15+ messages in thread From: Chen-Yu Tsai @ 2017-11-08 6:27 UTC (permalink / raw) To: Corentin Labbe Cc: Rob Herring, Mark Rutland, Russell King, Maxime Ripard, Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe <clabbe.montjoie@gmail.com> wrote: > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree. The subject should say "add .... device node", not driver. > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index 19acae1b4089..68e5135410ec 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -336,6 +336,14 @@ > #interrupt-cells = <3>; > #gpio-cells = <3>; > > + emac_rgmii_pins: emac-rgmii-pins { > + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", > + "PD11", "PD12", "PD13", "PD14", "PD18", > + "PD19", "PD21", "PD22", "PD23"; > + function = "gmac"; > + drive-strength = <40>; > + }; > + You should mention this change in your commit log. ChenYu > mmc0_pins: mmc0-pins { > pins = "PF0", "PF1", "PF2", > "PF3", "PF4", "PF5"; > @@ -440,6 +448,27 @@ > status = "disabled"; > }; > > + emac: ethernet@1c30000 { > + compatible = "allwinner,sun8i-a83t-emac"; > + syscon = <&syscon>; > + reg = <0x01c30000 0x104>; > + interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "macirq"; > + resets = <&ccu 13>; > + reset-names = "stmmaceth"; > + clocks = <&ccu 27>; > + clock-names = "stmmaceth"; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + > + mdio: mdio { > + compatible = "snps,dwmac-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + > gic: interrupt-controller@1c81000 { > compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic"; > reg = <0x01c81000 0x1000>, > -- > 2.13.6 > ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver @ 2017-11-08 7:48 ` Maxime Ripard 0 siblings, 0 replies; 15+ messages in thread From: Maxime Ripard @ 2017-11-08 7:48 UTC (permalink / raw) To: linux-arm-kernel On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote: > On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe > <clabbe.montjoie@gmail.com> wrote: > > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. > > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree. > > The subject should say "add .... device node", not driver. > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > > --- > > arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > > index 19acae1b4089..68e5135410ec 100644 > > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > > @@ -336,6 +336,14 @@ > > #interrupt-cells = <3>; > > #gpio-cells = <3>; > > > > + emac_rgmii_pins: emac-rgmii-pins { > > + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", > > + "PD11", "PD12", "PD13", "PD14", "PD18", > > + "PD19", "PD21", "PD22", "PD23"; > > + function = "gmac"; > > + drive-strength = <40>; > > + }; > > + > > You should mention this change in your commit log. And add a comment about why that drive strength is needed. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171108/98b3fb88/attachment.sig> ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver @ 2017-11-08 7:48 ` Maxime Ripard 0 siblings, 0 replies; 15+ messages in thread From: Maxime Ripard @ 2017-11-08 7:48 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Corentin Labbe, Rob Herring, Mark Rutland, Russell King, devicetree, linux-arm-kernel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1677 bytes --] On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote: > On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe > <clabbe.montjoie@gmail.com> wrote: > > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. > > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree. > > The subject should say "add .... device node", not driver. > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > > --- > > arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > > index 19acae1b4089..68e5135410ec 100644 > > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > > @@ -336,6 +336,14 @@ > > #interrupt-cells = <3>; > > #gpio-cells = <3>; > > > > + emac_rgmii_pins: emac-rgmii-pins { > > + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", > > + "PD11", "PD12", "PD13", "PD14", "PD18", > > + "PD19", "PD21", "PD22", "PD23"; > > + function = "gmac"; > > + drive-strength = <40>; > > + }; > > + > > You should mention this change in your commit log. And add a comment about why that drive strength is needed. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver @ 2017-11-08 7:48 ` Maxime Ripard 0 siblings, 0 replies; 15+ messages in thread From: Maxime Ripard @ 2017-11-08 7:48 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Corentin Labbe, Rob Herring, Mark Rutland, Russell King, devicetree, linux-arm-kernel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1757 bytes --] On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote: > On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe > <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. > > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree. > > The subject should say "add .... device node", not driver. > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Reviewed-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> > > --- > > arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > > index 19acae1b4089..68e5135410ec 100644 > > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > > @@ -336,6 +336,14 @@ > > #interrupt-cells = <3>; > > #gpio-cells = <3>; > > > > + emac_rgmii_pins: emac-rgmii-pins { > > + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", > > + "PD11", "PD12", "PD13", "PD14", "PD18", > > + "PD19", "PD21", "PD22", "PD23"; > > + function = "gmac"; > > + drive-strength = <40>; > > + }; > > + > > You should mention this change in your commit log. And add a comment about why that drive strength is needed. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver 2017-11-08 7:48 ` Maxime Ripard @ 2017-11-08 19:30 ` Corentin Labbe -1 siblings, 0 replies; 15+ messages in thread From: Corentin Labbe @ 2017-11-08 19:30 UTC (permalink / raw) To: linux-arm-kernel On Wed, Nov 08, 2017 at 08:48:58AM +0100, Maxime Ripard wrote: > On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote: > > On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe > > <clabbe.montjoie@gmail.com> wrote: > > > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. > > > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree. > > > > The subject should say "add .... device node", not driver. > > > > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > > > --- > > > arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++ > > > 1 file changed, 29 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > > > index 19acae1b4089..68e5135410ec 100644 > > > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > > > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > > > @@ -336,6 +336,14 @@ > > > #interrupt-cells = <3>; > > > #gpio-cells = <3>; > > > > > > + emac_rgmii_pins: emac-rgmii-pins { > > > + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", > > > + "PD11", "PD12", "PD13", "PD14", "PD18", > > > + "PD19", "PD21", "PD22", "PD23"; > > > + function = "gmac"; > > > + drive-strength = <40>; > > > + }; > > > + > > > > You should mention this change in your commit log. > > And add a comment about why that drive strength is needed. > OK I will do it Thanks Regards ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver @ 2017-11-08 19:30 ` Corentin Labbe 0 siblings, 0 replies; 15+ messages in thread From: Corentin Labbe @ 2017-11-08 19:30 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, Russell King, devicetree, linux-arm-kernel, linux-kernel On Wed, Nov 08, 2017 at 08:48:58AM +0100, Maxime Ripard wrote: > On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote: > > On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe > > <clabbe.montjoie@gmail.com> wrote: > > > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. > > > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree. > > > > The subject should say "add .... device node", not driver. > > > > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > > > --- > > > arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++ > > > 1 file changed, 29 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > > > index 19acae1b4089..68e5135410ec 100644 > > > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > > > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > > > @@ -336,6 +336,14 @@ > > > #interrupt-cells = <3>; > > > #gpio-cells = <3>; > > > > > > + emac_rgmii_pins: emac-rgmii-pins { > > > + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", > > > + "PD11", "PD12", "PD13", "PD14", "PD18", > > > + "PD19", "PD21", "PD22", "PD23"; > > > + function = "gmac"; > > > + drive-strength = <40>; > > > + }; > > > + > > > > You should mention this change in your commit log. > > And add a comment about why that drive strength is needed. > OK I will do it Thanks Regards ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver @ 2017-11-08 19:27 ` Corentin Labbe 0 siblings, 0 replies; 15+ messages in thread From: Corentin Labbe @ 2017-11-08 19:27 UTC (permalink / raw) To: linux-arm-kernel On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote: > On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe > <clabbe.montjoie@gmail.com> wrote: > > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. > > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree. > > The subject should say "add .... device node", not driver. > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > > --- > > arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > > index 19acae1b4089..68e5135410ec 100644 > > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > > @@ -336,6 +336,14 @@ > > #interrupt-cells = <3>; > > #gpio-cells = <3>; > > > > + emac_rgmii_pins: emac-rgmii-pins { > > + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", > > + "PD11", "PD12", "PD13", "PD14", "PD18", > > + "PD19", "PD21", "PD22", "PD23"; > > + function = "gmac"; > > + drive-strength = <40>; > > + }; > > + > > You should mention this change in your commit log. > > ChenYu > Ok I will do it Thanks Regards ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver @ 2017-11-08 19:27 ` Corentin Labbe 0 siblings, 0 replies; 15+ messages in thread From: Corentin Labbe @ 2017-11-08 19:27 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Rob Herring, Mark Rutland, Russell King, Maxime Ripard, devicetree, linux-arm-kernel, linux-kernel On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote: > On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe > <clabbe.montjoie@gmail.com> wrote: > > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. > > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree. > > The subject should say "add .... device node", not driver. > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > > --- > > arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > > index 19acae1b4089..68e5135410ec 100644 > > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > > @@ -336,6 +336,14 @@ > > #interrupt-cells = <3>; > > #gpio-cells = <3>; > > > > + emac_rgmii_pins: emac-rgmii-pins { > > + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", > > + "PD11", "PD12", "PD13", "PD14", "PD18", > > + "PD19", "PD21", "PD22", "PD23"; > > + function = "gmac"; > > + drive-strength = <40>; > > + }; > > + > > You should mention this change in your commit log. > > ChenYu > Ok I will do it Thanks Regards ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver @ 2017-11-08 19:27 ` Corentin Labbe 0 siblings, 0 replies; 15+ messages in thread From: Corentin Labbe @ 2017-11-08 19:27 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Rob Herring, Mark Rutland, Russell King, Maxime Ripard, devicetree, linux-arm-kernel, linux-kernel On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote: > On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe > <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. > > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree. > > The subject should say "add .... device node", not driver. > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Reviewed-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> > > --- > > arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > > index 19acae1b4089..68e5135410ec 100644 > > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > > @@ -336,6 +336,14 @@ > > #interrupt-cells = <3>; > > #gpio-cells = <3>; > > > > + emac_rgmii_pins: emac-rgmii-pins { > > + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", > > + "PD11", "PD12", "PD13", "PD14", "PD18", > > + "PD19", "PD21", "PD22", "PD23"; > > + function = "gmac"; > > + drive-strength = <40>; > > + }; > > + > > You should mention this change in your commit log. > > ChenYu > Ok I will do it Thanks Regards -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2017-11-08 19:30 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-11-07 20:13 [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver Corentin Labbe 2017-11-07 20:13 ` Corentin Labbe 2017-11-07 20:13 ` [PATCH 2/2] ARM: sun8i: bananapi-m3: Enable dwmac-sun8i Corentin Labbe 2017-11-07 20:13 ` Corentin Labbe 2017-11-07 20:13 ` Corentin Labbe 2017-11-08 6:27 ` [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver Chen-Yu Tsai 2017-11-08 6:27 ` Chen-Yu Tsai 2017-11-08 7:48 ` Maxime Ripard 2017-11-08 7:48 ` Maxime Ripard 2017-11-08 7:48 ` Maxime Ripard 2017-11-08 19:30 ` Corentin Labbe 2017-11-08 19:30 ` Corentin Labbe 2017-11-08 19:27 ` Corentin Labbe 2017-11-08 19:27 ` Corentin Labbe 2017-11-08 19:27 ` Corentin Labbe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.