From: Eric Biggers <ebiggers3@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
Tudor-Dan Ambarus <tudor.ambarus@microchip.com>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
Salvatore Benedetto <salvatore.benedetto@intel.com>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Biggers <ebiggers@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] lib/mpi: call cond_resched() from mpi_powm() loop
Date: Wed, 08 Nov 2017 20:28:03 +0000 [thread overview]
Message-ID: <20171108202803.GA14292@gmail.com> (raw)
In-Reply-To: <17716.1510172232@warthog.procyon.org.uk>
On Wed, Nov 08, 2017 at 08:17:12PM +0000, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > This probably should be grouped with my series "crypto: dh - input validation
> > fixes", as this is also a fix for Diffie-Hellman. I was actually expecting
> > Herbert Xu to take these patches, as Diffie-Hellman is now part of the crypto
> > API (crypto/dh.c); none of the patches actually touch security/keys/.
>
> Fine by me.
>
> > If you'd like to maintain the Diffie-Hellman implementation(s) you should
> > get yourself added to MAINTAINERS for the relevant files.
>
> It touches the MPI lib, though, so it also potentially affects RSA and stuff,
> which is why I introduced it to the kernel originally.
>
True, mpi_powm() might also be reachable by adding a key of type "asymmetric",
in which case this fix would need to go to older kernels than v4.12. If I have
a chance I'll see if I can find a reproducer.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers3@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
Tudor-Dan Ambarus <tudor.ambarus@microchip.com>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
Salvatore Benedetto <salvatore.benedetto@intel.com>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Biggers <ebiggers@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] lib/mpi: call cond_resched() from mpi_powm() loop
Date: Wed, 8 Nov 2017 12:28:03 -0800 [thread overview]
Message-ID: <20171108202803.GA14292@gmail.com> (raw)
In-Reply-To: <17716.1510172232@warthog.procyon.org.uk>
On Wed, Nov 08, 2017 at 08:17:12PM +0000, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > This probably should be grouped with my series "crypto: dh - input validation
> > fixes", as this is also a fix for Diffie-Hellman. I was actually expecting
> > Herbert Xu to take these patches, as Diffie-Hellman is now part of the crypto
> > API (crypto/dh.c); none of the patches actually touch security/keys/.
>
> Fine by me.
>
> > If you'd like to maintain the Diffie-Hellman implementation(s) you should
> > get yourself added to MAINTAINERS for the relevant files.
>
> It touches the MPI lib, though, so it also potentially affects RSA and stuff,
> which is why I introduced it to the kernel originally.
>
True, mpi_powm() might also be reachable by adding a key of type "asymmetric",
in which case this fix would need to go to older kernels than v4.12. If I have
a chance I'll see if I can find a reproducer.
Eric
next prev parent reply other threads:[~2017-11-08 20:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 22:15 [PATCH v2] lib/mpi: call cond_resched() from mpi_powm() loop Eric Biggers
2017-11-07 22:15 ` Eric Biggers
2017-11-08 12:50 ` David Howells
2017-11-08 19:18 ` Eric Biggers
2017-11-08 19:18 ` Eric Biggers
2017-11-08 20:17 ` David Howells
2017-11-08 20:28 ` Eric Biggers [this message]
2017-11-08 20:28 ` Eric Biggers
2017-11-08 20:49 ` Mat Martineau
2017-11-08 20:49 ` Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108202803.GA14292@gmail.com \
--to=ebiggers3@gmail.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=salvatore.benedetto@intel.com \
--cc=stable@vger.kernel.org \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.