From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v2 0/4] qla2xxx: Add FC-NVMe Target support
Date: Thu, 9 Nov 2017 10:33:21 +0100 [thread overview]
Message-ID: <20171109093321.GA17246@lst.de> (raw)
In-Reply-To: <20171109031754.10270-1-himanshu.madhani@cavium.com>
Before even looking at the patches: they seem to add a lot of new
sparse warnings, mostly about endianess issues. Given that FC-NVMe
is a mix of BE and LE structures getting this right is important.
Please fix them up first.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Himanshu Madhani <himanshu.madhani@cavium.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
james.smart@broadcom.com, James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 0/4] qla2xxx: Add FC-NVMe Target support
Date: Thu, 9 Nov 2017 10:33:21 +0100 [thread overview]
Message-ID: <20171109093321.GA17246@lst.de> (raw)
In-Reply-To: <20171109031754.10270-1-himanshu.madhani@cavium.com>
Before even looking at the patches: they seem to add a lot of new
sparse warnings, mostly about endianess issues. Given that FC-NVMe
is a mix of BE and LE structures getting this right is important.
Please fix them up first.
next prev parent reply other threads:[~2017-11-09 9:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 3:17 [PATCH v2 0/4] qla2xxx: Add FC-NVMe Target support Himanshu Madhani
2017-11-09 3:17 ` Himanshu Madhani
2017-11-09 3:17 ` [PATCH v2 1/4] qla2xxx_nvmet: Add files for " Himanshu Madhani
2017-11-09 3:17 ` Himanshu Madhani
2017-11-09 15:36 ` James Smart
2017-11-09 15:36 ` James Smart
2017-11-10 5:01 ` Himanshu Madhani
2017-11-10 5:01 ` Himanshu Madhani
2017-11-09 3:17 ` [PATCH v2 2/4] qla2xxx_nvmet: Added Makefile and Kconfig changes Himanshu Madhani
2017-11-09 3:17 ` Himanshu Madhani
2017-11-09 3:17 ` [PATCH v2 3/4] qla2xxx_nvmet: Add FC-NVMe Target LS request handling Himanshu Madhani
2017-11-09 3:17 ` Himanshu Madhani
2017-11-09 3:17 ` [PATCH v2 4/4] qla2xxx_nvmet: Add FC-NVMe Target handling Himanshu Madhani
2017-11-09 3:17 ` Himanshu Madhani
2017-11-09 9:33 ` Christoph Hellwig [this message]
2017-11-09 9:33 ` [PATCH v2 0/4] qla2xxx: Add FC-NVMe Target support Christoph Hellwig
2017-11-10 4:06 ` Himanshu Madhani
2017-11-10 4:06 ` Himanshu Madhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109093321.GA17246@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.