All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
	Keith Busch <keith.busch@intel.com>,
	Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH 4/5] nvme: implement multipath access to nvme subsystems
Date: Thu, 9 Nov 2017 16:51:41 +0100	[thread overview]
Message-ID: <20171109155141.GA25997@lst.de> (raw)
In-Reply-To: <163098dc-02f0-4146-17da-903971e5214d@suse.de>

On Thu, Nov 09, 2017 at 04:44:32PM +0100, Hannes Reinecke wrote:
> - We don't have the topology information in sysfs;

We have all the topology information in sysfs, but you seem to look
for the wrong thing.

> while the namespace
> device has the 'slaves' and 'holders' directories, they remain empty,
> and the path devices don't even have those directories. I really would
> like to see them populated to help things like dracut figuring out the
> topology when building up a list of modules to include.

Of course there aren't because there is not block device you can hold
for the controller.  

> - The patch doesn't integrate with the 'claim' mechanism for block
> devices, ie device-mapper might accidentally stumble upon it when
> traversing devices.

Same as above.  There is no block device to be claimed.

> I'll be sending two patches to resurrect the 'bd_link_disk_holder'
> idea I posted earlier; that should take care of these issues.

It doesn't.  There is not block device you can hold, so there is no
point in claiming it.

WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 4/5] nvme: implement multipath access to nvme subsystems
Date: Thu, 9 Nov 2017 16:51:41 +0100	[thread overview]
Message-ID: <20171109155141.GA25997@lst.de> (raw)
In-Reply-To: <163098dc-02f0-4146-17da-903971e5214d@suse.de>

On Thu, Nov 09, 2017@04:44:32PM +0100, Hannes Reinecke wrote:
> - We don't have the topology information in sysfs;

We have all the topology information in sysfs, but you seem to look
for the wrong thing.

> while the namespace
> device has the 'slaves' and 'holders' directories, they remain empty,
> and the path devices don't even have those directories. I really would
> like to see them populated to help things like dracut figuring out the
> topology when building up a list of modules to include.

Of course there aren't because there is not block device you can hold
for the controller.  

> - The patch doesn't integrate with the 'claim' mechanism for block
> devices, ie device-mapper might accidentally stumble upon it when
> traversing devices.

Same as above.  There is no block device to be claimed.

> I'll be sending two patches to resurrect the 'bd_link_disk_holder'
> idea I posted earlier; that should take care of these issues.

It doesn't.  There is not block device you can hold, so there is no
point in claiming it.

  reply	other threads:[~2017-11-09 15:51 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 18:30 nvme multipath support V6 Christoph Hellwig
2017-11-02 18:30 ` Christoph Hellwig
2017-11-02 18:30 ` [PATCH 1/5] nvme: track subsystems Christoph Hellwig
2017-11-02 18:30   ` Christoph Hellwig
2017-11-09 11:33   ` Sagi Grimberg
2017-11-09 11:33     ` Sagi Grimberg
2017-11-09 12:53     ` Christoph Hellwig
2017-11-09 12:53       ` Christoph Hellwig
2017-11-09 13:01       ` Sagi Grimberg
2017-11-09 13:01         ` Sagi Grimberg
2017-11-02 18:30 ` [PATCH 2/5] nvme: introduce a nvme_ns_ids structure Christoph Hellwig
2017-11-02 18:30   ` Christoph Hellwig
2017-11-02 18:30 ` [PATCH 3/5] nvme: track shared namespaces Christoph Hellwig
2017-11-02 18:30   ` Christoph Hellwig
2017-11-09 11:37   ` Sagi Grimberg
2017-11-09 11:37     ` Sagi Grimberg
2017-11-09 12:52     ` Christoph Hellwig
2017-11-09 12:52       ` Christoph Hellwig
2017-11-09 12:59       ` Sagi Grimberg
2017-11-09 12:59         ` Sagi Grimberg
2017-11-09 13:20         ` Christoph Hellwig
2017-11-09 13:20           ` Christoph Hellwig
2017-11-09 16:09           ` Sagi Grimberg
2017-11-09 16:09             ` Sagi Grimberg
2017-11-02 18:30 ` [PATCH 4/5] nvme: implement multipath access to nvme subsystems Christoph Hellwig
2017-11-02 18:30   ` Christoph Hellwig
2017-11-06 17:03   ` Mike Snitzer
2017-11-06 17:03     ` Mike Snitzer
2017-11-08  8:54   ` Christoph Hellwig
2017-11-08  8:54     ` Christoph Hellwig
2017-11-08 11:18     ` Hannes Reinecke
2017-11-08 11:18       ` Hannes Reinecke
2017-11-09  9:13       ` Christoph Hellwig
2017-11-09  9:13         ` Christoph Hellwig
2017-11-09 15:44   ` Hannes Reinecke
2017-11-09 15:44     ` Hannes Reinecke
2017-11-09 15:51     ` Christoph Hellwig [this message]
2017-11-09 15:51       ` Christoph Hellwig
2017-11-02 18:30 ` [PATCH 5/5] nvme: also expose the namespace identification sysfs files for mpath nodes Christoph Hellwig
2017-11-02 18:30   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171109155141.GA25997@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=jthumshirn@suse.de \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.