From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv3 3/5] nvme: Single AEN request
Date: Thu, 9 Nov 2017 09:04:11 -0700 [thread overview]
Message-ID: <20171109160410.GD25017@localhost.localdomain> (raw)
In-Reply-To: <20171109092450.GC17120@lst.de>
On Thu, Nov 09, 2017@10:24:50AM +0100, Christoph Hellwig wrote:
> On Wed, Nov 08, 2017@09:35:39AM +0800, Guan Junxiong wrote:
> > If le16_to_cpu(status) >> 1 is NVME_SC_ABORT_REQ, the current async event request is
> > aborted and there is no pending request in the queue of async event request of the target.
> > Why do you choose not to submit another async event request to the target?
>
> We're never going to send an abort for the AER, so this status code
> will only happen if the controller is being torn down, in that case we
> don't want to submit another one until the controller is set up again.
Yeah, reclaiming the AER count on abort was a trick for controller resets
when we were tracking those requests. Back then, every reset you'd see
at least one "Cancelling I/O QID 0" message for AER commands. We've had
a better way to handle this wor a while now, so that was left-over
dead code.
next prev parent reply other threads:[~2017-11-09 16:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 22:13 [PATCHv3 0/5] Asynchronous events for udev Keith Busch
2017-11-07 22:13 ` [PATCHv3 1/5] nvme: Centralize AEN defines Keith Busch
2017-11-08 1:37 ` Guan Junxiong
2017-11-09 9:23 ` Christoph Hellwig
2017-11-07 22:13 ` [PATCHv3 2/5] nvme/fc: remove unused "queue_size" field Keith Busch
[not found] ` <45c5bfad-4854-2e01-905e-bcd8cbf42314@broadcom.com>
2017-11-08 0:04 ` Keith Busch
2017-11-08 1:38 ` Guan Junxiong
2017-11-09 9:23 ` Christoph Hellwig
2017-11-07 22:13 ` [PATCHv3 3/5] nvme: Single AEN request Keith Busch
2017-11-08 1:35 ` Guan Junxiong
2017-11-09 9:24 ` Christoph Hellwig
2017-11-09 16:04 ` Keith Busch [this message]
2017-11-09 9:25 ` Christoph Hellwig
2017-11-07 22:13 ` [PATCHv3 4/5] nvme: Unexport starting async event work Keith Busch
2017-11-08 1:39 ` Guan Junxiong
2017-11-07 22:13 ` [PATCHv3 5/5] nvme: Send uevent for some asynchronous events Keith Busch
2017-11-08 1:40 ` Guan Junxiong
2017-11-09 9:27 ` Christoph Hellwig
2017-11-09 16:18 ` Keith Busch
2017-11-09 16:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109160410.GD25017@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.