From: hch@lst.de (Christoph Hellwig)
Subject: [PATCHv3 5/5] nvme: Send uevent for some asynchronous events
Date: Thu, 9 Nov 2017 17:23:03 +0100 [thread overview]
Message-ID: <20171109162303.GA13634@lst.de> (raw)
In-Reply-To: <20171109161846.GE25017@localhost.localdomain>
On Thu, Nov 09, 2017@09:18:46AM -0700, Keith Busch wrote:
> > Seems like we should use cmpxchg on aen.
>
> > > + ctrl->aen = result;
> >
> > Can we call the field aen_result?
> >
> > Given that the rest of the series looks good I'd be tempted to just
> > fix that up and apply it. Are you ok with that?
>
> Thanks, the suggestions sound good to me. If you want to edit the commit
> when applying, I would much appreciate.
I'll just do the rename for now. I'll ponder the cmpxchg a little more,
and if I think we need it I'll send a follow on patch.
prev parent reply other threads:[~2017-11-09 16:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 22:13 [PATCHv3 0/5] Asynchronous events for udev Keith Busch
2017-11-07 22:13 ` [PATCHv3 1/5] nvme: Centralize AEN defines Keith Busch
2017-11-08 1:37 ` Guan Junxiong
2017-11-09 9:23 ` Christoph Hellwig
2017-11-07 22:13 ` [PATCHv3 2/5] nvme/fc: remove unused "queue_size" field Keith Busch
[not found] ` <45c5bfad-4854-2e01-905e-bcd8cbf42314@broadcom.com>
2017-11-08 0:04 ` Keith Busch
2017-11-08 1:38 ` Guan Junxiong
2017-11-09 9:23 ` Christoph Hellwig
2017-11-07 22:13 ` [PATCHv3 3/5] nvme: Single AEN request Keith Busch
2017-11-08 1:35 ` Guan Junxiong
2017-11-09 9:24 ` Christoph Hellwig
2017-11-09 16:04 ` Keith Busch
2017-11-09 9:25 ` Christoph Hellwig
2017-11-07 22:13 ` [PATCHv3 4/5] nvme: Unexport starting async event work Keith Busch
2017-11-08 1:39 ` Guan Junxiong
2017-11-07 22:13 ` [PATCHv3 5/5] nvme: Send uevent for some asynchronous events Keith Busch
2017-11-08 1:40 ` Guan Junxiong
2017-11-09 9:27 ` Christoph Hellwig
2017-11-09 16:18 ` Keith Busch
2017-11-09 16:23 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109162303.GA13634@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.