From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Damien Riegel <damien.riegel@savoirfairelinux.com>
Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
kernel@savoirfairelinux.com
Subject: Re: [PATCH 2/4] arm64: dts: qcom: msm8916-pins: remove assignments to bias-disable
Date: Thu, 9 Nov 2017 08:50:01 -0800 [thread overview]
Message-ID: <20171109165001.GA28761@minitux> (raw)
In-Reply-To: <20171101175335.22123-3-damien.riegel@savoirfairelinux.com>
On Wed 01 Nov 10:53 PDT 2017, Damien Riegel wrote:
> Drop assignments to bias-disable as the documentation [1] states that
> this property doesn't take a value. Other occurrences of this property
> respect that.
>
> [1] Documentation/devicetree/bindings/pinctrl/qcom,msm8916-pinctrl.txt
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> ---
> arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
> index 4cb0b5834143..c67ad8ed8b60 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
> @@ -278,7 +278,7 @@
> pinconf {
> pins = "gpio6", "gpio7";
> drive-strength = <16>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -290,7 +290,7 @@
> pinconf {
> pins = "gpio6", "gpio7";
> drive-strength = <2>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -302,7 +302,7 @@
> pinconf {
> pins = "gpio14", "gpio15";
> drive-strength = <16>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -314,7 +314,7 @@
> pinconf {
> pins = "gpio14", "gpio15";
> drive-strength = <2>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -326,7 +326,7 @@
> pinconf {
> pins = "gpio22", "gpio23";
> drive-strength = <16>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -338,7 +338,7 @@
> pinconf {
> pins = "gpio22", "gpio23";
> drive-strength = <2>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> --
> 2.15.0
>
WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] arm64: dts: qcom: msm8916-pins: remove assignments to bias-disable
Date: Thu, 9 Nov 2017 08:50:01 -0800 [thread overview]
Message-ID: <20171109165001.GA28761@minitux> (raw)
In-Reply-To: <20171101175335.22123-3-damien.riegel@savoirfairelinux.com>
On Wed 01 Nov 10:53 PDT 2017, Damien Riegel wrote:
> Drop assignments to bias-disable as the documentation [1] states that
> this property doesn't take a value. Other occurrences of this property
> respect that.
>
> [1] Documentation/devicetree/bindings/pinctrl/qcom,msm8916-pinctrl.txt
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> ---
> arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
> index 4cb0b5834143..c67ad8ed8b60 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
> @@ -278,7 +278,7 @@
> pinconf {
> pins = "gpio6", "gpio7";
> drive-strength = <16>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -290,7 +290,7 @@
> pinconf {
> pins = "gpio6", "gpio7";
> drive-strength = <2>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -302,7 +302,7 @@
> pinconf {
> pins = "gpio14", "gpio15";
> drive-strength = <16>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -314,7 +314,7 @@
> pinconf {
> pins = "gpio14", "gpio15";
> drive-strength = <2>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -326,7 +326,7 @@
> pinconf {
> pins = "gpio22", "gpio23";
> drive-strength = <16>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> @@ -338,7 +338,7 @@
> pinconf {
> pins = "gpio22", "gpio23";
> drive-strength = <2>;
> - bias-disable = <0>;
> + bias-disable;
> };
> };
>
> --
> 2.15.0
>
next prev parent reply other threads:[~2017-11-09 16:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 17:53 [PATCH 0/4] arm64: dts: qcom: dts improvements Damien Riegel
2017-11-01 17:53 ` Damien Riegel
2017-11-01 17:53 ` [PATCH 1/4] arm64: dts: qcom: pm8916: fix wcd_codec indentation Damien Riegel
2017-11-01 17:53 ` Damien Riegel
[not found] ` <20171101175335.22123-2-damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2017-11-09 16:49 ` Bjorn Andersson
2017-11-09 16:49 ` Bjorn Andersson
2017-11-09 16:49 ` Bjorn Andersson
2017-11-01 17:53 ` [PATCH 2/4] arm64: dts: qcom: msm8916-pins: remove assignments to bias-disable Damien Riegel
2017-11-01 17:53 ` Damien Riegel
2017-11-09 16:50 ` Bjorn Andersson [this message]
2017-11-09 16:50 ` Bjorn Andersson
2017-11-01 17:53 ` [PATCH 3/4] arm64: dts: qcom: msm8916: normalize I2C bindings Damien Riegel
2017-11-01 17:53 ` Damien Riegel
[not found] ` <20171101175335.22123-4-damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2017-11-09 16:56 ` Bjorn Andersson
2017-11-09 16:56 ` Bjorn Andersson
2017-11-09 16:56 ` Bjorn Andersson
2017-11-01 17:53 ` [PATCH 4/4] arm64: dts: qcom: msm8916: add bindings for i2c1, i2c3, i2c5 Damien Riegel
2017-11-01 17:53 ` Damien Riegel
[not found] ` <20171101175335.22123-5-damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2017-11-09 17:00 ` Bjorn Andersson
2017-11-09 17:00 ` Bjorn Andersson
2017-11-09 17:00 ` Bjorn Andersson
2017-11-09 17:14 ` Damien Riegel
2017-11-09 17:14 ` Damien Riegel
2017-11-11 7:56 ` Bjorn Andersson
2017-11-11 7:56 ` Bjorn Andersson
2017-11-14 23:13 ` Damien Riegel
2017-11-14 23:13 ` Damien Riegel
2017-11-14 23:13 ` Damien Riegel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109165001.GA28761@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=damien.riegel@savoirfairelinux.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@savoirfairelinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.