From: Al Viro <viro@ZenIV.linux.org.uk>
To: Colin King <colin.king@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marcus Wolf <linux@Wolf-Entwicklungen.de>,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: fix missing break in switch statement.
Date: Thu, 09 Nov 2017 18:34:22 +0000 [thread overview]
Message-ID: <20171109183422.GA21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20171109171955.10911-1-colin.king@canonical.com>
On Thu, Nov 09, 2017 at 05:19:55PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The PI433_IOC_WR_RX_CFG case is missing a break and will fall through
> to the default case and errorenously return -EINVAL. Fix this by
> adding in missing break.
Folded and pushed...
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Colin King <colin.king@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marcus Wolf <linux@Wolf-Entwicklungen.de>,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: fix missing break in switch statement.
Date: Thu, 9 Nov 2017 18:34:22 +0000 [thread overview]
Message-ID: <20171109183422.GA21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20171109171955.10911-1-colin.king@canonical.com>
On Thu, Nov 09, 2017 at 05:19:55PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The PI433_IOC_WR_RX_CFG case is missing a break and will fall through
> to the default case and errorenously return -EINVAL. Fix this by
> adding in missing break.
Folded and pushed...
next prev parent reply other threads:[~2017-11-09 18:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 17:19 [PATCH] staging: pi433: fix missing break in switch statement Colin King
2017-11-09 17:19 ` Colin King
2017-11-09 18:34 ` Al Viro [this message]
2017-11-09 18:34 ` Al Viro
2017-11-09 21:48 ` Dan Carpenter
2017-11-09 21:48 ` Dan Carpenter
2017-11-10 16:49 ` Marcus Wolf
2017-11-10 16:49 ` Marcus Wolf
2017-11-10 17:04 ` Colin Ian King
2017-11-10 17:14 ` Marcus Wolf
2017-11-10 17:14 ` Marcus Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109183422.GA21978@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@Wolf-Entwicklungen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.