From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <keith.busch@intel.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 4/7] nvme: implement multipath access to nvme subsystems
Date: Fri, 10 Nov 2017 05:52:36 +0100 [thread overview]
Message-ID: <20171110045236.GA32408@lst.de> (raw)
In-Reply-To: <20171109212111.GA1718@localhost.localdomain>
> If we've CMIC capabilities, we'll use the subsys->instance; if we don't
> have CMIC, we use the ctrl->instance.
>
> Since the two instances are independent of each other, they can create
> duplicate names.
>
> To fix, I think we'll need to always use the subsys instance for
> consistency if CONFIG_NVME_MULTIPATH=y.
Yes, we should. But once we do that we should just always use
subsys->instance, as it will always be the same as ctrl->instance
for CONFIG_NVME_MULTIPATH=n.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 4/7] nvme: implement multipath access to nvme subsystems
Date: Fri, 10 Nov 2017 05:52:36 +0100 [thread overview]
Message-ID: <20171110045236.GA32408@lst.de> (raw)
In-Reply-To: <20171109212111.GA1718@localhost.localdomain>
> If we've CMIC capabilities, we'll use the subsys->instance; if we don't
> have CMIC, we use the ctrl->instance.
>
> Since the two instances are independent of each other, they can create
> duplicate names.
>
> To fix, I think we'll need to always use the subsys instance for
> consistency if CONFIG_NVME_MULTIPATH=y.
Yes, we should. But once we do that we should just always use
subsys->instance, as it will always be the same as ctrl->instance
for CONFIG_NVME_MULTIPATH=n.
next prev parent reply other threads:[~2017-11-10 4:52 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 17:44 nvme multipath support V7 Christoph Hellwig
2017-11-09 17:44 ` Christoph Hellwig
2017-11-09 17:44 ` [PATCH 1/7] nvme: track subsystems Christoph Hellwig
2017-11-09 17:44 ` Christoph Hellwig
2017-11-09 20:23 ` Martin K. Petersen
2017-11-09 20:23 ` Martin K. Petersen
2017-11-09 17:44 ` [PATCH 2/7] nvme: introduce a nvme_ns_ids structure Christoph Hellwig
2017-11-09 17:44 ` Christoph Hellwig
2017-11-09 20:25 ` Martin K. Petersen
2017-11-09 20:25 ` Martin K. Petersen
2017-11-09 17:44 ` [PATCH 3/7] nvme: track shared namespaces Christoph Hellwig
2017-11-09 17:44 ` Christoph Hellwig
2017-11-09 20:28 ` Martin K. Petersen
2017-11-09 20:28 ` Martin K. Petersen
2017-11-09 17:44 ` [PATCH 4/7] nvme: implement multipath access to nvme subsystems Christoph Hellwig
2017-11-09 17:44 ` Christoph Hellwig
2017-11-09 18:17 ` Keith Busch
2017-11-09 18:17 ` Keith Busch
2017-11-09 20:32 ` Martin K. Petersen
2017-11-09 20:32 ` Martin K. Petersen
2017-11-09 21:21 ` Keith Busch
2017-11-09 21:21 ` Keith Busch
2017-11-10 4:52 ` Christoph Hellwig [this message]
2017-11-10 4:52 ` Christoph Hellwig
2017-11-10 5:07 ` Christoph Hellwig
2017-11-10 5:07 ` Christoph Hellwig
2017-11-09 21:22 ` Mike Snitzer
2017-11-09 21:22 ` Mike Snitzer
2017-11-10 4:54 ` Christoph Hellwig
2017-11-10 4:54 ` Christoph Hellwig
2017-11-10 7:27 ` Hannes Reinecke
2017-11-10 7:27 ` Hannes Reinecke
2017-11-09 17:44 ` [PATCH 5/7] nvme: also expose the namespace identification sysfs files for mpath nodes Christoph Hellwig
2017-11-09 17:44 ` Christoph Hellwig
2017-11-09 20:33 ` Martin K. Petersen
2017-11-09 20:33 ` Martin K. Petersen
2017-11-10 8:21 ` Hannes Reinecke
2017-11-10 8:21 ` Hannes Reinecke
2017-11-09 17:44 ` [PATCH 6/7] block: create 'slaves' and 'holders' entries for hidden gendisks Christoph Hellwig
2017-11-09 17:44 ` Christoph Hellwig
2017-11-09 20:34 ` Martin K. Petersen
2017-11-09 20:34 ` Martin K. Petersen
2017-11-09 17:44 ` [PATCH 7/7] nvme: create 'slaves' and 'holders' entries for hidden controllers Christoph Hellwig
2017-11-09 17:44 ` Christoph Hellwig
2017-11-09 20:34 ` Martin K. Petersen
2017-11-09 20:34 ` Martin K. Petersen
2017-11-10 8:44 ` nvme multipath support V7 Christoph Hellwig
2017-11-10 8:44 ` Christoph Hellwig
2018-04-10 19:32 ` Gruher, Joseph R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110045236.GA32408@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.