All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org, "Michal Hocko" <mhocko@suse.com>,
	linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-mm@kvack.org, "Jérôme Glisse" <jglisse@redhat.com>,
	linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
	hch@lst.de
Subject: Re: [PATCH 12/15] mm, dax: enable filesystems to trigger page-idle callbacks
Date: Fri, 10 Nov 2017 10:04:53 +0100	[thread overview]
Message-ID: <20171110090453.GC4895@lst.de> (raw)
In-Reply-To: <150949216078.24061.1875240167277688258.stgit@dwillia2-desk3.amr.corp.intel.com>

> +DEFINE_MUTEX(devmap_lock);

static?

> +#if IS_ENABLED(CONFIG_FS_DAX)
> +static void generic_dax_pagefree(struct page *page, void *data)
> +{
> +}
> +
> +struct dax_device *fs_dax_claim_bdev(struct block_device *bdev, void *owner)
> +{
> +	struct dax_device *dax_dev;
> +	struct dev_pagemap *pgmap;
> +
> +	if (!blk_queue_dax(bdev->bd_queue))
> +		return NULL;
> +	dax_dev = fs_dax_get_by_host(bdev->bd_disk->disk_name);
> +	if (!dax_dev->pgmap)
> +		return dax_dev;
> +	pgmap = dax_dev->pgmap;

> +	mutex_lock(&devmap_lock);
> +	if ((pgmap->data && pgmap->data != owner) || pgmap->page_free
> +			|| pgmap->page_fault
> +			|| pgmap->type != MEMORY_DEVICE_HOST) {
> +		put_dax(dax_dev);
> +		mutex_unlock(&devmap_lock);
> +		return NULL;
> +	}
> +
> +	pgmap->type = MEMORY_DEVICE_FS_DAX;
> +	pgmap->page_free = generic_dax_pagefree;
> +	pgmap->data = owner;
> +	mutex_unlock(&devmap_lock);

All this deep magic will need some explanation.  So far I don't understand
it at all, but maybe the later patches will help..

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org, "Michal Hocko" <mhocko@suse.com>,
	linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-mm@kvack.org, "Jérôme Glisse" <jglisse@redhat.com>,
	linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
	hch@lst.de
Subject: Re: [PATCH 12/15] mm, dax: enable filesystems to trigger page-idle callbacks
Date: Fri, 10 Nov 2017 10:04:53 +0100	[thread overview]
Message-ID: <20171110090453.GC4895@lst.de> (raw)
In-Reply-To: <150949216078.24061.1875240167277688258.stgit@dwillia2-desk3.amr.corp.intel.com>

> +DEFINE_MUTEX(devmap_lock);

static?

> +#if IS_ENABLED(CONFIG_FS_DAX)
> +static void generic_dax_pagefree(struct page *page, void *data)
> +{
> +}
> +
> +struct dax_device *fs_dax_claim_bdev(struct block_device *bdev, void *owner)
> +{
> +	struct dax_device *dax_dev;
> +	struct dev_pagemap *pgmap;
> +
> +	if (!blk_queue_dax(bdev->bd_queue))
> +		return NULL;
> +	dax_dev = fs_dax_get_by_host(bdev->bd_disk->disk_name);
> +	if (!dax_dev->pgmap)
> +		return dax_dev;
> +	pgmap = dax_dev->pgmap;

> +	mutex_lock(&devmap_lock);
> +	if ((pgmap->data && pgmap->data != owner) || pgmap->page_free
> +			|| pgmap->page_fault
> +			|| pgmap->type != MEMORY_DEVICE_HOST) {
> +		put_dax(dax_dev);
> +		mutex_unlock(&devmap_lock);
> +		return NULL;
> +	}
> +
> +	pgmap->type = MEMORY_DEVICE_FS_DAX;
> +	pgmap->page_free = generic_dax_pagefree;
> +	pgmap->data = owner;
> +	mutex_unlock(&devmap_lock);

All this deep magic will need some explanation.  So far I don't understand
it at all, but maybe the later patches will help..

  reply	other threads:[~2017-11-10  9:04 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 23:21 [PATCH 00/15] dax: prep work for fixing dax-dma vs truncate collisions Dan Williams
2017-10-31 23:21 ` Dan Williams
2017-10-31 23:21 ` Dan Williams
2017-10-31 23:21 ` [PATCH 01/15] dax: quiet bdev_dax_supported() Dan Williams
2017-10-31 23:21   ` Dan Williams
2017-10-31 23:21   ` Dan Williams
2017-11-02 20:11   ` Christoph Hellwig
2017-11-02 20:11     ` Christoph Hellwig
2017-10-31 23:21 ` [PATCH 02/15] mm, dax: introduce pfn_t_special() Dan Williams
2017-10-31 23:21   ` Dan Williams
2017-11-03  2:32   ` Michael Ellerman
2017-11-03  2:32     ` Michael Ellerman
2017-11-03  2:32     ` Michael Ellerman
2017-10-31 23:21 ` [PATCH 03/15] dax: require 'struct page' by default for filesystem dax Dan Williams
2017-10-31 23:21   ` Dan Williams
2017-10-31 23:21   ` Dan Williams
2017-10-31 23:21 ` [PATCH 04/15] brd: remove dax support Dan Williams
2017-10-31 23:21   ` Dan Williams
2017-10-31 23:21   ` Dan Williams
2017-11-02 20:12   ` Christoph Hellwig
2017-11-02 20:12     ` Christoph Hellwig
2017-11-04 16:31   ` Jens Axboe
2017-11-04 16:31     ` Jens Axboe
2017-11-04 16:31     ` Jens Axboe
2017-10-31 23:22 ` [PATCH 05/15] dax: stop using VM_MIXEDMAP for dax Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22 ` [PATCH 06/15] dax: stop using VM_HUGEPAGE " Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22 ` [PATCH 07/15] dax: stop requiring a live device for dax_flush() Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-11-02 20:12   ` Christoph Hellwig
2017-11-02 20:12     ` Christoph Hellwig
2017-10-31 23:22 ` [PATCH 08/15] dax: store pfns in the radix Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22 ` [PATCH 09/15] tools/testing/nvdimm: add 'bio_delay' mechanism Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22 ` [PATCH 10/15] IB/core: disable memory registration of fileystem-dax vmas Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-11-02 20:13   ` Christoph Hellwig
2017-11-02 20:13     ` Christoph Hellwig
2017-11-02 21:06     ` Dan Williams
2017-11-02 21:06       ` Dan Williams
2017-11-02 21:06       ` Dan Williams
2017-10-31 23:22 ` [PATCH 11/15] [media] v4l2: disable filesystem-dax mapping support Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22 ` [PATCH 12/15] mm, dax: enable filesystems to trigger page-idle callbacks Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-11-10  9:04   ` Christoph Hellwig [this message]
2017-11-10  9:04     ` Christoph Hellwig
2017-10-31 23:22 ` [PATCH 13/15] mm, devmap: introduce CONFIG_DEVMAP_MANAGED_PAGES Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-11-10  9:06   ` Christoph Hellwig
2017-11-10  9:06     ` Christoph Hellwig
2017-10-31 23:22 ` [PATCH 14/15] dax: associate mappings with inodes, and warn if dma collides with truncate Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-11-10  9:08   ` Christoph Hellwig
2017-11-10  9:08     ` Christoph Hellwig
2017-11-10  9:08     ` Christoph Hellwig
2017-12-20  1:11     ` Dan Williams
2017-12-20  1:11       ` Dan Williams
2017-12-20 14:38       ` Jan Kara
2017-12-20 14:38         ` Jan Kara
2017-12-20 22:41         ` Dan Williams
2017-12-20 22:41           ` Dan Williams
2017-12-20 22:41           ` Dan Williams
2017-12-21 12:14           ` Jan Kara
2017-12-21 12:14             ` Jan Kara
2017-12-21 17:31             ` Dan Williams
2017-12-21 17:31               ` Dan Williams
2017-12-22  8:51               ` Jan Kara
2017-12-22  8:51                 ` Jan Kara
2017-12-20 22:14       ` Dave Chinner
2017-12-20 22:14         ` Dave Chinner
2017-12-20 22:14         ` Dave Chinner
2017-10-31 23:22 ` [PATCH 15/15] wait_bit: introduce {wait_on,wake_up}_devmap_idle Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-10-31 23:22   ` Dan Williams
2017-11-10  9:09   ` Christoph Hellwig
2017-11-10  9:09     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171110090453.GC4895@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=jglisse@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mhocko@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.