From: Eduardo Habkost <ehabkost@redhat.com>
To: "Emilio G. Cota" <cota@braap.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
Igor Mitsyanko <i.mitsyanko@gmail.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org,
Alistair Francis <alistair.francis@xilinx.com>,
qemu-arm@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>
Subject: Re: [Qemu-arm] [PATCH for 2.11 1/5] qom: move CPUClass.tcg_initialize to a global
Date: Fri, 10 Nov 2017 18:23:45 -0200 [thread overview]
Message-ID: <20171110202345.GU3111@localhost.localdomain> (raw)
In-Reply-To: <1510343626-25861-2-git-send-email-cota@braap.org>
On Fri, Nov 10, 2017 at 02:53:42PM -0500, Emilio G. Cota wrote:
> 55c3cee ("qom: Introduce CPUClass.tcg_initialize", 2017-10-24)
> introduces a per-CPUClass bool that we check so that the target CPU
> is initialized for TCG only once. This works well except when
> we end up creating more than one CPUClass, in which case we end
> up incorrectly initializing TCG more than once, i.e. once for
> each CPUClass.
>
> This can be replicated with:
> $ aarch64-softmmu/qemu-system-aarch64 -machine xlnx-zcu102 -smp 6 \
> -global driver=xlnx,,zynqmp,property=has_rpu,value=on
> In this case the class name of the "RPUs" is prefixed by "cortex-r5-",
> whereas the "regular" CPUs are prefixed by "cortex-a53-". This
> results in two CPUClass instances being created.
>
> Fix it by introducing a static variable, so that only the first
> target CPU being initialized will initialize the target-dependent
> part of TCG, regardless of CPUClass instances.
>
> Fixes: 55c3ceef61fcf06fc98ddc752b7cce788ce7680b
> Signed-off-by: Emilio G. Cota <cota@braap.org>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: "Emilio G. Cota" <cota@braap.org>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
Thomas Huth <thuth@redhat.com>,
qemu-arm@nongnu.org, Igor Mitsyanko <i.mitsyanko@gmail.com>,
Alistair Francis <alistair.francis@xilinx.com>,
"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
Marcel Apfelbaum <marcel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for 2.11 1/5] qom: move CPUClass.tcg_initialize to a global
Date: Fri, 10 Nov 2017 18:23:45 -0200 [thread overview]
Message-ID: <20171110202345.GU3111@localhost.localdomain> (raw)
In-Reply-To: <1510343626-25861-2-git-send-email-cota@braap.org>
On Fri, Nov 10, 2017 at 02:53:42PM -0500, Emilio G. Cota wrote:
> 55c3cee ("qom: Introduce CPUClass.tcg_initialize", 2017-10-24)
> introduces a per-CPUClass bool that we check so that the target CPU
> is initialized for TCG only once. This works well except when
> we end up creating more than one CPUClass, in which case we end
> up incorrectly initializing TCG more than once, i.e. once for
> each CPUClass.
>
> This can be replicated with:
> $ aarch64-softmmu/qemu-system-aarch64 -machine xlnx-zcu102 -smp 6 \
> -global driver=xlnx,,zynqmp,property=has_rpu,value=on
> In this case the class name of the "RPUs" is prefixed by "cortex-r5-",
> whereas the "regular" CPUs are prefixed by "cortex-a53-". This
> results in two CPUClass instances being created.
>
> Fix it by introducing a static variable, so that only the first
> target CPU being initialized will initialize the target-dependent
> part of TCG, regardless of CPUClass instances.
>
> Fixes: 55c3ceef61fcf06fc98ddc752b7cce788ce7680b
> Signed-off-by: Emilio G. Cota <cota@braap.org>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
next prev parent reply other threads:[~2017-11-10 20:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 19:53 [Qemu-arm] [PATCH for 2.11 0/5] TCG/ARM fixes for 2.11 Emilio G. Cota
2017-11-10 19:53 ` [Qemu-devel] " Emilio G. Cota
2017-11-10 19:53 ` [Qemu-arm] [PATCH for 2.11 1/5] qom: move CPUClass.tcg_initialize to a global Emilio G. Cota
2017-11-10 19:53 ` [Qemu-devel] " Emilio G. Cota
2017-11-10 20:23 ` Eduardo Habkost [this message]
2017-11-10 20:23 ` Eduardo Habkost
2017-11-10 23:12 ` [Qemu-arm] " Alistair Francis
2017-11-10 23:12 ` Alistair Francis
2017-11-13 8:19 ` [Qemu-arm] " Richard Henderson
2017-11-13 8:19 ` [Qemu-devel] " Richard Henderson
2017-11-10 19:53 ` [Qemu-arm] [PATCH for 2.11 2/5] xlnx-zynqmp: Properly support the smp command line option Emilio G. Cota
2017-11-10 19:53 ` [Qemu-devel] " Emilio G. Cota
2017-11-10 19:53 ` [Qemu-arm] [PATCH for 2.11 3/5] xlnx-zcu102: Add an info message deprecating the EP108 Emilio G. Cota
2017-11-10 19:53 ` [Qemu-devel] " Emilio G. Cota
2017-11-10 19:53 ` [Qemu-arm] [PATCH for 2.11 4/5] xlnx-zcu102: Specify the max number of CPUs for " Emilio G. Cota
2017-11-10 19:53 ` [Qemu-devel] " Emilio G. Cota
2017-11-10 23:10 ` [Qemu-arm] " Alistair Francis
2017-11-10 23:10 ` Alistair Francis
2017-11-10 19:53 ` [Qemu-arm] [PATCH for 2.11 5/5] hw: add .min_cpus and .default_cpus fields to machine_class Emilio G. Cota
2017-11-10 19:53 ` [Qemu-devel] " Emilio G. Cota
2017-11-10 20:32 ` Eduardo Habkost
2017-11-10 20:32 ` Eduardo Habkost
2017-11-10 23:21 ` Alistair Francis
2017-11-10 23:21 ` Alistair Francis
2017-11-13 11:40 ` [Qemu-arm] [PATCH for 2.11 0/5] TCG/ARM fixes for 2.11 Peter Maydell
2017-11-13 11:40 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110202345.GU3111@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=cota@braap.org \
--cc=i.mitsyanko@gmail.com \
--cc=marcel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.