From: Jonathan.Cameron@huawei.com (Jonathan Cameron)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 0/4] fix the clock setting for SAR ADC
Date: Sat, 11 Nov 2017 00:37:37 +0000 [thread overview]
Message-ID: <20171111003737.000038f0@huawei.com> (raw)
In-Reply-To: <CAFBinCB=2pb9dZkpSqdVAiumkSCzgaW0oejftjZNP7aYbiQJuw@mail.gmail.com>
On Tue, 7 Nov 2017 22:36:00 +0100
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Hi Yixun,
>
> On Tue, Nov 7, 2017 at 3:09 PM, Yixun Lan <yixun.lan@amlogic.com> wrote:
> > patch [1/4]:
> > Fix wrong SARADC/SANA clock gate bit in Meson-GXBB/GXL,
> > the published datasheets[4] also has wrong description about this.
> > This patch should be explicitly merged *before* other patches.
> >
> > patch [2-4/4]:
> > Drop the "sana" clock from SAR ADC module,
> I agree with Jerome that patch 2/4 should be applied last.
Let me know when I should take this.
Thanks,
Jonathan
> when I wrote the driver I couldn't get it to work on my GXBB board
> (which unfortunately has died since then) because the clocks were
> disabled (they weren't enabled by the bootloader). people who are
> using an old .dtb would get the same problem again until the clock
> driver is merged
>
> > From the hardware perspective, the SAR ADC module doesn't
> > require "sana" clock to wrok. This should apply to all SoC,
> > including meson6,8, GXBB, GXL..
> thank you for clarifying this!
>
> > Note: the whole patchset series has been tested at GXL-P212 board,
> > we haven't got any meson6,8 board to test, so I would appreciate
> > if someone (Martin?) could help to confirm it works there.
> I can test this on a Meson8b and a Meson8m2 board on the weekend -
> I'll let you know about the results
>
>
> Regards
> Martin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Neil Armstrong <narmstrong@baylibre.com>,
linux-iio@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
Michael Turquette <mturquette@baylibre.com>,
Yixun Lan <yixun.lan@amlogic.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Xingyu Chen <xingyu.chen@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v4 0/4] fix the clock setting for SAR ADC
Date: Sat, 11 Nov 2017 00:37:37 +0000 [thread overview]
Message-ID: <20171111003737.000038f0@huawei.com> (raw)
In-Reply-To: <CAFBinCB=2pb9dZkpSqdVAiumkSCzgaW0oejftjZNP7aYbiQJuw@mail.gmail.com>
On Tue, 7 Nov 2017 22:36:00 +0100
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Hi Yixun,
>
> On Tue, Nov 7, 2017 at 3:09 PM, Yixun Lan <yixun.lan@amlogic.com> wrote:
> > patch [1/4]:
> > Fix wrong SARADC/SANA clock gate bit in Meson-GXBB/GXL,
> > the published datasheets[4] also has wrong description about this.
> > This patch should be explicitly merged *before* other patches.
> >
> > patch [2-4/4]:
> > Drop the "sana" clock from SAR ADC module,
> I agree with Jerome that patch 2/4 should be applied last.
Let me know when I should take this.
Thanks,
Jonathan
> when I wrote the driver I couldn't get it to work on my GXBB board
> (which unfortunately has died since then) because the clocks were
> disabled (they weren't enabled by the bootloader). people who are
> using an old .dtb would get the same problem again until the clock
> driver is merged
>
> > From the hardware perspective, the SAR ADC module doesn't
> > require "sana" clock to wrok. This should apply to all SoC,
> > including meson6,8, GXBB, GXL..
> thank you for clarifying this!
>
> > Note: the whole patchset series has been tested at GXL-P212 board,
> > we haven't got any meson6,8 board to test, so I would appreciate
> > if someone (Martin?) could help to confirm it works there.
> I can test this on a Meson8b and a Meson8m2 board on the weekend -
> I'll let you know about the results
>
>
> Regards
> Martin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Yixun Lan <yixun.lan@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
<devicetree@vger.kernel.org>, Jonathan Cameron <jic23@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Michael Turquette" <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
"Xingyu Chen" <xingyu.chen@amlogic.com>,
<linux-amlogic@lists.infradead.org>, <linux-iio@vger.kernel.org>,
<linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 0/4] fix the clock setting for SAR ADC
Date: Sat, 11 Nov 2017 00:37:37 +0000 [thread overview]
Message-ID: <20171111003737.000038f0@huawei.com> (raw)
In-Reply-To: <CAFBinCB=2pb9dZkpSqdVAiumkSCzgaW0oejftjZNP7aYbiQJuw@mail.gmail.com>
On Tue, 7 Nov 2017 22:36:00 +0100
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Hi Yixun,
>
> On Tue, Nov 7, 2017 at 3:09 PM, Yixun Lan <yixun.lan@amlogic.com> wrote:
> > patch [1/4]:
> > Fix wrong SARADC/SANA clock gate bit in Meson-GXBB/GXL,
> > the published datasheets[4] also has wrong description about this.
> > This patch should be explicitly merged *before* other patches.
> >
> > patch [2-4/4]:
> > Drop the "sana" clock from SAR ADC module,
> I agree with Jerome that patch 2/4 should be applied last.
Let me know when I should take this.
Thanks,
Jonathan
> when I wrote the driver I couldn't get it to work on my GXBB board
> (which unfortunately has died since then) because the clocks were
> disabled (they weren't enabled by the bootloader). people who are
> using an old .dtb would get the same problem again until the clock
> driver is merged
>
> > From the hardware perspective, the SAR ADC module doesn't
> > require "sana" clock to wrok. This should apply to all SoC,
> > including meson6,8, GXBB, GXL..
> thank you for clarifying this!
>
> > Note: the whole patchset series has been tested at GXL-P212 board,
> > we haven't got any meson6,8 board to test, so I would appreciate
> > if someone (Martin?) could help to confirm it works there.
> I can test this on a Meson8b and a Meson8m2 board on the weekend -
> I'll let you know about the results
>
>
> Regards
> Martin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan.Cameron@huawei.com (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/4] fix the clock setting for SAR ADC
Date: Sat, 11 Nov 2017 00:37:37 +0000 [thread overview]
Message-ID: <20171111003737.000038f0@huawei.com> (raw)
In-Reply-To: <CAFBinCB=2pb9dZkpSqdVAiumkSCzgaW0oejftjZNP7aYbiQJuw@mail.gmail.com>
On Tue, 7 Nov 2017 22:36:00 +0100
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Hi Yixun,
>
> On Tue, Nov 7, 2017 at 3:09 PM, Yixun Lan <yixun.lan@amlogic.com> wrote:
> > patch [1/4]:
> > Fix wrong SARADC/SANA clock gate bit in Meson-GXBB/GXL,
> > the published datasheets[4] also has wrong description about this.
> > This patch should be explicitly merged *before* other patches.
> >
> > patch [2-4/4]:
> > Drop the "sana" clock from SAR ADC module,
> I agree with Jerome that patch 2/4 should be applied last.
Let me know when I should take this.
Thanks,
Jonathan
> when I wrote the driver I couldn't get it to work on my GXBB board
> (which unfortunately has died since then) because the clocks were
> disabled (they weren't enabled by the bootloader). people who are
> using an old .dtb would get the same problem again until the clock
> driver is merged
>
> > From the hardware perspective, the SAR ADC module doesn't
> > require "sana" clock to wrok. This should apply to all SoC,
> > including meson6,8, GXBB, GXL..
> thank you for clarifying this!
>
> > Note: the whole patchset series has been tested at GXL-P212 board,
> > we haven't got any meson6,8 board to test, so I would appreciate
> > if someone (Martin?) could help to confirm it works there.
> I can test this on a Meson8b and a Meson8m2 board on the weekend -
> I'll let you know about the results
>
>
> Regards
> Martin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Neil Armstrong <narmstrong@baylibre.com>,
linux-iio@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
Michael Turquette <mturquette@baylibre.com>,
Yixun Lan <yixun.lan@amlogic.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Xingyu Chen <xingyu.chen@amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v4 0/4] fix the clock setting for SAR ADC
Date: Sat, 11 Nov 2017 00:37:37 +0000 [thread overview]
Message-ID: <20171111003737.000038f0@huawei.com> (raw)
In-Reply-To: <CAFBinCB=2pb9dZkpSqdVAiumkSCzgaW0oejftjZNP7aYbiQJuw@mail.gmail.com>
On Tue, 7 Nov 2017 22:36:00 +0100
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Hi Yixun,
>
> On Tue, Nov 7, 2017 at 3:09 PM, Yixun Lan <yixun.lan@amlogic.com> wrote:
> > patch [1/4]:
> > Fix wrong SARADC/SANA clock gate bit in Meson-GXBB/GXL,
> > the published datasheets[4] also has wrong description about this.
> > This patch should be explicitly merged *before* other patches.
> >
> > patch [2-4/4]:
> > Drop the "sana" clock from SAR ADC module,
> I agree with Jerome that patch 2/4 should be applied last.
Let me know when I should take this.
Thanks,
Jonathan
> when I wrote the driver I couldn't get it to work on my GXBB board
> (which unfortunately has died since then) because the clocks were
> disabled (they weren't enabled by the bootloader). people who are
> using an old .dtb would get the same problem again until the clock
> driver is merged
>
> > From the hardware perspective, the SAR ADC module doesn't
> > require "sana" clock to wrok. This should apply to all SoC,
> > including meson6,8, GXBB, GXL..
> thank you for clarifying this!
>
> > Note: the whole patchset series has been tested at GXL-P212 board,
> > we haven't got any meson6,8 board to test, so I would appreciate
> > if someone (Martin?) could help to confirm it works there.
> I can test this on a Meson8b and a Meson8m2 board on the weekend -
> I'll let you know about the results
>
>
> Regards
> Martin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-11 0:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 14:09 [PATCH v4 0/4] fix the clock setting for SAR ADC Yixun Lan
2017-11-07 14:09 ` Yixun Lan
2017-11-07 14:09 ` Yixun Lan
2017-11-07 14:09 ` Yixun Lan
2017-11-07 21:36 ` Martin Blumenstingl
2017-11-07 21:36 ` Martin Blumenstingl
2017-11-07 21:36 ` Martin Blumenstingl
2017-11-07 21:36 ` Martin Blumenstingl
2017-11-11 0:37 ` Jonathan Cameron [this message]
2017-11-11 0:37 ` Jonathan Cameron
2017-11-11 0:37 ` Jonathan Cameron
2017-11-11 0:37 ` Jonathan Cameron
2017-11-11 0:37 ` Jonathan Cameron
2017-11-28 13:11 ` Yixun Lan
2017-11-28 13:11 ` Yixun Lan
2017-11-28 13:11 ` Yixun Lan
2017-11-28 13:11 ` Yixun Lan
2017-12-02 11:38 ` Jonathan Cameron
2017-12-02 11:38 ` Jonathan Cameron
2017-12-02 11:38 ` Jonathan Cameron
2017-12-02 11:38 ` Jonathan Cameron
2017-11-12 1:35 ` Martin Blumenstingl
2017-11-12 1:35 ` Martin Blumenstingl
2017-11-12 1:35 ` Martin Blumenstingl
2017-11-12 1:35 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171111003737.000038f0@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.