All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jérôme Carretero" <cJ-ko@zougloub.eu>
To: Andrey Astafyev <1@246060.ru>, Hans de Goede <hdegoede@redhat.com>
Cc: Oliver Neukum <oneukum@suse.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device
Date: Mon, 13 Nov 2017 01:14:38 -0500	[thread overview]
Message-ID: <20171113011438.458369bf@Vantage.cJ> (raw)
In-Reply-To: <46d6dde9-e811-9655-96db-a046de521782@246060.ru>

On Mon, 13 Nov 2017 07:01:30 +0300
Andrey Astafyev <1@246060.ru> wrote:

> 13.11.2017 00:42, Jérôme Carretero пишет:
> > Nov 12 16:20:59 Bidule kernel: sd 22:0:0:0: [sdaa] tag#2 
> > uas_eh_abort_handler 0 uas-tag 3 inflight: CMD OUT
> > [...]
> > Do you see such things?
> >  
> Hi, I've seen dmesg output like this so I've added my device to
> quirks list like any other Seagate USB drive.

Hi Andrey, Hans,


For my devices, adding US_FL_NO_ATA_1X to unusual_uas.h didn't
change anything, and while adding US_FL_IGNORE_UAS (using
quirks=0bc2:ab34:u,0bc2:ab38:u) there are still device resets,
but they cause shorter hangs in system activity (~1 second when
UAS was more like ~20).

Is the US_FL_NO_ATA_1X supposed to get rid of the R/W errors?
The first entry I saw about this quirk was so that the device can
be used at all (wouldn't be able to mount without it).


I'll follow up: when scrubbing the devices after a sequence of
experiments, there were checksum errors, so I'll retry with a more
reproducible sequence to try and get something more solid.
I wouldn't want to disable UAS just to see that reliability has
been reduced (one Arch bug report mentions something like that
https://bugs.archlinux.org/task/48362).


Regards,

-- 
Jérôme

PS: The controllers I tested do the same:

09:00.0 USB controller: Fresco Logic FL1100 USB 3.0 Host Controller (rev 10)
0c:00.0 USB controller: NEC Corporation uPD720200 USB 3.0 Host Controller (rev 03)

  reply	other threads:[~2017-11-13  6:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10 15:13 [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device Hans de Goede
2017-11-12 21:42 ` Jérôme Carretero
     [not found]   ` <20171112164234.48b5185c-WI5o+PA4G9BYumZHjSPV5A@public.gmane.org>
2017-11-13  4:01     ` Andrey Astafyev
2017-11-13  6:14       ` Jérôme Carretero [this message]
2017-11-13  6:16         ` Andrey Astafyev
2017-11-13  7:14           ` Jérôme Carretero
     [not found]         ` <20171113011438.458369bf-WI5o+PA4G9BYumZHjSPV5A@public.gmane.org>
2017-11-13  9:04           ` Hans de Goede
     [not found]             ` <3d276729-63f7-9727-4a22-55849712439c-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-11-13 17:38               ` Jérôme Carretero
     [not found]                 ` <20171113123814.4e70a498-WI5o+PA4G9BYumZHjSPV5A@public.gmane.org>
2017-11-15 21:43                   ` Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device) Jérôme Carretero
     [not found]                     ` <20171115164314.74ce972f-WI5o+PA4G9BYumZHjSPV5A@public.gmane.org>
2017-11-15 21:49                       ` Jérôme Carretero
     [not found]                         ` <20171115164902.00d1330d-WI5o+PA4G9BYumZHjSPV5A@public.gmane.org>
2017-11-15 22:02                           ` Alan Stern
2017-11-15 22:40                             ` James Bottomley
2017-11-15 23:17                               ` Jérôme Carretero
2017-11-16  4:21                                 ` Seagate External SMR drive USB resets (XHCI transfer error, not timeout) Jérôme Carretero
     [not found]                                   ` <20171115232129.102a1122-WI5o+PA4G9BYumZHjSPV5A@public.gmane.org>
2017-11-16 19:42                                     ` Alan Stern
2017-11-17 22:19                                       ` Jérôme Carretero
2017-11-18 16:57                                         ` Alan Stern
2017-11-15 23:27                             ` Seagate External SMR drive USB resets... why? / USB storage debugging Jérôme Carretero
     [not found]                               ` <20171115182708.25b97ebe-WI5o+PA4G9BYumZHjSPV5A@public.gmane.org>
2017-11-15 23:40                                 ` Bart Van Assche
  -- strict thread matches above, loose matches on Subject: below --
2017-11-14 14:00 [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device Hans de Goede
2017-11-14 14:00 ` Hans de Goede
     [not found] ` <20171114140017.17782-1-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-11-14 14:04   ` Hans de Goede
2017-11-14 14:04     ` Hans de Goede
2017-11-14 15:25     ` Alan Stern
2017-11-14 15:25       ` Alan Stern
2017-11-14 17:44       ` Hans de Goede
2017-11-15  9:06         ` Oliver Neukum
2017-11-15  9:32           ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171113011438.458369bf@Vantage.cJ \
    --to=cj-ko@zougloub.eu \
    --cc=1@246060.ru \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.