From: Stephen Boyd <sboyd@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: cdce925: remove redundant check for non-null parent_name
Date: Tue, 14 Nov 2017 01:56:59 +0000 [thread overview]
Message-ID: <20171114015659.GB11955@codeaurora.org> (raw)
In-Reply-To: <20170905150348.20041-1-colin.king@canonical.com>
On 09/05, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check for a non-null parent_name is always true as there is an
> earlier check for a null parent_name that returns -ENODEV. Remove this
> redundant check and always set init.num_parents to 1.
>
> Detected by CoverityScan CID#1309477 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: cdce925: remove redundant check for non-null parent_name
Date: Mon, 13 Nov 2017 17:56:59 -0800 [thread overview]
Message-ID: <20171114015659.GB11955@codeaurora.org> (raw)
In-Reply-To: <20170905150348.20041-1-colin.king@canonical.com>
On 09/05, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The check for a non-null parent_name is always true as there is an
> earlier check for a null parent_name that returns -ENODEV. Remove this
> redundant check and always set init.num_parents to 1.
>
> Detected by CoverityScan CID#1309477 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-11-14 1:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 15:03 [PATCH] clk: cdce925: remove redundant check for non-null parent_name Colin King
2017-09-05 15:03 ` Colin King
2017-11-14 1:56 ` Stephen Boyd [this message]
2017-11-14 1:56 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114015659.GB11955@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.